[Pywikibot-commits] [Gerrit] pywikibot/core[master]: [bugfix] rename the mainpage image because "image" is alread...

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/371719 ) Change subject: [bugfix] rename the mainpage image because "image" is already in use ...................................................................... [bugfix] rename the mainpage image because "image" is already in use Bug: T172770 Change-Id: I9e5729c803ed6d6b763dc1fe25eba47945038b47 --- M tests/page_tests.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/page_tests.py b/tests/page_tests.py index 17c69ef..3c74326 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -563,10 +563,9 @@ if MediaWikiVersion(site.version()) < MediaWikiVersion('1.20'): self.assertRaises(NotImplementedError, mainpage.page_image) elif site.has_extension('PageImages'): - image = mainpage.page_image() - if image is not None: - self.assertIsInstance(mainpage.page_image(), - pywikibot.FilePage) + mainpage_image = mainpage.page_image() + if mainpage_image is not None: + self.assertIsInstance(mainpage_image, pywikibot.FilePage) # for file pages, the API should return the file itself self.assertEqual(image.page_image(), image) else: -- To view, visit https://gerrit.wikimedia.org/r/371719 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e5729c803ed6d6b763dc1fe25eba47945038b47 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Strainu &lt;wiki(a)strainu.ro&gt; Gerrit-Reviewer: jenkins-bot <>