jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/626722 )
Change subject: [tests] Page.getReferences() instead of deprecated ReferringPageGenerator
......................................................................
[tests] Page.getReferences() instead of deprecated ReferringPageGenerator
- pagegenerators.ReferringPageGenerator is deprecated.
Use Page.getReferences() for test instead.
- Also update deprecation message.
Change-Id: Icf3359526e729509b08133b9e9b216ea5735ed9f
---
M pywikibot/pagegenerators.py
M tests/wikibase_tests.py
2 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Matěj Suchánek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index 4e7dc6d..59cbd09 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -1491,7 +1491,7 @@
return (pywikibot.Page(link) for link in page.iterlanglinks(total=total))
-(a)deprecated('Page.getReferences()'s()', since='20200515')
+(a)deprecated('Page.getReferences(follow_redirects=False)'se)',
since='20200515')
@deprecated_args(step=None)
def ReferringPageGenerator(referredPage, followRedirects=False,
withTemplateInclusion=True,
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py
index 7c24600..0692991 100644
--- a/tests/wikibase_tests.py
+++ b/tests/wikibase_tests.py
@@ -1987,11 +1987,10 @@
}
def test_non_item_gen(self):
- """Test PreloadingEntityGenerator with
ReferringPageGenerator."""
+ """Test PreloadingEntityGenerator with
getReferences()."""
site = self.get_site('wikidata')
- instance_of_page = pywikibot.Page(site, 'Property:P31')
- ref_gen = pagegenerators.ReferringPageGenerator(
- instance_of_page, total=5)
+ page = pywikibot.Page(site, 'Property:P31')
+ ref_gen = page.getReferences(follow_redirects=False, total=5)
gen = pagegenerators.PreloadingEntityGenerator(ref_gen)
self.assertTrue(all(isinstance(item, ItemPage) for item in gen))
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/626722
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Icf3359526e729509b08133b9e9b216ea5735ed9f
Gerrit-Change-Number: 626722
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged