[Pywikibot-commits] [Gerrit] Just few code improvements: - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Just few code improvements: ...................................................................... Just few code improvements: - enable summary option which didn't work previously - add -summary to doc string - use core-like page.save - remove obsolete script name from showHelp Change-Id: Iab5cde2d9b6f07e3df3d58ca7e952f57574a35f8 --- M scripts/reflinks.py 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/reflinks.py b/scripts/reflinks.py index 089ef3a..e9fd399 100644 --- a/scripts/reflinks.py +++ b/scripts/reflinks.py @@ -30,6 +30,9 @@ -ignorepdf Do not handle PDF files (handy if you use Windows and can't get pdfinfo) + +-summary Use a custom edit summary. Otherwise it uses the default + one from i18n/reflinks.py """ # (C) 2008 - Nicolas Dumazet ( en:User:NicDumZ ) # (C) Pywikibot team, 2008-2014 @@ -385,7 +388,8 @@ class ReferencesRobot: - def __init__(self, generator, acceptall=False, limit=None, ignorepdf=False): + def __init__(self, generator, acceptall=False, limit=None, ignorepdf=False, + summary=None): """ - generator : Page generator - acceptall : boolean, is -always on ? @@ -407,7 +411,10 @@ break if code: manual += '/%s' % code - self.msg = i18n.twtranslate(self.site, 'reflinks-msg', locals()) + if summary is None: + self.msg = i18n.twtranslate(self.site, 'reflinks-msg', locals()) + else: + self.msg = summary self.stopPage = pywikibot.Page(self.site, pywikibot.translate(self.site, stopPage)) @@ -455,10 +462,12 @@ if choice == 'a': self.acceptall = True if choice == 'y': - page.put_async(new, self.msg) + page.text = new + page.save(self.msg, async=True) if self.acceptall: try: - page.put(new, self.msg) + page.text = new + page.save(self.msg) except pywikibot.EditConflict: pywikibot.output(u'Skipping %s because of edit conflict' % (page.title(),)) @@ -786,6 +795,7 @@ limit = None namespaces = [] generator = None + summary = None # Process global args and prepare generator args parser local_args = pywikibot.handleArgs() @@ -798,7 +808,7 @@ except ValueError: namespaces.append(arg[11:]) elif arg.startswith('-summary:'): - pywikibot.setAction(arg[9:]) + summary = arg[9:] elif arg == '-always': always = True elif arg == '-ignorepdf': @@ -830,11 +840,11 @@ generator = genFactory.getCombinedGenerator() if not generator: # syntax error, show help text from the top of this file - pywikibot.showHelp('reflinks') + pywikibot.showHelp() return generator = pagegenerators.PreloadingGenerator(generator, step=50) generator = pagegenerators.RedirectFilterPageGenerator(generator) - bot = ReferencesRobot(generator, always, limit, ignorepdf) + bot = ReferencesRobot(generator, always, limit, ignorepdf, summary) bot.run() if __name__ == "__main__": -- To view, visit https://gerrit.wikimedia.org/r/137302 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5cde2d9b6f07e3df3d58ca7e952f57574a35f8 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: Ricordisamoa &lt;ricordisamoa(a)openmailbox.org&gt; Gerrit-Reviewer: jenkins-bot <>