jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/338617 )
Change subject: Make PropertyPage.get() return a dictionary
......................................................................
Make PropertyPage.get() return a dictionary
This is consistent with the parent method and ItemPage.get() do.
This shouldn't be a breaking change, I believe.
Change-Id: Icf0bff007b6d44efe000cdab3a565f19d0bd4a2c
---
M pywikibot/page.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/page.py b/pywikibot/page.py
index c401000..1f61088 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -4349,9 +4349,10 @@
raise NotImplementedError(
'PropertyPage.get only implements "force".')
- if force or not hasattr(self, '_content'):
- WikibasePage.get(self, force)
+ data = WikibasePage.get(self, force)
self._type = self._content['datatype']
+ data['datatype'] = self._content['datatype']
+ return data
def newClaim(self, *args, **kwargs):
"""
--
To view, visit
https://gerrit.wikimedia.org/r/338617
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf0bff007b6d44efe000cdab3a565f19d0bd4a2c
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>