[Pywikibot-commits] [Gerrit] interwiki.py: add and reorganize error handling around ignor... - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: interwiki.py: add and reorganize error handling around ignored links ...................................................................... interwiki.py: add and reorganize error handling around ignored links Handling of InvalidTitle is added to deal with comments like <!-- [[Category:{{ja}} {{noun}}]] -->. Two consecutive try-except blocks are unified for readability. Change-Id: I890f4071b829aebcb75d32825ae886b5261f2852 --- M scripts/interwiki.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/interwiki.py b/scripts/interwiki.py index 019b478..36d853c 100755 --- a/scripts/interwiki.py +++ b/scripts/interwiki.py @@ -1832,9 +1832,6 @@ for iw in re.finditer('<!-- *\[\[(.*?:.*?)\]\] *-->', pagetext): try: ignorepage = pywikibot.Page(page.site, iw.groups()[0]) - except (pywikibot.NoSuchSite, ): - continue - try: if (new[ignorepage.site] == ignorepage) and \ (ignorepage.site != page.site): if (ignorepage not in interwikis): @@ -1850,6 +1847,10 @@ 'from': page}) except KeyError: pass + except pywikibot.NoSuchSite: + pass + except pywikibot.InvalidTitle: + pass # sanity check - the page we are fixing must be the only one for that # site. -- To view, visit https://gerrit.wikimedia.org/r/131062 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I890f4071b829aebcb75d32825ae886b5261f2852 Gerrit-PatchSet: 7 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Whym &lt;whym(a)whym.org&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: Ricordisamoa &lt;ricordisamoa(a)live.it&gt; Gerrit-Reviewer: Whym &lt;whym(a)whym.org&gt; Gerrit-Reviewer: jenkins-bot <>