[Pywikibot-commits] [Gerrit] pywikibot/core[master]: page.Category.articles: Fix the equivalant of startFrom in core

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/428263 ) Change subject: page.Category.articles: Fix the equivalant of startFrom in core ...................................................................... page.Category.articles: Fix the equivalant of startFrom in core The way `startFrom` works in compat is equal to `startprefix` in core.[1] `startsort`, which is deprecated in MW 1.24, needs to be a binary string,[2] otherwise the user will get the wrong results because of the wrong start. This means that compat's `startFrom` has no equivalant in core if the MediaWiki version is less than 1.18. [1]: https://phabricator.wikimedia.org/diffusion/PWBO/browse/master/catlib.py;df… [2]: https://www.mediawiki.org/wiki/API:Categorymembers Change-Id: I10620e82d2d0792579889199ffa5e94a0cce0d07 --- M pywikibot/page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Zhuyifei1999: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 97c6681..93d5f40 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -2798,7 +2798,7 @@ if total == 0: return - @deprecated_args(startFrom='startsort', step=None) + @deprecated_args(startFrom='startprefix', step=None) def articles(self, recurse=False, total=None, content=False, namespaces=None, sortby=None, reverse=False, starttime=None, endtime=None, -- To view, visit https://gerrit.wikimedia.org/r/428263 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I10620e82d2d0792579889199ffa5e94a0cce0d07 Gerrit-Change-Number: 428263 Gerrit-PatchSet: 1 Gerrit-Owner: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zhuyifei1999 &lt;zhuyifei1999(a)gmail.com&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>