[Pywikibot-commits] [Gerrit] Replace 'return' with a proper SkipTest wrt mwpfh - change (pywikibot/core)

XZise has submitted this change and it was merged. Change subject: Replace 'return' with a proper SkipTest wrt mwpfh ...................................................................... Replace 'return' with a proper SkipTest wrt mwpfh Change-Id: Ib73fe09c1510e80b43b4da2179579bf6581aad86 --- M tests/textlib_tests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: XZise: Looks good to me, approved diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py index d4586e5..ba93f01 100644 --- a/tests/textlib_tests.py +++ b/tests/textlib_tests.py @@ -52,7 +52,7 @@ def testExtractTemplates(self): if not (pywikibot.config.use_mwparserfromhell and mwparserfromhell): - return # We'll test the regex function in the test below + raise unittest.SkipTest('mwparserfromhell not available or enabled') func = textlib.extract_templates_and_params # It's really long. self.assertEqual(func('{{a}}'), [('a', {})]) self.assertEqual(func('{{a|b=c}}'), [('a', {'b': 'c'})]) -- To view, visit https://gerrit.wikimedia.org/r/160934 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73fe09c1510e80b43b4da2179579bf6581aad86 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: jenkins-bot <>