[Pywikibot-commits] [Gerrit] Expand wikistats datatype tests - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Expand wikistats datatype tests ...................................................................... Expand wikistats datatype tests Bug: T128990 Change-Id: I6529c73c327da7272486cb479c6de8a2052b20a5 --- M tests/wikistats_tests.py 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/wikistats_tests.py b/tests/wikistats_tests.py index 4d59623..e255968 100644 --- a/tests/wikistats_tests.py +++ b/tests/wikistats_tests.py @@ -30,6 +30,9 @@ self.assertIn('prefix', top) self.assertIn('total', top) self.assertEqual(top['prefix'], 'en') + self.assertTrue(all(isinstance(key, UnicodeType) + for key in top.keys() + if key is not None)) self.assertIsInstance(top['total'], UnicodeType) self.assertEqual(ws.languages_by_size('wikipedia')[0], 'en') self.assertEqual(ws.languages_by_size('wikisource')[0], 'fr') @@ -44,7 +47,13 @@ self.assertIn('en', data) self.assertIn('ht', data) self.assertGreater(int(data['en']['total']), 4000000) - data = ws.get_dict + data = data['en'] + self.assertTrue(all(isinstance(key, UnicodeType) + for key in data.keys() + if key is not None)) + self.assertIsInstance(data['total'], UnicodeType) + self.assertIn('prefix', data) + self.assertIn('total', data) def test_xml(self): """Test XML.""" @@ -54,6 +63,13 @@ self.assertIn('en', data) self.assertIn('id', data) self.assertGreater(int(data['fr']['total']), 1600000) + data = data['fr'] + self.assertTrue(all(isinstance(key, UnicodeType) + for key in data.keys() + if key is not None)) + self.assertIsInstance(data['total'], UnicodeType) + self.assertIn('prefix', data) + self.assertIn('total', data) if __name__ == '__main__': -- To view, visit https://gerrit.wikimedia.org/r/275511 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6529c73c327da7272486cb479c6de8a2052b20a5 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>