jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/723712 )
Change subject: [fix] pagefromfile: don't ask for confirmation by default
......................................................................
[fix] pagefromfile: don't ask for confirmation by default
Bug: T291757
Change-Id: I72a94910db219cc1962cf5e13f73a9ee1543d9f3
---
M scripts/pagefromfile.py
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/pagefromfile.py b/scripts/pagefromfile.py
index c8ddd9e..e54e409 100755
--- a/scripts/pagefromfile.py
+++ b/scripts/pagefromfile.py
@@ -104,12 +104,6 @@
'showdiff': False,
}
- def __init__(self, **kwargs) -> None:
- """Initializer."""
- super().__init__(**kwargs)
- self.available_options.update(
- {'always': not self.opt.showdiff})
-
def init_page(self, item) -> pywikibot.Page:
"""Get the tuple and return the page object to be
processed."""
title, content = item
@@ -309,6 +303,8 @@
else:
pywikibot.output('Disregarding unknown argument {}.'.format(arg))
+ options['always'] = 'showdiff' not in options
+
failed_filename = False
while not os.path.isfile(filename):
pywikibot.output("\nFile '{}' does not exist.
".format(filename))
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/723712
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I72a94910db219cc1962cf5e13f73a9ee1543d9f3
Gerrit-Change-Number: 723712
Gerrit-PatchSet: 3
Gerrit-Owner: JJMC89 <JJMC89.Wikimedia(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged