jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/635953 )
Change subject: [tests] Do not skip tests due to MaxlagTimeoutError
......................................................................
[tests] Do not skip tests due to MaxlagTimeoutError
After T242081 has been solved upstream, do not skip MaxlagTimeoutError
anymore to detect such failures again.
Bug: T242081
Change-Id: I7659adffa915e04adeea06937eca27e34ed4b43a
---
M pywikibot/data/api.py
1 file changed, 3 insertions(+), 8 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py
index 00f7f38..b452ee4 100644
--- a/pywikibot/data/api.py
+++ b/pywikibot/data/api.py
@@ -1988,19 +1988,14 @@
param_repr = str(self._params)
pywikibot.log('API Error: query=\n%s'
% pprint.pformat(param_repr))
- pywikibot.log(' response=\n%s'
- % result)
+ pywikibot.log(' response=\n{}'.format(result))
raise APIError(**result['error'])
except TypeError:
raise RuntimeError(result)
- msg = 'Maximum retries attempted due to maxlag without success.'
- if os.environ.get('PYWIKIBOT_TESTS_RUNNING', '0') ==
'1':
- import unittest
- raise unittest.SkipTest(msg)
-
- raise MaxlagTimeoutError(msg)
+ raise MaxlagTimeoutError(
+ 'Maximum retries attempted due to maxlag without success.')
def wait(self, delay=None):
"""Determine how long to wait after a failed
request."""
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/635953
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I7659adffa915e04adeea06937eca27e34ed4b43a
Gerrit-Change-Number: 635953
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged