[Pywikibot-commits] [Gerrit] Bug 65145: do not run generate_user_files if stdout is a pipe - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Bug 65145: do not run generate_user_files if stdout is a pipe ...................................................................... Bug 65145: do not run generate_user_files if stdout is a pipe pip will run generate_user_files with stdout directed to a log file, but stdin as a terminal. As such, GUF will wait for user input, but the user has no idea they should input anything. This change prevents that. Change-Id: Iaa596bf40e4d49c73b9a73ee6423c3a6b6899449 --- M setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/setup.py b/setup.py index 580f9b1..2b7e22f 100644 --- a/setup.py +++ b/setup.py @@ -47,7 +47,7 @@ def run(self): install.install.do_egg_install(self) - if sys.stdin.isatty(): + if sys.stdin.isatty() and sys.stdout.isatty(): import subprocess python = sys.executable python = python.replace("pythonw.exe", "python.exe") # for Windows -- To view, visit https://gerrit.wikimedia.org/r/132713 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa596bf40e4d49c73b9a73ee6423c3a6b6899449 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>