[Pywikibot-commits] [Gerrit] pywikibot/core[master]: [bugfix] Set default current_page on top

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/420170 ) Change subject: [bugfix] Set default current_page on top ...................................................................... [bugfix] Set default current_page on top current_page must be set on each treat call but due to its magic it must be set only once. Therefore use a local variable. Bug: T189635 Change-Id: If963578b2a39219e52208d9f62f3287b3643ab26 --- M scripts/category.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Dvorapa: Looks good to me, but someone else must approve Zhuyifei1999: Looks good to me, but someone else must approve Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/category.py b/scripts/category.py index bedd4c9..1aade2f 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -349,17 +349,17 @@ # loading it will throw an error if we don't jump out before return else: + current_page = page if page.namespace() == page.site.namespaces.TEMPLATE: docs = page.site.doc_subpage # return tuple for doc in docs: doc_page = pywikibot.Page( page.site, page.title() + doc) if doc_page.exists(): - self.current_page = doc_page + current_page = doc_page includeonly = ['includeonly'] break - if not self.current_page: - self.current_page = page + self.current_page = current_page if self.current_page.exists(): # Load the page text = self.current_page.text -- To view, visit https://gerrit.wikimedia.org/r/420170 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If963578b2a39219e52208d9f62f3287b3643ab26 Gerrit-Change-Number: 420170 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: Dvorapa &lt;dvorapa(a)seznam.cz&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Mpaa &lt;mpaa.wiki(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zhuyifei1999 &lt;zhuyifei1999(a)gmail.com&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>