jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/512110 )
Change subject: [cleanup] remove # TODO because it was done already
......................................................................
[cleanup] remove # TODO because it was done already
logtype is checked in _handle_logevents() already
Change-Id: I40e9416e094c1f1c31d2ef6f84633360ef498e88
---
M pywikibot/pagegenerators.py
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index ea2ae8e..53110f9 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -670,11 +670,8 @@
@return: The generator or None if invalid 'total' value.
@rtype: LogeventsPageGenerator
"""
- # TODO: Check if logtype is one of the allowed log types
-
- # 'start or None', because start might be an empty string
total = None
- start = start or None
+ start = start or None # because start might be an empty string
if isinstance(start, UnicodeType) and len(start) == 8:
start = pywikibot.Timestamp.strptime(start, '%Y%m%d')
elif start is not None:
--
To view, visit
https://gerrit.wikimedia.org/r/512110
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I40e9416e094c1f1c31d2ef6f84633360ef498e88
Gerrit-Change-Number: 512110
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)