[Pywikibot-commits] [Gerrit] pywikibot/core[master]: Save pageid from wbgetentities

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/338765 ) Change subject: Save pageid from wbgetentities ...................................................................... Save pageid from wbgetentities wbgetentities provides it, why not to reuse it? Change-Id: I9f7d1fe4a8dbc497ea8edd9edb5dd0d0d7fa81d5 --- M pywikibot/page.py M tests/pages/Q60.wd M tests/wikibase_tests.py 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/page.py b/pywikibot/page.py index a268b1e..8a6090c 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3581,6 +3581,8 @@ raise pywikibot.NoPage(p) raise pywikibot.NoPage(self) + self._pageid = self._content['pageid'] + # aliases self.aliases = {} if 'aliases' in self._content: diff --git a/tests/pages/Q60.wd b/tests/pages/Q60.wd index 0792366..b242c7d 100644 --- a/tests/pages/Q60.wd +++ b/tests/pages/Q60.wd @@ -2,6 +2,7 @@ "id": "Q60", "type": "item", "lastrevid": 122836617, + "pageid": 186, "aliases": { "en": [ { diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index b00817b..87a00c8 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -1256,6 +1256,7 @@ del self.wdp._content['id'] del self.wdp._content['type'] del self.wdp._content['lastrevid'] + del self.wdp._content['pageid'] def test_itempage_json(self): """Test itempage json.""" -- To view, visit https://gerrit.wikimedia.org/r/338765 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7d1fe4a8dbc497ea8edd9edb5dd0d0d7fa81d5 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zhuyifei1999 &lt;zhuyifei1999(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>