[Pywikibot-commits] [Gerrit] pywikibot/core[master]: Improve readability and simplify _handle_recentchanges

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/444820 ) Change subject: Improve readability and simplify _handle_recentchanges ...................................................................... Improve readability and simplify _handle_recentchanges Change-Id: I7a7e7a025dab575e7f8b0cca3f0dc5c090aa83ad --- M pywikibot/pagegenerators.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index bceae51..04a80df 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -801,19 +801,18 @@ params = value.split(',') if value else [] if params and not params[0].isdigit(): rctag = params.pop(0) - if len(params) == 2: + if len(params) > 2: + raise ValueError('More than two parameters passed.') + elif len(params) == 2: offset = float(params[0]) duration = float(params[1]) if offset < 0 or duration < 0: raise ValueError('Negative valued parameters passed.') - elif len(params) > 2: - raise ValueError('More than two parameters passed.') - else: - total = int(params[0]) if params else 60 - if len(params) == 2: ts_time = self.site.server_time() rcstart = ts_time + timedelta(minutes=-(offset + duration)) rcend = ts_time + timedelta(minutes=-offset) + else: + total = int(params[0]) if params else 60 return RecentChangesPageGenerator( namespaces=self.namespaces, total=total, start=rcstart, end=rcend, site=self.site, reverse=True, tag=rctag, -- To view, visit https://gerrit.wikimedia.org/r/444820 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a7e7a025dab575e7f8b0cca3f0dc5c090aa83ad Gerrit-Change-Number: 444820 Gerrit-PatchSet: 1 Gerrit-Owner: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot