jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/722265 )
Change subject: [debug] do not pass OtherPageSaveRelatedError silently
......................................................................
[debug] do not pass OtherPageSaveRelatedError silently
do not pass OtherPageSaveRelatedError raised by allow_asynchronous decorator
silently in newitem.py and touch.py scripts
patch detached from Ic3c0e62
Change-Id: I6dbdf5b6942efce36b2bd9b8f95405e96b6ddc4a
---
M scripts/newitem.py
M scripts/touch.py
2 files changed, 5 insertions(+), 7 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/newitem.py b/scripts/newitem.py
index 570eb9c..5109362 100755
--- a/scripts/newitem.py
+++ b/scripts/newitem.py
@@ -20,7 +20,7 @@
"""
#
-# (C) Pywikibot team, 2014-2020
+# (C) Pywikibot team, 2014-2021
#
# Distributed under the terms of the MIT license.
#
@@ -88,9 +88,8 @@
except LockedPageError:
pywikibot.error('Page {} is locked.'.format(
page.title(as_link=True)))
- except PageSaveRelatedError:
- pywikibot.error('Page {} not saved.'.format(
- page.title(as_link=True)))
+ except PageSaveRelatedError as e:
+ pywikibot.error('Page {} not saved:\n{}'.format(page, e.args))
def _callback(self, page, exc) -> None:
if exc is None and self.opt.touch:
diff --git a/scripts/touch.py b/scripts/touch.py
index 5a68ff0..2aeb1db 100755
--- a/scripts/touch.py
+++ b/scripts/touch.py
@@ -59,9 +59,8 @@
except LockedPageError:
pywikibot.error('Page {} is locked.'
.format(page.title(as_link=True)))
- except PageSaveRelatedError:
- pywikibot.error('Page {} not saved.'
- .format(page.title(as_link=True)))
+ except PageSaveRelatedError as e:
+ pywikibot.error('Page {} not saved:\n{}'.format(page, e.args))
class PurgeBot(MultipleSitesBot):
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/722265
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I6dbdf5b6942efce36b2bd9b8f95405e96b6ddc4a
Gerrit-Change-Number: 722265
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged