jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/500441 )
Change subject: [cleanup] use page_namespaces as a set instead a list
......................................................................
[cleanup] use page_namespaces as a set instead a list
Change-Id: I08733690a8d56e89d2e5dbffab4303e62fc604ab
---
M tests/aspects.py
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/aspects.py b/tests/aspects.py
index 79af4f8..71f14e6 100644
--- a/tests/aspects.py
+++ b/tests/aspects.py
@@ -249,14 +249,14 @@
else:
assert isinstance(namespaces, set)
- page_namespaces = [page.namespace() for page in gen]
+ page_namespaces = {page.namespace() for page in gen}
- if skip and set(page_namespaces) != namespaces:
+ if skip and page_namespaces != namespaces:
raise unittest.SkipTest('Pages in namespaces {!r} not found.'
- .format(list(namespaces
- - set(page_namespaces))))
+ .format(
+ list(namespaces - page_namespaces)))
else:
- self.assertEqual(set(page_namespaces), namespaces)
+ self.assertEqual(page_namespaces, namespaces)
def assertPageTitlesEqual(self, gen, titles, site=None):
"""
--
To view, visit
https://gerrit.wikimedia.org/r/500441
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08733690a8d56e89d2e5dbffab4303e62fc604ab
Gerrit-Change-Number: 500441
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)