Pywikibot-commits December 2020

pywikibot-commits@lists.wikimedia.org

1 participants
103 discussions

[Gerrit] ...core[master]: [cleanup] Remove deprecated DataSite.get_item() method

by Mpaa (Code Review)

Mpaa has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647613 ) Change subject: [cleanup] Remove deprecated DataSite.get_item() method ...................................................................... [cleanup] Remove deprecated DataSite.get_item() method Change-Id: Ic7e8f07e88a2da48ba36fbaab56e8512ff1fc927 --- M pywikibot/site/__init__.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py index c6f2cae..9eca8de 100644 --- a/pywikibot/site/__init__.py +++ b/pywikibot/site/__init__.py @@ -5835,11 +5835,6 @@ 'API wbgetentities response lacks %s key' % props return wbdata[props] - @deprecated('pywikibot.ItemPage', since='20130307', future_warning=True) - def get_item(self, source, **params): # pragma: no cover - """Get the data for multiple Wikibase items.""" - return self._get_item(source, **params) - # Only separated from get_item to avoid the deprecation message via # _get_propertyitem def _get_item(self, source, **params): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647613 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic7e8f07e88a2da48ba36fbaab56e8512ff1fc927 Gerrit-Change-Number: 647613 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [IMPR] put_throttle may be given as float

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647653 ) Change subject: [IMPR] put_throttle may be given as float ...................................................................... [IMPR] put_throttle may be given as float Bug: T269741 Change-Id: I03a99539789222ea1d68ce63b458126033da3853 --- M pywikibot/__init__.py M pywikibot/bot.py M pywikibot/config2.py M pywikibot/throttle.py 4 files changed, 10 insertions(+), 7 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index 163d437..d78ca2f 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -1245,7 +1245,7 @@ remainingPages -= 1 remainingSeconds = datetime.timedelta( - seconds=(remainingPages * config.put_throttle)) + seconds=round(remainingPages * config.put_throttle)) return (remainingPages, remainingSeconds) if stop: diff --git a/pywikibot/bot.py b/pywikibot/bot.py index 82fc233..4e03769 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -778,7 +778,7 @@ elif option == '-user': username = value elif option in ('-putthrottle', '-pt'): - config.put_throttle = int(value) + config.put_throttle = float(value) elif option == '-log': if module_name not in config.log: config.log.append(module_name) diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 120b404..753d587 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -48,7 +48,7 @@ from locale import getdefaultlocale from os import getenv, environ from textwrap import fill -from typing import Optional +from typing import Optional, Union from warnings import warn from pywikibot.__metadata__ import __version__ as pwb_version @@ -636,7 +636,7 @@ # Slow down the robot such that it never makes a second page edit within # 'put_throttle' seconds. -put_throttle = 10 +put_throttle = 10 # type: Union[int, float] # Sometimes you want to know when a delay is inserted. If a delay is larger # than 'noisysleep' seconds, it is logged on the screen. diff --git a/pywikibot/throttle.py b/pywikibot/throttle.py index 89fe2b1..a11f992 100644 --- a/pywikibot/throttle.py +++ b/pywikibot/throttle.py @@ -11,7 +11,7 @@ from collections import namedtuple from contextlib import suppress -from typing import Optional +from typing import Optional, Union import pywikibot from pywikibot import config @@ -42,8 +42,11 @@ """ - def __init__(self, site, mindelay=None, maxdelay=None, writedelay=None, - multiplydelay=True): + def __init__(self, site, + mindelay: Optional[int] = None, + maxdelay: Optional[int] = None, + writedelay: Union[int, float, None] = None, + multiplydelay: bool = True): """Initializer.""" self.lock = threading.RLock() self.lock_write = threading.RLock() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647653 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I03a99539789222ea1d68ce63b458126033da3853 Gerrit-Change-Number: 647653 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [cleanup] Show a FutureWarning for deprecated ReferringPageGenerator

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647611 ) Change subject: [cleanup] Show a FutureWarning for deprecated ReferringPageGenerator ...................................................................... [cleanup] Show a FutureWarning for deprecated ReferringPageGenerator Change-Id: I6d0067ef4dc8781a5c2cd0054a2a3f7bcd014be3 --- M pywikibot/pagegenerators.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index 8791e7e..e67897a 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -1399,7 +1399,8 @@ return (pywikibot.Page(link) for link in page.iterlanglinks(total=total)) -@deprecated('Page.getReferences(follow_redirects=False)', since='20200515') +@deprecated('Page.getReferences(follow_redirects=False)', since='20200515', + future_warning=True) @deprecated_args(step=None) def ReferringPageGenerator(referredPage, followRedirects=False, withTemplateInclusion=True, -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647611 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I6d0067ef4dc8781a5c2cd0054a2a3f7bcd014be3 Gerrit-Change-Number: 647611 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [cleanup] Remove deprecatd Property.get_type()

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647614 ) Change subject: [cleanup] Remove deprecatd Property.get_type() ...................................................................... [cleanup] Remove deprecatd Property.get_type() Change-Id: I36b0e6689c04f51417d34a2a893f1afde749e909 --- M pywikibot/page/__init__.py M tests/wikibase_tests.py 2 files changed, 1 insertion(+), 18 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index 8e6fe80..ad2036d 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -4743,20 +4743,6 @@ self._type = self.repo.getPropertyType(self) return self._type - @deprecated('Property.type', since='20140607', future_warning=True) - def getType(self): # pragma: no cover - """ - Return the type of this property. - - It returns 'globecoordinate' for type 'globe-coordinate' - in order to be backwards compatible. See - https://gerrit.wikimedia.org/r/#/c/135405/ for background. - """ - if self.type == 'globe-coordinate': - return 'globecoordinate' - else: - return self._type - def getID(self, numeric=False): """ Get the identifier of this property. diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index e485ea9..14d8ab5 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -19,7 +19,7 @@ ClaimCollection, SiteLinkCollection, ) from pywikibot.site import Namespace, NamespacesDict -from pywikibot.tools import MediaWikiVersion, suppress_warnings +from pywikibot.tools import MediaWikiVersion from tests import join_pages_path, mock from tests.aspects import ( @@ -1375,17 +1375,14 @@ with self.assertRaisesRegex(pywikibot.InvalidTitle, regex): PropertyPage(wikidata, title='') - @suppress_warnings('pywikibot.page.Property.getType is deprecated') def test_globe_coordinate(self): """Test a coordinate PropertyPage has the correct type.""" wikidata = self.get_repo() property_page = PropertyPage(wikidata, 'P625') self.assertEqual(property_page.type, 'globe-coordinate') - self.assertEqual(property_page.getType(), 'globecoordinate') claim = pywikibot.Claim(wikidata, 'P625') self.assertEqual(claim.type, 'globe-coordinate') - self.assertEqual(claim.getType(), 'globecoordinate') def test_get(self): """Test PropertyPage.get() method.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647614 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I36b0e6689c04f51417d34a2a893f1afde749e909 Gerrit-Change-Number: 647614 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [cleanup] remove deprecated Family.server_time

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647622 ) Change subject: [cleanup] remove deprecated Family.server_time ...................................................................... [cleanup] remove deprecated Family.server_time Bug: T89451 Change-Id: Idfa5e69eaf9cf831ae7788dd959dc107a98060de --- M pywikibot/family.py 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/family.py b/pywikibot/family.py index c90d622..7d79448 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -1075,15 +1075,6 @@ return repo.code, repo.family.name return (None, None) - @deprecated('Site.server_time()', since='20141225', future_warning=True) - def server_time(self, code): - """ - DEPRECATED, use Site.server_time instead. - - Return a datetime object representing server time. - """ - return pywikibot.Site(code, self).server_time() - def isPublic(self, code): """Check the wiki require logging in before viewing it.""" return True -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647622 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Idfa5e69eaf9cf831ae7788dd959dc107a98060de Gerrit-Change-Number: 647622 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [cleanup] Cleanups and improvements from http.py and HttpRequest

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/648200 ) Change subject: [cleanup] Cleanups and improvements from http.py and HttpRequest ...................................................................... [cleanup] Cleanups and improvements from http.py and HttpRequest comms.threadedhttp.HttpRequest will be removed in favour of direct requests response. Therefore don't pass parameters to HttpRequest which are redundant to Requests or Response object. The Response contains the Request in its request attribute. - deprecate all HttpRequest parameters except charset which is still used by encoding method until it is replaced by chardet - deprecate args, body and methods property but retrieve data either from Resonse or Requests object during the deprecation period. - deprecate kwargs property which isn't used anymore - remove uri setter and headers setter which were never used because the attributes where only set by HttpRequest parameters - deprecate the previously introduced all_headers attribute in favour of request.headers - update charset inside encoding method from request.headers - call callbacks in http after Request response directly - update the only HttpRequest() constructor with the remaining parameters - update error_handling_callback. Exceptions from requests contains request and response attributes which can be used - update http_tests.py Bug: T265206 Change-Id: Icd91cd028a8588210ca33fbe4ebe30c24c54a2cf --- M pywikibot/comms/http.py M pywikibot/comms/threadedhttp.py M tests/http_tests.py 3 files changed, 93 insertions(+), 41 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py index deea88f..3323d20 100644 --- a/pywikibot/comms/http.py +++ b/pywikibot/comms/http.py @@ -19,6 +19,7 @@ import atexit import sys +from contextlib import suppress from http import cookiejar from string import Formatter from typing import Optional, Union @@ -355,7 +356,9 @@ raise Server414Error('Too long GET request') if isinstance(request.data, Exception): - error('An error occurred for uri ' + request.url) + with suppress(Exception): + # request.data exception may contain response and request attribute + error('An error occurred for uri ' + request.data.request.url) raise request.data from None # HTTP status 207 is also a success status for Webdav FINDPROP, @@ -491,8 +494,7 @@ callbacks.append(error_handling_callback) charset = kwargs.pop('charset', None) - request = threadedhttp.HttpRequest( - uri, method, params, body, headers, callbacks, charset, **kwargs) + request = threadedhttp.HttpRequest(charset=charset) auth = get_authentication(uri) if auth is not None and len(auth) == 4: @@ -519,7 +521,9 @@ request.data = e else: request.data = response - # error_handling_callback is called in HttpRequest data.setter + + for callback in callbacks: + callback(request) # if there's no data in the answer we're in trouble try: diff --git a/pywikibot/comms/threadedhttp.py b/pywikibot/comms/threadedhttp.py index 9e22711..1836e7b 100644 --- a/pywikibot/comms/threadedhttp.py +++ b/pywikibot/comms/threadedhttp.py @@ -12,7 +12,12 @@ from urllib.parse import urlparse import pywikibot -from pywikibot.tools import deprecated, deprecated_args, PYTHON_VERSION +from pywikibot.tools import ( + deprecated, + deprecated_args, + issue_deprecation_warning, + PYTHON_VERSION, +) if PYTHON_VERSION >= (3, 9): Dict = dict @@ -31,32 +36,51 @@ * an exception """ - @deprecated_args(headers='all_headers', uri='url') - def __init__(self, url, method='GET', params=None, body=None, + @deprecated_args(uri=True, method=True, params=True, body=True, + headers=True, all_headers=True) + def __init__(self, url=None, method=None, params=None, body=None, all_headers=None, callbacks=None, charset=None, **kwargs): """Initializer.""" - self.url = url - self.method = method - self.params = params - self.body = body - self.all_headers = all_headers if isinstance(charset, codecs.CodecInfo): self.charset = charset.name - elif charset: - self.charset = charset - elif all_headers and 'accept-charset' in all_headers: - self.charset = all_headers['accept-charset'] else: - self.charset = None + self.charset = charset - self.callbacks = callbacks - - self.args = [url, method, body, all_headers] - self.kwargs = kwargs - + self._kwargs = kwargs self._parsed_uri = None self._data = None + # deprecate positional parameters + if url: + issue_deprecation_warning("'url' parameter", depth=3, + warning_class=FutureWarning, + since='20201211') + if method: + issue_deprecation_warning("'method' parameter", + warning_class=FutureWarning, + since='20201211') + if params: + issue_deprecation_warning("'params' parameter", + warning_class=FutureWarning, + since='20201211') + if body: + issue_deprecation_warning("'body' parameter", + warning_class=FutureWarning, + since='20201211') + if all_headers: + issue_deprecation_warning("'all_headers' parameter", + warning_class=FutureWarning, + since='20201211') + if callbacks: + issue_deprecation_warning("'callbacks' parameter", + warning_class=FutureWarning, + since='20201211') + if kwargs: + for item in kwargs.items(): + issue_deprecation_warning('{}={!r} parameter'.format(*item), + warning_class=FutureWarning, + since='20201211') + def __getattr__(self, name): """Delegate undefined method calls to request.Response object.""" if self.exception and name in ('content', 'status_code'): @@ -64,30 +88,55 @@ return getattr(self.data, name) @property + @deprecated(since='20201211', future_warning=True) + def args(self): # pragma: no cover + """DEPRECATED: Return predefined argument list.""" + return [ + self.url, + self.request.method, + self.request.body, + self.all_headers, + ] + + @property + @deprecated('the `request.body` attribute', + since='20201211', future_warning=True) + def body(self): # pragma: no cover + """DEPRECATED: Return request body attribute.""" + return self.request.body + + @property + @deprecated(since='20201211', future_warning=True) + def kwargs(self): # pragma: no cover + """DEPRECATED: Return request body attribute.""" + return self._kwargs + + @property + @deprecated('the `request.method` attribute', + since='20201211', future_warning=True) + def method(self): # pragma: no cover + """DEPRECATED: Return request body attribute.""" + return self.request.method + + @property @deprecated('the `url` attribute', since='20201011', future_warning=True) def uri(self): # pragma: no cover """DEPRECATED. Return the response URL.""" return self.url - @uri.setter - @deprecated('the `url` attribute', since='20201011', future_warning=True) - def uri(self, value): # pragma: no cover - """DEPRECATED. Set the response URL.""" - self.url = value - @property - @deprecated('the `all_headers` property', since='20201011', + @deprecated('the `request.headers` property', since='20201011', future_warning=True) def headers(self): # pragma: no cover """DEPRECATED. Return the response headers.""" - return self.all_headers + return self.request.headers - @headers.setter - @deprecated('the `all_headers` property', since='20201011', + @property + @deprecated('the `request.headers` property', since='20201211', future_warning=True) - def headers(self, value): # pragma: no cover - """DEPRECATED. Set the response headers.""" - self.all_headers = value + def all_headers(self): # pragma: no cover + """DEPRECATED. Return the response headers.""" + return self.request.headers @property def data(self): @@ -106,10 +155,6 @@ """ self._data = value - if self.callbacks: - for callback in self.callbacks: - callback(self) - @property def exception(self) -> Optional[Exception]: """DEPRECATED. Get the exception, if any. @@ -191,6 +236,9 @@ if hasattr(self, '_encoding'): return self._encoding + if self.charset is None and self.request is not None: + self.charset = self.request.headers.get('accept-charset') + if self.charset is None and self.header_encoding is None: pywikibot.log("Http response doesn't contain a charset.") charset = 'latin1' diff --git a/tests/http_tests.py b/tests/http_tests.py index 70d2efe..fbb13ac 100644 --- a/tests/http_tests.py +++ b/tests/http_tests.py @@ -403,11 +403,11 @@ @staticmethod def _create_request(charset=None, data=UTF8_BYTES): """Helper method.""" - req = threadedhttp.HttpRequest('', charset=charset) + req = threadedhttp.HttpRequest(charset=charset) resp = requests.Response() resp.headers = {'content-type': 'charset=utf-8'} resp._content = data[:] - req._data = resp + req.data = resp return req def test_no_content_type(self): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/648200 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Icd91cd028a8588210ca33fbe4ebe30c24c54a2cf Gerrit-Change-Number: 648200 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [IMPR] Delegate undefined method calls to requests.Response object

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647719 ) Change subject: [IMPR] Delegate undefined method calls to requests.Response object ...................................................................... [IMPR] Delegate undefined method calls to requests.Response object Enable the following properties and methods: history, reason. cookies, elapsed, request, ok, is_redirect, is_permanent_redirect, apparent_encoding, links, raise_for_status Bug: T265206 Change-Id: I28f36266615bb1da6be4ea7d5643595a6ebee364 --- M pywikibot/comms/threadedhttp.py 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/comms/threadedhttp.py b/pywikibot/comms/threadedhttp.py index c5c0e38..9e22711 100644 --- a/pywikibot/comms/threadedhttp.py +++ b/pywikibot/comms/threadedhttp.py @@ -57,6 +57,12 @@ self._parsed_uri = None self._data = None + def __getattr__(self, name): + """Delegate undefined method calls to request.Response object.""" + if self.exception and name in ('content', 'status_code'): + return None + return getattr(self.data, name) + @property @deprecated('the `url` attribute', since='20201011', future_warning=True) def uri(self): # pragma: no cover @@ -154,11 +160,6 @@ return self.status_code @property - def status_code(self) -> Optional[int]: - """Return the HTTP response status.""" - return self.data.status_code if not self.exception else None - - @property def header_encoding(self): """Return charset given by the response header.""" if hasattr(self, '_header_encoding'): @@ -236,14 +237,6 @@ encoding, errors) if not self.exception else None @property - def content(self) -> bytes: - """Return the response in bytes. - - @note: The behaviour has been changed. - """ - return self.data.content if not self.exception else None - - @property def text(self) -> str: """Return the response decoded by the detected encoding.""" return self.content.decode(self.encoding) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647719 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I28f36266615bb1da6be4ea7d5643595a6ebee364 Gerrit-Change-Number: 647719 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [cleanup] Remove deprecated version.getfileversion function

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647616 ) Change subject: [cleanup] Remove deprecated version.getfileversion function ...................................................................... [cleanup] Remove deprecated version.getfileversion function Pywikibot does not have a version number for each file anymore. This function can be removed safely. Change-Id: I449be83403e933ec3611d5982e3569b091776f52 --- M pywikibot/version.py 1 file changed, 0 insertions(+), 33 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/version.py b/pywikibot/version.py index ce66b6f..333a7f0 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -5,7 +5,6 @@ # # Distributed under the terms of the MIT license. # -import codecs import datetime import json import os @@ -384,38 +383,6 @@ raise ParseError(repr(e) + ' while parsing ' + repr(buf)) -@deprecated('get_module_version, get_module_filename and get_module_mtime', - since='20150221', future_warning=True) -def getfileversion(filename: str): # pragma: no cover - """Retrieve revision number of file. - - Extracts __version__ variable containing Id tag, without importing it. - (thus can be done for any file) - - The version variable containing the Id tag is read and - returned. Because it doesn't import it, the version can - be retrieved from any file. - @param filename: Name of the file to get version - """ - _program_dir = _get_program_dir() - __version__ = None - mtime = None - fn = os.path.join(_program_dir, filename) - if os.path.exists(fn): - with codecs.open(fn, 'r', 'utf-8') as f: - for line in f.readlines(): - if line.find('__version__') == 0: - with suppress(Exception): - exec(line) - break - stat = os.stat(fn) - mtime = datetime.datetime.fromtimestamp(stat.st_mtime).isoformat(' ') - if mtime and __version__: - return '%s %s %s' % (filename, __version__[5:-1][:7], mtime) - else: - return None - - @deprecated('pywikibot.__version__', since='20201003') def get_module_version(module) -> Optional[str]: """ -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647616 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I449be83403e933ec3611d5982e3569b091776f52 Gerrit-Change-Number: 647616 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [bugfix] Remove HttpRequestURI tests

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/648582 ) Change subject: [bugfix] Remove HttpRequestURI tests ...................................................................... [bugfix] Remove HttpRequestURI tests site parameter of http.request is mandatory and may not be None. Remove test for outdated and removed behaviour with deprecation. Change-Id: I8ceeae15b88addd8afd2c9ed5eef914af8c6ad56 --- M tests/http_tests.py 1 file changed, 0 insertions(+), 30 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/http_tests.py b/tests/http_tests.py index 6b48725..e3a631e 100644 --- a/tests/http_tests.py +++ b/tests/http_tests.py @@ -49,36 +49,6 @@ self.assertIsInstance(r.raw, bytes) -class HttpRequestURI(DeprecationTestCase): - - """Tests using http.request without a site.""" - - sites = { - 'www-wp': { - 'hostname': 'www.wikipedia.org', - }, - 'www-wq': { - 'hostname': 'www.wikiquote.org', - }, - } - - def test_http(self): - """Test http.request using http://www.wikipedia.org/.""" - r = http.request(site=None, uri='http://www.wikipedia.org/') - self.assertIsInstance(r, str) - self.assertIn('<html lang="mul"', r) - self.assertOneDeprecationParts( - 'Invoking http.request without argument site', 'http.fetch()') - - def test_https(self): - """Test http.request using https://www.wikiquote.org/.""" - r = http.request(site=None, uri='https://www.wikiquote.org/') - self.assertIsInstance(r, str) - self.assertIn('<html lang="mul"', r) - self.assertOneDeprecationParts( - 'Invoking http.request without argument site', 'http.fetch()') - - class TestGetAuthenticationConfig(TestCase): """Test http.get_authentication.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/648582 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I8ceeae15b88addd8afd2c9ed5eef914af8c6ad56 Gerrit-Change-Number: 648582 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

[Gerrit] ...core[master]: [fix] Fix spelling mistakes

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/645838 ) Change subject: [fix] Fix spelling mistakes ...................................................................... [fix] Fix spelling mistakes Change-Id: Ic9b43ffea454d5e6d1cea1a0fc1eb64f4cc97092 --- M pywikibot/__init__.py M pywikibot/bot.py M pywikibot/bot_choice.py M pywikibot/comms/eventstreams.py M pywikibot/config2.py M pywikibot/data/api.py M pywikibot/i18n.py M pywikibot/logging.py M pywikibot/page/__init__.py M pywikibot/proofreadpage.py M pywikibot/site/__init__.py M pywikibot/site/_interwikimap.py M pywikibot/tools/__init__.py M pywikibot/tools/djvu.py M pywikibot/version.py M scripts/README.rst M scripts/category.py M scripts/data_ingestion.py M scripts/flickrripper.py M scripts/imageuncat.py M scripts/maintenance/make_i18n_dict.py M scripts/noreferences.py M scripts/replicate_wiki.py M tests/disambredir_tests.py M tests/eventstreams_tests.py M tests/tools_tests.py M tests/utils.py M tests/wikibase_tests.py 28 files changed, 56 insertions(+), 48 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index 163d437..f7ceda1 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -603,7 +603,7 @@ """ Convert the data to a pywikibot.Timestamp. - @raises ValueError: instance value can not be represented using + @raises ValueError: instance value cannot be represented using Timestamp """ if self.year <= 0: diff --git a/pywikibot/bot.py b/pywikibot/bot.py index 82fc233..a0d41f0 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -923,8 +923,8 @@ @param missing_action: Add an entry that no action was defined. @type missing_action: bool @param additional_text: Additional text added to the end. - @param missing_dependencies: A list of dependencies which can not - be imported. + @param missing_dependencies: A list of dependencies which cannot be + imported. @type missing_dependencies: list of str @return: True if an error message was printed, False otherwise """ @@ -1038,7 +1038,7 @@ """Class to get and set options. How to use options of OptionHandler and its BaseBot subclasses: - First define a available_options class attribute to define all + First define an available_options class attribute to define all available options: available_options = {'foo': 'bar', 'bar': 42, 'baz': False} diff --git a/pywikibot/bot_choice.py b/pywikibot/bot_choice.py index 7a00159..efef2d4 100755 --- a/pywikibot/bot_choice.py +++ b/pywikibot/bot_choice.py @@ -223,7 +223,7 @@ class Choice(StandardOption): - """A simple choice consisting of a option, shortcut and handler.""" + """A simple choice consisting of an option, shortcut and handler.""" def __init__(self, option, shortcut, replacer): """Initializer.""" diff --git a/pywikibot/comms/eventstreams.py b/pywikibot/comms/eventstreams.py index 456b35e..c7e6c67 100644 --- a/pywikibot/comms/eventstreams.py +++ b/pywikibot/comms/eventstreams.py @@ -227,7 +227,7 @@ @param args: You may pass your own filter functions here. Every function should be able to handle the data dict from events. @type args: callable - @param kwargs: Any key returned by event data with a event data value + @param kwargs: Any key returned by event data with an event data value for this given key. @type kwargs: str, list, tuple or other sequence @raise TypeError: A given args parameter is not a callable. diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 120b404..3ca7aad 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -7,7 +7,7 @@ PYWIKIBOT_DIR, or the same directory as pwb.py, or in a directory within the users home. See get_base_dir for more information. -If user-config.py can not be found in any of those locations, this module +If user-config.py cannot be found in any of those locations, this module will fail to load unless the environment variable PYWIKIBOT_NO_USER_CONFIG is set to a value other than '0'. i.e. PYWIKIBOT_NO_USER_CONFIG=1 will allow config to load without a user-config.py. However, warnings will be diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index c9f69a7..680550f 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -848,7 +848,7 @@ silently removed from the options (disabled by default). """ if self._site_set: - raise TypeError('The site can not be set multiple times.') + raise TypeError('The site cannot be set multiple times.') # If the entries written to this are valid, it will never be # overwritten self._valid_enable = set() @@ -1169,7 +1169,7 @@ # # When we can't easily check whether the extension is loaded, # to avoid cyclic recursion in the Pywikibot codebase, assume - # that it is present, which will cause a API warning emitted + # that it is present, which will cause an API warning emitted # to the logging (console) if it is not present, but will not # otherwise be a problem. # This situation is only tripped when one of the first actions diff --git a/pywikibot/i18n.py b/pywikibot/i18n.py index 359fc96..33b6037 100644 --- a/pywikibot/i18n.py +++ b/pywikibot/i18n.py @@ -468,7 +468,7 @@ plural_entries = [] specific_entries = {} - # A plural entry can not start at the end of the variants list, + # A plural entry cannot start at the end of the variants list, # and must end with | or the end of the variants list. for number, plural in re.findall( r'(?!$)(?: *(\d+) *= *)?(.*?)(?:\||$)', variants @@ -823,7 +823,7 @@ @param twtitle: The TranslateWiki string title, in <package>-<key> format - @raises OSError: the package i18n can not be loaded + @raises OSError: the package i18n cannot be loaded """ # obtain the directory containing all the json files for this package package = twtitle.split('-')[0] diff --git a/pywikibot/logging.py b/pywikibot/logging.py index 457e276..0ac811e 100644 --- a/pywikibot/logging.py +++ b/pywikibot/logging.py @@ -166,7 +166,7 @@ def error(text, decoder=None, newline=True, **kwargs): """Output an error message to the user via the userinterface. - @param text: the message containing the error which occured. + @param text: the message containing the error which occurred. @param decoder: If None, text should be a unicode string else it should be encoded in the given encoding. @param newline: If True, a line feed will be added after printing the text. @@ -235,7 +235,7 @@ This function should only be called from an Exception handler. - @param msg: If not None,contains the description of the exception occured. + @param msg: If not None,contains the description of the exception occurred. @param decoder: If None, text should be a unicode string else it should be encoded in the given encoding. @param newline: If True, a line feed will be added after printing the text. diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index 8a2ed50..26e5000 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -884,7 +884,7 @@ return self.namespace() == 14 def is_filepage(self): - """Return True if this is an file description page, False otherwise.""" + """Return True if this is a file description page, False otherwise.""" return self.namespace() == 6 @remove_last_args(['get_Index']) diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py index 0703d88..3cb72bd 100644 --- a/pywikibot/proofreadpage.py +++ b/pywikibot/proofreadpage.py @@ -287,7 +287,7 @@ @index.setter def index(self, value): if not isinstance(value, IndexPage): - raise TypeError('value {} must be a IndexPage object.' + raise TypeError('value {} must be an IndexPage object.' .format(value)) self._index = (value, None) @@ -766,7 +766,7 @@ INDEX_TEMPLATE = ':MediaWiki:Proofreadpage_index_template' def __init__(self, source, title=''): - """Instantiate a IndexPage object. + """Instantiate an IndexPage object. In this class: page number is the number in the page title in the Page namespace, if diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py index 28e6d8e..9c84f38 100644 --- a/pywikibot/site/__init__.py +++ b/pywikibot/site/__init__.py @@ -3907,11 +3907,11 @@ if text_overrides: if 'text' in kwargs: - raise ValueError('text can not be used with any of %s' - % ', '.join(text_overrides)) + raise ValueError('text cannot be used with any of {}' + .format(', '.join(text_overrides))) if len(text_overrides) > 1: - raise ValueError('Multiple text overrides used: %s' - % ', '.join(text_overrides)) + raise ValueError('Multiple text overrides used: {}' + .format(', '.join(text_overrides))) text = None basetimestamp = False elif 'text' in kwargs: diff --git a/pywikibot/site/_interwikimap.py b/pywikibot/site/_interwikimap.py index 6352d26..2f18e54 100644 --- a/pywikibot/site/_interwikimap.py +++ b/pywikibot/site/_interwikimap.py @@ -49,7 +49,7 @@ @property def _iw_sites(self): """Fill the interwikimap cache with the basic entries.""" - # _iw_sites is a local cache to return a APISite instance depending + # _iw_sites is a local cache to return an APISite instance depending # on the interwiki prefix of that site if self._map is None: self._map = {iw['prefix']: _IWEntry('local' in iw, iw['url']) diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index 49e4451..9346cf7 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -839,7 +839,7 @@ already present in the local set. For large collections, this is not memory efficient, as a strong reference - to every item is kept in a local set which can not be cleared. + to every item is kept in a local set which cannot be cleared. Also, the local set can't be re-used when chaining unique operations on multiple generators. @@ -905,7 +905,7 @@ empty collections, so it can be iterated through it safely if treated as a list, tuple, set or dictionary. It is also basically an empty string. - Accessing a value via __getitem__ will result in an combined KeyError and + Accessing a value via __getitem__ will result in a combined KeyError and IndexError. """ diff --git a/pywikibot/tools/djvu.py b/pywikibot/tools/djvu.py index 73992b0..f0f425b 100644 --- a/pywikibot/tools/djvu.py +++ b/pywikibot/tools/djvu.py @@ -261,7 +261,7 @@ # Convert white_page to djvu. res, data = _call_cmd(['c44', white_ppm, '-dpi', dpi]) - os.unlink(white_ppm) # rm white_page.ppm before retuning. + os.unlink(white_ppm) # rm white_page.ppm before returning. if not res: return False diff --git a/pywikibot/version.py b/pywikibot/version.py index ce66b6f..878b4fb 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -141,7 +141,7 @@ def svn_rev_info(path): - """Fetch information about the current revision of an Subversion checkout. + """Fetch information about the current revision of a Subversion checkout. @param path: directory of the Subversion checkout @return: diff --git a/scripts/README.rst b/scripts/README.rst index 24e48af..e2feed6 100644 --- a/scripts/README.rst +++ b/scripts/README.rst @@ -283,7 +283,7 @@ +------------------------+---------------------------------------------------------+ | interwikidumps.py | Convert interwiki dumps from pickle to txt format. | +------------------------+---------------------------------------------------------+ - | make_i18n_dict.py | Generate a i18n file from a given script. | + | make_i18n_dict.py | Generate an i18n file from a given script. | +------------------------+---------------------------------------------------------+ | sorting_order.py | Updates interwiki sorting order in family.py file. | +------------------------+---------------------------------------------------------+ diff --git a/scripts/category.py b/scripts/category.py index 62ec36c..83a459e 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -201,30 +201,38 @@ if self.follow_redirects: if redir_target.exists(): return redir_target + if self.create: redir_target.text = '' pywikibot.output('Redirect target {} does not exist ' 'yet; creating.'.format( redir_target.title(as_link=True))) return redir_target + if self.edit_redirects: return page - pywikibot.warning('Redirect target {} can not ' - 'be modified; skipping.'.format( - redir_target.title(as_link=True))) + + pywikibot.warning( + 'Redirect target {} cannot be modified; skipping.' + .format(redir_target)) return None + if self.edit_redirects: return page + pywikibot.warning('Page {} is a redirect to {}; skipping.' .format(page.title(as_link=True), redir_target.title(as_link=True))) return None + return page + if self.create: page.text = '' pywikibot.output('Page {} does not exist yet; creating.' .format(page.title(as_link=True))) return page + pywikibot.warning('Page {} does not exist; skipping.' .format(page.title(as_link=True))) return None diff --git a/scripts/data_ingestion.py b/scripts/data_ingestion.py index 608aa2a..6fb37fd 100755 --- a/scripts/data_ingestion.py +++ b/scripts/data_ingestion.py @@ -155,7 +155,7 @@ def downloadPhoto(self): """ - Download the photo and store it in a io.BytesIO object. + Download the photo and store it in an io.BytesIO object. TODO: Add exception handling """ diff --git a/scripts/flickrripper.py b/scripts/flickrripper.py index 757cd48..0be7601 100755 --- a/scripts/flickrripper.py +++ b/scripts/flickrripper.py @@ -103,7 +103,7 @@ def downloadPhoto(photoUrl): """ - Download the photo and store it in a io.BytesIO object. + Download the photo and store it in an io.BytesIO object. TODO: Add exception handling diff --git a/scripts/imageuncat.py b/scripts/imageuncat.py index 0881784..66ccbd8 100755 --- a/scripts/imageuncat.py +++ b/scripts/imageuncat.py @@ -36,7 +36,7 @@ '[[Category:Media lacking a description]]', '[[Category:Self-published work]]'] -# Don't bother to put the template on a image with one of these templates +# Don't bother to put the template on an image with one of these templates skipTemplates = ['Delete', 'Nocat', 'No license', diff --git a/scripts/maintenance/make_i18n_dict.py b/scripts/maintenance/make_i18n_dict.py index 8d8cf42..284e82c 100755 --- a/scripts/maintenance/make_i18n_dict.py +++ b/scripts/maintenance/make_i18n_dict.py @@ -1,7 +1,7 @@ #!/usr/bin/python # -*- coding: utf-8 -*- """ -Generate a i18n file from a given script. +Generate an i18n file from a given script. run IDLE at topmost level: >>> import pwb diff --git a/scripts/noreferences.py b/scripts/noreferences.py index f3c3bd8..dd65741 100755 --- a/scripts/noreferences.py +++ b/scripts/noreferences.py @@ -582,7 +582,7 @@ # Set the edit summary for this case self.comment = i18n.twtranslate(self.site, 'noreferences-fix-tag') - # Repair two opening tags or a opening and an empty tag + # Repair two opening tags or an opening and an empty tag pattern = re.compile(r'< *references *>(.*?)' r'< */?\s*references */? *>', re.DOTALL) if pattern.search(oldText): diff --git a/scripts/replicate_wiki.py b/scripts/replicate_wiki.py index 1d42b26..683363d 100755 --- a/scripts/replicate_wiki.py +++ b/scripts/replicate_wiki.py @@ -11,7 +11,7 @@ python pwb.py replicate_wiki [-r] -ns 10 -family:wikipedia -lang:nl li fy -to copy all templates from an nlwiki to liwiki and fywiki. It will show which +to copy all templates from nlwiki to liwiki and fywiki. It will show which pages have to be changed if -r is not present, and will only actually write pages if -r /is/ present. diff --git a/tests/disambredir_tests.py b/tests/disambredir_tests.py index 1cf1e2e..1726b28 100644 --- a/tests/disambredir_tests.py +++ b/tests/disambredir_tests.py @@ -20,10 +20,10 @@ from tests.utils import fixed_generator -class TestDisambigurationRedirectBot(FakeSaveBotTestCase, TWNBotTestCase): +class TestDisambiguationRedirectBot(FakeSaveBotTestCase, TWNBotTestCase): """ - Test cases for DisambigurationRedirectBot. + Test cases for DisambiguationRedirectBot. It patches the bot instances in such a way that there is no user interaction required and it can be run autonomously. It also does not @@ -37,7 +37,7 @@ """ Patch _create_callback in the Bot instance. - It still creates a InteractiveReplace instance but returns another + It still creates an InteractiveReplace instance but returns another function which only calls 'handle_answer' from that InteractiveReplace instance if the link matches. """ @@ -62,7 +62,7 @@ @classmethod def setUpClass(cls): """Initialize page variable.""" - super(TestDisambigurationRedirectBot, cls).setUpClass() + super().setUpClass() # Patch the page to be independent of the actual site cls.page = pywikibot.Page(cls.site, 'User:BobBot/Test disambig') cls.page.linkedPages = fixed_generator( @@ -73,12 +73,12 @@ def bot_save(self, page, *args, **kwargs): """Check if the page matches.""" self.assertIs(page, self.page) - return super(TestDisambigurationRedirectBot, self).bot_save( + return super().bot_save( page, *args, **kwargs) def setUp(self): """Set up the test page.""" - super(TestDisambigurationRedirectBot, self).setUp() + super().setUp() self.page.text = ('[[User:BobBot/Redir#Foo|Bar]]\n' '[[User:BobBot/Redir|Baz]]\n' '[[User:BobBot/Redir2]]\n' diff --git a/tests/eventstreams_tests.py b/tests/eventstreams_tests.py index cce5f0d..d69225d 100644 --- a/tests/eventstreams_tests.py +++ b/tests/eventstreams_tests.py @@ -65,7 +65,7 @@ def setUp(self): """Setup tests.""" - super(TestEventStreamsStreamsTests, self).setUp() + super().setUp() site = self.get_site() fam = site.family if not isinstance(fam, WikimediaFamily): @@ -110,7 +110,7 @@ def setUp(self): """Set up unit test.""" - super(TestEventStreamsSettingTests, self).setUp() + super().setUp() with mock.patch('pywikibot.comms.eventstreams.EventSource'): self.es = EventStreams(url='dummy url') @@ -169,7 +169,7 @@ def setUp(self): """Set up unit test.""" - super(TestEventStreamsFilterTests, self).setUp() + super().setUp() with mock.patch('pywikibot.comms.eventstreams.EventSource'): self.es = EventStreams(url='dummy url') @@ -205,7 +205,7 @@ self.assertTrue(self.es.streamfilter(self.data)) def test_filter_value(self): - """Test EventStreams filter with assignment of a int value.""" + """Test EventStreams filter with assignment of an int value.""" self.es.register_filter(foo=10) self.assertFalse(self.es.streamfilter(self.data)) diff --git a/tests/tools_tests.py b/tests/tools_tests.py index 2fb4f0b..192b337 100644 --- a/tests/tools_tests.py +++ b/tests/tools_tests.py @@ -494,7 +494,7 @@ self._test_dedup_int(deduped, deduper) def test_OrderedDict(self): - """Test filter_unique with a OrderedDict.""" + """Test filter_unique with an OrderedDict.""" deduped = OrderedDict() deduper = tools.filter_unique(self.ints, container=deduped) self._test_dedup_int(deduped, deduper) diff --git a/tests/utils.py b/tests/utils.py index 67fa874..2bbd3aa 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -191,7 +191,7 @@ Context manager to assert certain APIError exceptions. This is build similar to the L{unittest.TestCase.assertError} - implementation which creates an context manager. It then calls L{handle} + implementation which creates a context manager. It then calls L{handle} which either returns this manager if no executing object given or calls the callable object. """ diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index 13a028c..181ad56 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -1167,7 +1167,7 @@ """Helper function to test a page without an associated item. It tests two of the ways to fetch an item: - 1. the Page already has props, which should contain a item id if + 1. the Page already has props, which should contain an item id if present, and that item id is used to instantiate the item, and 2. the page doesn't have props, in which case the site&titles is used to lookup the item id, but that lookup occurs after -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/645838 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ic9b43ffea454d5e6d1cea1a0fc1eb64f4cc97092 Gerrit-Change-Number: 645838 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 4 months

← Newer
1
...
4
5
6
7
8
9
10
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits December 2020