Pywikibot-commits December 2020

pywikibot-commits@lists.wikimedia.org

1 participants
103 discussions

[Gerrit] ...core[master]: [cleanup] deprecate sysop parameter with FutureWarning

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652585 ) Change subject: [cleanup] deprecate sysop parameter with FutureWarning ...................................................................... [cleanup] deprecate sysop parameter with FutureWarning Change-Id: Ie9a3f46cfab8cac4f84187df871c46e49d3484a6 --- M pywikibot/site/__init__.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py index 6dd0947..127e828 100644 --- a/pywikibot/site/__init__.py +++ b/pywikibot/site/__init__.py @@ -260,7 +260,7 @@ auth_token = get_authentication(self.base_url('')) return auth_token is not None and len(auth_token) == 4 - @deprecated_args(sysop=None) + @deprecated_args(sysop=True) def login(self, sysop=None, autocreate=False): """ Log the user in if not already logged in. @@ -273,6 +273,11 @@ by the site. @see: U{https://www.mediawiki.org/wiki/API:Login} """ + if sysop is not None: + issue_deprecation_warning("'sysop' parameter", + warning_class=FutureWarning, + since='20201230') + # TODO: this should include an assert that loginstatus # is not already IN_PROGRESS, however the # login status may be left 'IN_PROGRESS' because -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652585 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ie9a3f46cfab8cac4f84187df871c46e49d3484a6 Gerrit-Change-Number: 652585 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [bugfix] Re-enable reading user-config.py from site package

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652550 ) Change subject: [bugfix] Re-enable reading user-config.py from site package ...................................................................... [bugfix] Re-enable reading user-config.py from site package reading user-config.py was accidently disabled if pwikibot was installed as a site package. - always read user-config.py if the file exists Bug: T270941 Change-Id: If3dbea73c730d0f5871afc482be242c317e8d9cb --- M pywikibot/config2.py 1 file changed, 15 insertions(+), 20 deletions(-) Approvals: JJMC89: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 0f8395f..4c45f89 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -989,26 +989,21 @@ # we can detect modified config items easily. _exec_globals = copy.deepcopy(_public_globals) -# Get the user files -if __no_user_config: - if __no_user_config != '2': - warning('Skipping loading of user-config.py.') -else: - _filename = os.path.join(base_dir, 'user-config.py') - if os.path.exists(_filename): - _filestatus = os.stat(_filename) - _filemode = _filestatus[0] - _fileuid = _filestatus[4] - if OSWIN32 or _fileuid in [os.getuid(), 0]: - if OSWIN32 or _filemode & 0o02 == 0: - with open(_filename, 'rb') as f: - exec(compile(f.read(), _filename, 'exec'), _exec_globals) - else: - warning("Skipped '%(fn)s': writeable by others." - % {'fn': _filename}) - else: - warning("Skipped '%(fn)s': owned by someone else." - % {'fn': _filename}) +# Always try to get the user files +_filename = os.path.join(base_dir, 'user-config.py') +if os.path.exists(_filename): + _filestatus = os.stat(_filename) + _filemode = _filestatus[0] + _fileuid = _filestatus[4] + if not OSWIN32 and _fileuid not in [os.getuid(), 0]: + warning('Skipped {fn!r}: owned by someone else.'.format(fn=_filename)) + elif OSWIN32 or _filemode & 0o02 == 0: + with open(_filename, 'rb') as f: + exec(compile(f.read(), _filename, 'exec'), _exec_globals) + else: + warning('Skipped {fn!r}: writeable by others.'.format(fn=_filename)) +elif __no_user_config and __no_user_config != '2': + warning('user-config.py cannot be loaded.') class _DifferentTypeError(UserWarning, TypeError): -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652550 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If3dbea73c730d0f5871afc482be242c317e8d9cb Gerrit-Change-Number: 652550 Gerrit-PatchSet: 4 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [tests] Update min-version for flake8-future-import

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652567 ) Change subject: [tests] Update min-version for flake8-future-import ...................................................................... [tests] Update min-version for flake8-future-import Change-Id: Ib791e6a9ff5b2867bb6f1efacfc6134054291e95 --- M tox.ini 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tox.ini b/tox.ini index 20aec2a..8352fab 100644 --- a/tox.ini +++ b/tox.ini @@ -99,8 +99,6 @@ ignore = C103,D105,D211,D401,D413,D412,FI1,H101,H238,H301,H404,H405,H903,P101,P102,P103,P205,W503 enable-extensions = H203,H204,H205 exclude = .tox,.git,./*.egg,build,scripts/archive/*,./scripts/i18n/* -min-version = 2.7 -require-code = true classmethod-decorators = classmethod,classproperty # flake8-coding @@ -111,6 +109,10 @@ color = always format = ${blue}%(path)s${reset}: ${bold}line %(row)d:${reset}%(col)d: ${red_bold}%(code)s${reset} %(text)s +# flake8-future-import +min-version = 3.5 +require-code = true + # The following are to be fixed # N802: function name should be lowercase # N803: argument name should be lowercase -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652567 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib791e6a9ff5b2867bb6f1efacfc6134054291e95 Gerrit-Change-Number: 652567 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [cleanup] Remove magic coding: comment

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652565 ) Change subject: [cleanup] Remove magic coding: comment ...................................................................... [cleanup] Remove magic coding: comment magic coding comment like is for Python 2 whereas Python 3 uses utf-8 by default Disallow magic coding comment but ignore warnings until all scripts are cleaned. Change-Id: If092e092b56ae7a43b3be797b969f3ea4420f709 --- M docs/conf.py M tox.ini 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/docs/conf.py b/docs/conf.py index fed05e1..99c01f7 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -1,4 +1,3 @@ -# -*- coding: utf-8 -*- """Configuration file for Sphinx.""" # # (C) Pywikibot team, 2014-2020 diff --git a/tox.ini b/tox.ini index 908ddb8..20aec2a 100644 --- a/tox.ini +++ b/tox.ini @@ -96,15 +96,18 @@ # D412: No blank lines allowed between a section header and its content # D413: Missing blank line after last section -ignore = D105,D211,D401,D413,D412,FI1,H101,H238,H301,H404,H405,H903,P101,P102,P103,P205,W503 +ignore = C103,D105,D211,D401,D413,D412,FI1,H101,H238,H301,H404,H405,H903,P101,P102,P103,P205,W503 enable-extensions = H203,H204,H205 exclude = .tox,.git,./*.egg,build,scripts/archive/*,./scripts/i18n/* min-version = 2.7 -accept-encodings = utf-8 require-code = true classmethod-decorators = classmethod,classproperty -# flake8-color format string +# flake8-coding +# note: C103 can be removed from ignore if scripts are cleaned from coding part +no-accept-encodings = true + +# flake8-color color = always format = ${blue}%(path)s${reset}: ${bold}line %(row)d:${reset}%(col)d: ${red_bold}%(code)s${reset} %(text)s -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652565 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If092e092b56ae7a43b3be797b969f3ea4420f709 Gerrit-Change-Number: 652565 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [tests] set flake8-colors color option to 'always'

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652552 ) Change subject: [tests] set flake8-colors color option to 'always' ...................................................................... [tests] set flake8-colors color option to 'always' flake8-colors 0.1.7 introduced a new behaviour and disabled colors except color formatting is invoked interactively. With 0.1.9 a new parameter 'color' was introduced which can be set Bug: T270938 Change-Id: If6c420fa3e9c555b3cd6745fb9420bbba0be29c9 --- M setup.py M tox.ini 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/setup.py b/setup.py index 76cd8ba..00ec8d2 100644 --- a/setup.py +++ b/setup.py @@ -75,7 +75,7 @@ 'pydocstyle>=4.0.0', 'hacking', 'flake8-coding', - 'flake8-colors', + 'flake8-colors>=0.1.9', 'flake8-comprehensions>=3.1.4;python_version>="3.8"', 'flake8-comprehensions>=2.2.0', 'flake8-docstrings>=1.3.1', diff --git a/tox.ini b/tox.ini index 07db505..908ddb8 100644 --- a/tox.ini +++ b/tox.ini @@ -103,7 +103,9 @@ accept-encodings = utf-8 require-code = true classmethod-decorators = classmethod,classproperty + # flake8-color format string +color = always format = ${blue}%(path)s${reset}: ${bold}line %(row)d:${reset}%(col)d: ${red_bold}%(code)s${reset} %(text)s # The following are to be fixed -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/652552 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If6c420fa3e9c555b3cd6745fb9420bbba0be29c9 Gerrit-Change-Number: 652552 Gerrit-PatchSet: 11 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [IMPR] rename login.getCookie() to login.login_to_site()

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651994 ) Change subject: [IMPR] rename login.getCookie() to login.login_to_site() ...................................................................... [IMPR] rename login.getCookie() to login.login_to_site() Do not overwrite login.storecookiedata() in api.py, instead port the implementation in api.py to login.py. Remove unused method parameters. Change-Id: I10a6c2fe787d3a4c344b364a1b3c3f6564ff7306 --- M pywikibot/data/api.py M pywikibot/login.py 2 files changed, 16 insertions(+), 22 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index 9d644c2..cc29542 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -43,7 +43,6 @@ issue_deprecation_warning, itergroup, PYTHON_VERSION, - remove_last_args, ) from pywikibot.tools.formatter import color_format @@ -2954,8 +2953,7 @@ """Get API keyword from mapping.""" return self.mapping[key][self.action != 'login'] - @remove_last_args(arg_names=['remember, captchaId, captchaAnswer']) - def getCookie(self) -> str: + def login_to_site(self): """Login to the site. Note, this doesn't actually return or do anything with cookies. @@ -3027,7 +3025,7 @@ status = response[result_key] fail_reason = response.get(self.keyword('reason'), '') if status == self.keyword('success'): - return '' + return None if status in ('NeedToken', 'WrongToken', 'badtoken'): token = response.get('token') @@ -3067,10 +3065,6 @@ info = fail_reason raise APIError(code=status, info=info) - def storecookiedata(self, data): - """Ignore data; cookies are set by http module.""" - http.cookie_jar.save(ignore_discard=True) - def get_login_token(self) -> str: """Fetch login token from action=query&meta=tokens. diff --git a/pywikibot/login.py b/pywikibot/login.py index c923969..0a411e0 100644 --- a/pywikibot/login.py +++ b/pywikibot/login.py @@ -17,8 +17,10 @@ import pywikibot from pywikibot import config, __url__ +from pywikibot.comms import http from pywikibot.exceptions import NoUsername from pywikibot.tools import ( + deprecated, deprecated_args, file_mode_checker, normalize_username, remove_last_args, ) @@ -185,6 +187,7 @@ # No bot policies on other sites return True + @deprecated('login_to_site', since='20201227', future_warning=True) @remove_last_args(['remember', 'captcha']) def getCookie(self): """ @@ -194,20 +197,17 @@ @return: cookie data if successful, None otherwise. """ - # THIS IS OVERRIDDEN IN data/api.py - return None + self.login_to_site() - def storecookiedata(self, data: str) -> None: - """ - Store cookie data. - - @param data: The raw data as returned by getCookie() - """ + def login_to_site(self): + """Login to the site.""" # THIS IS OVERRIDDEN IN data/api.py - filename = config.datafilepath('pywikibot.lwp') - pywikibot.debug('Storing cookies to {}'.format(filename), _logger) - with open(filename, 'w') as f: - f.write(data) + raise NotImplementedError + + @remove_last_args(['data']) + def storecookiedata(self) -> None: + """Store cookie data.""" + http.cookie_jar.save(ignore_discard=True) def readPassword(self): """ @@ -323,7 +323,7 @@ pywikibot.output('Logging in to {site} as {name}' .format(name=self.login_name, site=self.site)) try: - cookiedata = self.getCookie() + self.login_to_site() except pywikibot.data.api.APIError as e: error_code = e.code pywikibot.error('Login failed ({}).'.format(error_code)) @@ -340,7 +340,7 @@ return self.login(retry=True) else: return False - self.storecookiedata(cookiedata) + self.storecookiedata() pywikibot.log('Should be logged in now') return True -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651994 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I10a6c2fe787d3a4c344b364a1b3c3f6564ff7306 Gerrit-Change-Number: 651994 Gerrit-PatchSet: 2 Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [cleanup] Remove PY2 variable

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651909 ) Change subject: [cleanup] Remove PY2 variable ...................................................................... [cleanup] Remove PY2 variable After Python 2 has been dropped the PY2 variable is no longer needed. Show a FutureWarning if it is imported. Change-Id: I25741ae208f8f29aa760f6d4b5ae021dc293f077 --- M pywikibot/tools/__init__.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py index 9346cf7..16233cb 100644 --- a/pywikibot/tools/__init__.py +++ b/pywikibot/tools/__init__.py @@ -35,9 +35,6 @@ from pywikibot.logging import debug from pywikibot.tools._unidata import _first_upper_exception -PYTHON_VERSION = sys.version_info[:3] -PY2 = (PYTHON_VERSION[0] == 2) - try: import bz2 except ImportError as bz2_import_error: @@ -54,6 +51,8 @@ lzma = lzma_import_error +PYTHON_VERSION = sys.version_info[:3] + _logger = 'tools' @@ -1824,7 +1823,15 @@ return '{} ({}):'.format(message, option_msg) +def _py2(): + """Function for deprecated PY2 variable used by wrapper below.""" + return (PYTHON_VERSION[0] == 2) + + wrapper = ModuleDeprecationWrapper(__name__) wrapper._add_deprecated_attr('FrozenDict', _FrozenDict, replacement_name='tools.frozenmap', since='20201109', future_warning=True) +wrapper._add_deprecated_attr('PY2', _py2(), + replacement_name='sys.version_info[0] == 2', + since='20201224', future_warning=True) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651909 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I25741ae208f8f29aa760f6d4b5ae021dc293f077 Gerrit-Change-Number: 651909 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-CC: DannyS712 <DannyS712.enwiki(a)gmail.com> Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [doc] Announce support of MediaWiki < 1.23 is to be dropped

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/644188 ) Change subject: [doc] Announce support of MediaWiki < 1.23 is to be dropped ...................................................................... [doc] Announce support of MediaWiki < 1.23 is to be dropped Bug: T268979 Change-Id: I019ff7c3d5fa3a5a1285ea19a6aaf3164e0e6cfb --- M pywikibot/site/__init__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py index 28e6d8e..1a73ac8 100644 --- a/pywikibot/site/__init__.py +++ b/pywikibot/site/__init__.py @@ -1470,6 +1470,14 @@ pywikibot.error(msg) raise + if MediaWikiVersion(version) < '1.23': + warn('\n' + + fill('Support of MediaWiki {version} will be dropped. ' + 'It is recommended to use MediaWiki 1.23 or above. ' + 'You may use every Pywikibot 5.X for older MediaWiki ' + 'versions. See T268979 for further information.' + .format(version=version)), FutureWarning) + if MediaWikiVersion(version) < '1.19': raise RuntimeError( 'Pywikibot "{}" does not support MediaWiki "{}".\n' -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/644188 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I019ff7c3d5fa3a5a1285ea19a6aaf3164e0e6cfb Gerrit-Change-Number: 644188 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [cleanup] remove desupported ReplaceRobot.doReplacements method

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651563 ) Change subject: [cleanup] remove desupported ReplaceRobot.doReplacements method ...................................................................... [cleanup] remove desupported ReplaceRobot.doReplacements method Change-Id: I88af611511e26a3821b848efbd8af2919247bd26 --- M scripts/replace.py M tests/replacebot_tests.py 2 files changed, 1 insertion(+), 17 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/replace.py b/scripts/replace.py index 97e2f57..c5f2256 100755 --- a/scripts/replace.py +++ b/scripts/replace.py @@ -142,7 +142,6 @@ # import codecs import re -import warnings from collections.abc import Sequence from contextlib import suppress @@ -154,7 +153,7 @@ from pywikibot import fixes from pywikibot import i18n, textlib, pagegenerators from pywikibot.bot import ExistingPageBot, SingleSiteBot -from pywikibot.tools import chars, deprecated, deprecated_args +from pywikibot.tools import chars, deprecated_args # This is required for the text that is shown when you run this script @@ -621,18 +620,6 @@ return new_text - @deprecated('apply_replacements', since='20160816', future_warning=True) - def doReplacements(self, original_text, page=None): - """Apply replacements to the given text and page.""" - if page is None: - pywikibot.warn( - 'You must pass the target page as the "page" parameter to ' - 'doReplacements().', DeprecationWarning, stacklevel=2) - with warnings.catch_warnings(): - warnings.simplefilter('ignore', DeprecationWarning) - new_text = self.apply_replacements(original_text, set(), page=page) - return new_text - def _replace_async_callback(self, page, err): """Log changed titles for display.""" # This is an async put callback diff --git a/tests/replacebot_tests.py b/tests/replacebot_tests.py index d24e0b3..0d5fe82 100644 --- a/tests/replacebot_tests.py +++ b/tests/replacebot_tests.py @@ -10,7 +10,6 @@ import pywikibot from pywikibot import fixes -from pywikibot.tools import suppress_warnings from scripts import replace @@ -162,8 +161,6 @@ self.assertEqual(expected, bot.apply_replacements('Hello 1', applied, page)) self.assertEqual(applied, required_applied) - with suppress_warnings('scripts.replace.ReplaceRobot.doReplacements'): - self.assertEqual(expected, bot.doReplacements('Hello 1', page)) def test_only_cmd(self): """Test command line replacements only.""" -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651563 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I88af611511e26a3821b848efbd8af2919247bd26 Gerrit-Change-Number: 651563 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

[Gerrit] ...core[master]: [IMPR] Add backports to support older Python versions

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651017 ) Change subject: [IMPR] Add backports to support older Python versions ...................................................................... [IMPR] Add backports to support older Python versions - add typing backports - add functools.cache backport - add removeprefix and removesuffix functions backports Import backports in several scripts Change-Id: I366e5c7233ed927d17e7bf8127a6fd7920d7f11d --- M docs/api_ref/pywikibot.rst M pywikibot/CONTENT.rst M pywikibot/__init__.py A pywikibot/backports.py M pywikibot/bot.py M pywikibot/comms/http.py M pywikibot/comms/threadedhttp.py M pywikibot/config2.py M pywikibot/data/api.py M pywikibot/date.py M pywikibot/family.py M pywikibot/i18n.py M pywikibot/logentries.py M pywikibot/page/__init__.py M pywikibot/pagegenerators.py M pywikibot/site/__init__.py M pywikibot/site/_namespace.py M pywikibot/specialbots/_upload.py M pywikibot/textlib.py M pywikibot/userinterfaces/gui.py M scripts/add_text.py M scripts/archivebot.py M scripts/basic.py M scripts/capitalize_redirects.py M scripts/catall.py M scripts/category.py M scripts/category_redirect.py M scripts/checkimages.py M scripts/clean_sandbox.py M scripts/commons_link.py M scripts/coordinate_import.py M scripts/cosmetic_changes.py M scripts/create_categories.py M scripts/data_ingestion.py M scripts/delete.py M scripts/djvutext.py M scripts/download_dump.py M scripts/editarticle.py M scripts/harvest_template.py M scripts/interwikidata.py M scripts/login.py M scripts/newitem.py M scripts/pagefromfile.py M scripts/redirect.py M scripts/solve_disambiguation.py M scripts/templatecount.py M scripts/weblinkchecker.py M scripts/welcome.py M tox.ini 49 files changed, 155 insertions(+), 305 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/docs/api_ref/pywikibot.rst b/docs/api_ref/pywikibot.rst index aaaf2f3..05b3f0b 100644 --- a/docs/api_ref/pywikibot.rst +++ b/docs/api_ref/pywikibot.rst @@ -20,6 +20,11 @@ Submodules ---------- +pywikibot.backports module +-------------------------- + +.. automodule:: pywikibot.backports + pywikibot.bot module -------------------- diff --git a/pywikibot/CONTENT.rst b/pywikibot/CONTENT.rst index 6df54ca..17f6e73 100644 --- a/pywikibot/CONTENT.rst +++ b/pywikibot/CONTENT.rst @@ -11,6 +11,8 @@ +----------------------------+------------------------------------------------------+ | _wbtypes.py | Wikibase data type classes | +----------------------------+------------------------------------------------------+ + | backports.py | Backports to support older Python versions | + +----------------------------+------------------------------------------------------+ | bot.py | User-interface related functions for building bots | +----------------------------+------------------------------------------------------+ | bot_choice.py | Classes for input_choice | diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py index 25a7100..b2dc8ff 100644 --- a/pywikibot/__init__.py +++ b/pywikibot/__init__.py @@ -23,6 +23,7 @@ __maintainer__, __maintainer_email__, __name__, __url__, __version__) from pywikibot._wbtypes import WbRepresentation as _WbRepresentation +from pywikibot.backports import cache from pywikibot.bot import ( input, input_choice, input_yn, handle_args, show_help, ui, calledModuleName, Bot, CurrentPageBot, WikidataBot, @@ -59,17 +60,10 @@ normalize_username, MediaWikiVersion as _MediaWikiVersion, ModuleDeprecationWrapper as _ModuleDeprecationWrapper, - PYTHON_VERSION, redirect_func, ) from pywikibot.tools.formatter import color_format -if PYTHON_VERSION >= (3, 9, 0): - from functools import cache -else: - from functools import lru_cache - cache = lru_cache(None) - __all__ = ( '__copyright__', '__description__', '__download_url__', '__license__', diff --git a/pywikibot/backports.py b/pywikibot/backports.py new file mode 100644 index 0000000..433a685 --- /dev/null +++ b/pywikibot/backports.py @@ -0,0 +1,52 @@ +# -*- coding: utf-8 -*- +"""This module contains backports to support older Python versions.""" +# +# (C) Pywikibot team, 2020 +# +# Distributed under the terms of the MIT license. +# +from pywikibot.tools import PYTHON_VERSION + +# functools.cache +if PYTHON_VERSION >= (3, 9): + from functools import cache +else: + from functools import lru_cache as _lru_cache + cache = _lru_cache(None) + + +# typing +if PYTHON_VERSION < (3, 5, 2): + from typing import Dict as DefaultDict +elif PYTHON_VERSION < (3, 9): + from typing import DefaultDict +else: + from collections import defaultdict as DefaultDict # noqa: N812 + +if PYTHON_VERSION >= (3, 9): + from collections.abc import Iterable + Dict = dict + FrozenSet = frozenset + List = list + Set = set + Tuple = tuple +else: + from typing import Dict, FrozenSet, Iterable, List, Set, Tuple + + +# PEP 616 string methods +if PYTHON_VERSION >= (3, 9): + removeprefix = str.removeprefix + removesuffix = str.removesuffix +else: + def removeprefix(string: str, prefix: str) -> str: + """Remove prefix from a string or return a copy otherwise.""" + if string.startswith(prefix): + return string[len(prefix):] + return string[:] + + def removesuffix(string: str, suffix: str) -> str: + """Remove prefix from a string or return a copy otherwise.""" + if string.endswith(suffix): + return string[:-len(suffix)] + return string[:] diff --git a/pywikibot/bot.py b/pywikibot/bot.py index 8920d7a..7a6942e 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -103,6 +103,7 @@ from warnings import warn import pywikibot +from pywikibot.backports import Dict, Iterable, List from pywikibot import config2 as config from pywikibot import daemonize from pywikibot import i18n @@ -128,12 +129,6 @@ from pywikibot.tools._logging import LoggingFormatter, RotatingFileHandler from pywikibot.tools.formatter import color_format -if PYTHON_VERSION >= (3, 9): - from collections.abc import Iterable - Dict = dict - List = list -else: - from typing import Dict, Iterable, List # Note: all output goes through python std library "logging" module _logger = 'bot' diff --git a/pywikibot/comms/http.py b/pywikibot/comms/http.py index d526e34..a656bc5 100644 --- a/pywikibot/comms/http.py +++ b/pywikibot/comms/http.py @@ -29,6 +29,8 @@ import requests import pywikibot + +from pywikibot.backports import Tuple from pywikibot.comms import threadedhttp from pywikibot import config2 as config from pywikibot.exceptions import ( @@ -40,14 +42,8 @@ deprecated_args, issue_deprecation_warning, file_mode_checker, - PYTHON_VERSION, ) -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple - try: import requests_oauthlib except ImportError as e: diff --git a/pywikibot/comms/threadedhttp.py b/pywikibot/comms/threadedhttp.py index 1836e7b..9882c1d 100644 --- a/pywikibot/comms/threadedhttp.py +++ b/pywikibot/comms/threadedhttp.py @@ -12,17 +12,14 @@ from urllib.parse import urlparse import pywikibot + +from pywikibot.backports import Dict from pywikibot.tools import ( deprecated, deprecated_args, issue_deprecation_warning, - PYTHON_VERSION, ) -if PYTHON_VERSION >= (3, 9): - Dict = dict -else: - from typing import Dict _logger = 'comms.threadedhttp' diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 5240a3b..0f8395f 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -54,15 +54,10 @@ from warnings import warn from pywikibot.__metadata__ import __version__ as pwb_version +from pywikibot.backports import Dict, List, Tuple from pywikibot.logging import error, output, warning -from pywikibot.tools import issue_deprecation_warning, PYTHON_VERSION +from pywikibot.tools import issue_deprecation_warning -if PYTHON_VERSION >= (3, 9): - Dict = dict - List = list - Tuple = tuple -else: - from typing import Dict, List, Tuple OSWIN32 = (sys.platform == 'win32') diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py index 1abfcc9..9d644c2 100644 --- a/pywikibot/data/api.py +++ b/pywikibot/data/api.py @@ -30,6 +30,7 @@ from pywikibot import config, login +from pywikibot.backports import FrozenSet, Set, Tuple from pywikibot.comms import http from pywikibot.exceptions import ( Server504Error, Server414Error, FatalServerError, NoUsername, @@ -38,18 +39,14 @@ from pywikibot.family import SubdomainFamily from pywikibot.login import LoginStatus from pywikibot.tools import ( - deprecated, issue_deprecation_warning, itergroup, PYTHON_VERSION, + deprecated, + issue_deprecation_warning, + itergroup, + PYTHON_VERSION, remove_last_args, ) from pywikibot.tools.formatter import color_format -if PYTHON_VERSION >= (3, 9): - Set = set - Tuple = tuple - FrozenSet = frozenset -else: - from typing import Set, Tuple, FrozenSet - _logger = 'data.api' diff --git a/pywikibot/date.py b/pywikibot/date.py index 9419768..713af67 100644 --- a/pywikibot/date.py +++ b/pywikibot/date.py @@ -15,19 +15,10 @@ from functools import singledispatch from string import digits as _decimalDigits # noqa: N812 +from pywikibot.backports import Tuple from pywikibot import Site from pywikibot.textlib import NON_LATIN_DIGITS -from pywikibot.tools import ( - deprecated, - first_lower, - first_upper, - PYTHON_VERSION, -) - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple +from pywikibot.tools import deprecated, first_lower, first_upper # # Different collections of well known formats diff --git a/pywikibot/family.py b/pywikibot/family.py index 676871e..e13d49a 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -19,19 +19,19 @@ from typing import Optional import pywikibot + +from pywikibot.backports import Dict, List, Tuple from pywikibot import config from pywikibot.exceptions import UnknownFamily, FamilyMaintenanceWarning from pywikibot.tools import ( - classproperty, deprecated, deprecated_args, frozenmap, - issue_deprecation_warning, ModuleDeprecationWrapper, PYTHON_VERSION, + classproperty, + deprecated, + deprecated_args, + frozenmap, + issue_deprecation_warning, + ModuleDeprecationWrapper, ) -if PYTHON_VERSION >= (3, 9): - Dict = dict - List = list - Tuple = tuple -else: - from typing import Dict, List, Tuple logger = logging.getLogger('pywiki.wiki.family') diff --git a/pywikibot/i18n.py b/pywikibot/i18n.py index 33b6037..b10aceb 100644 --- a/pywikibot/i18n.py +++ b/pywikibot/i18n.py @@ -35,19 +35,13 @@ import pywikibot from pywikibot import __url__ +from pywikibot.backports import cache, List from pywikibot import config2 as config from pywikibot.exceptions import Error from pywikibot.plural import plural_rule from pywikibot.tools import ( - deprecated, deprecated_args, issue_deprecation_warning, PYTHON_VERSION) + deprecated, deprecated_args, issue_deprecation_warning) -if PYTHON_VERSION >= (3, 9, 0): - from functools import cache - List = list -else: - from functools import lru_cache - from typing import List - cache = lru_cache(None) PLURAL_PATTERN = r'{{PLURAL:(?:%$)?([^$]*?)(?:\)d)?\|(.*?)}}' diff --git a/pywikibot/logentries.py b/pywikibot/logentries.py index 8f9f3f1..167075d 100644 --- a/pywikibot/logentries.py +++ b/pywikibot/logentries.py @@ -9,13 +9,11 @@ from typing import Optional import pywikibot -from pywikibot.exceptions import Error, HiddenKeyError -from pywikibot.tools import classproperty, deprecated, PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List +from pywikibot.backports import List +from pywikibot.exceptions import Error, HiddenKeyError +from pywikibot.tools import classproperty, deprecated + _logger = 'wiki' diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index cc41edc..2b85139 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -31,6 +31,8 @@ from warnings import warn import pywikibot + +from pywikibot.backports import cache, Dict, List from pywikibot import config, i18n, textlib from pywikibot.comms import http from pywikibot.data.api import APIError @@ -55,21 +57,11 @@ first_upper, issue_deprecation_warning, manage_wrapping, - PYTHON_VERSION, redirect_func, remove_last_args, ) from pywikibot.tools import is_IP -if PYTHON_VERSION >= (3, 9): - from functools import cache - Dict = dict - List = list -else: - from functools import lru_cache - from typing import Dict, List - cache = lru_cache(None) - PROTOCOL_REGEX = r'\Ahttps?://' diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index 9c3b365..cb20ea6 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -36,6 +36,13 @@ import pywikibot +from pywikibot import date, config, i18n, xmlreader +from pywikibot.backports import List +from pywikibot.bot import ShowingListOption +from pywikibot.comms import http +from pywikibot.data import api +from pywikibot.exceptions import ServerError, UnknownExtension +from pywikibot.proofreadpage import ProofreadPage from pywikibot.tools import ( deprecated, deprecated_args, @@ -47,18 +54,6 @@ redirect_func, ) -from pywikibot import date, config, i18n, xmlreader -from pywikibot.bot import ShowingListOption -from pywikibot.comms import http -from pywikibot.data import api -from pywikibot.exceptions import ServerError, UnknownExtension -from pywikibot.proofreadpage import ProofreadPage -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List _logger = 'pagegenerators' diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py index 5ea559b..4aaec96 100644 --- a/pywikibot/site/__init__.py +++ b/pywikibot/site/__init__.py @@ -34,6 +34,7 @@ import pywikibot import pywikibot.family +from pywikibot.backports import List from pywikibot.comms.http import get_authentication from pywikibot.data import api from pywikibot.echo import Notification @@ -80,14 +81,9 @@ itergroup, MediaWikiVersion, merge_unique_dicts, - PYTHON_VERSION, remove_last_args, ) -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List __all__ = ('APISite', 'DataSite', 'Namespace', 'NamespacesDict', 'PageInUse', 'RemovedSite', 'Siteinfo', 'TokenWallet') diff --git a/pywikibot/site/_namespace.py b/pywikibot/site/_namespace.py index 51fc7c2..ec95ca5 100644 --- a/pywikibot/site/_namespace.py +++ b/pywikibot/site/_namespace.py @@ -8,19 +8,14 @@ from collections.abc import Iterable, Mapping from typing import Optional, Union +from pywikibot.backports import List from pywikibot.tools import ( ComparableMixin, deprecated_args, issue_deprecation_warning, - PYTHON_VERSION, SelfCallMixin, ) -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List - class Namespace(Iterable, ComparableMixin): diff --git a/pywikibot/specialbots/_upload.py b/pywikibot/specialbots/_upload.py index 864339d..5161adb 100644 --- a/pywikibot/specialbots/_upload.py +++ b/pywikibot/specialbots/_upload.py @@ -22,19 +22,14 @@ import pywikibot.comms.http as http import pywikibot.data.api - +from pywikibot.backports import List from pywikibot import config from pywikibot.bot import BaseBot, QuitKeyboardInterrupt from pywikibot.data.api import APIError from pywikibot.exceptions import FatalServerError -from pywikibot.tools import deprecated_args, PYTHON_VERSION +from pywikibot.tools import deprecated_args from pywikibot.tools.formatter import color_format -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List - class UploadRobot(BaseBot): diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 592a93c..6129681 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -21,21 +21,16 @@ from typing import NamedTuple, Optional, Union import pywikibot + +from pywikibot.backports import List, Tuple from pywikibot.exceptions import InvalidTitle, SiteDefinitionError from pywikibot.family import Family from pywikibot.tools import ( deprecate_arg, deprecated, issue_deprecation_warning, - PYTHON_VERSION, ) -if PYTHON_VERSION >= (3, 9): - List = list - Tuple = tuple -else: - from typing import List, Tuple - try: import mwparserfromhell except ImportError as e: diff --git a/pywikibot/userinterfaces/gui.py b/pywikibot/userinterfaces/gui.py index a32fa11..41b57c4 100644 --- a/pywikibot/userinterfaces/gui.py +++ b/pywikibot/userinterfaces/gui.py @@ -15,7 +15,9 @@ from typing import Optional import pywikibot + from pywikibot import __url__ +from pywikibot.backports import Tuple from pywikibot.tools import PYTHON_VERSION @@ -34,11 +36,6 @@ from idlelib.configHandler import idleConf from idlelib.MultiCall import MultiCallCreator -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple - class TextEditor(ScrolledText): diff --git a/scripts/add_text.py b/scripts/add_text.py index f693faa..2296a85 100755 --- a/scripts/add_text.py +++ b/scripts/add_text.py @@ -66,15 +66,11 @@ import pywikibot +from pywikibot.backports import Tuple from pywikibot import config, i18n, pagegenerators, textlib from pywikibot.bot_choice import QuitKeyboardInterrupt from pywikibot.tools.formatter import color_format -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple docuReplacements = {'&params;': pagegenerators.parameterHelp} # noqa: N816 diff --git a/scripts/archivebot.py b/scripts/archivebot.py index bb9783b..6c38f88 100755 --- a/scripts/archivebot.py +++ b/scripts/archivebot.py @@ -107,20 +107,15 @@ import pywikibot +from pywikibot.backports import List, Set, Tuple from pywikibot.date import apply_month_delta from pywikibot import i18n from pywikibot.textlib import (extract_sections, findmarker, TimeStripper, to_local_digits) from pywikibot.tools import ( - deprecated, frozenmap, issue_deprecation_warning, PYTHON_VERSION, + deprecated, frozenmap, issue_deprecation_warning, ) -if PYTHON_VERSION >= (3, 9): - List = list - Set = set - Tuple = tuple -else: - from typing import List, Set, Tuple ShouldArchive = Tuple[str, str] Size = Tuple[int, str] diff --git a/scripts/basic.py b/scripts/basic.py index 3549691..4645978 100755 --- a/scripts/basic.py +++ b/scripts/basic.py @@ -48,17 +48,14 @@ # Distributed under the terms of the MIT license. # import pywikibot + +from pywikibot.backports import Tuple from pywikibot import pagegenerators from pywikibot.bot import ( SingleSiteBot, ConfigParserBot, ExistingPageBot, NoRedirectPageBot, AutomaticTWSummaryBot) -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple # This is required for the text that is shown when you run this script # with the parameter -help. diff --git a/scripts/capitalize_redirects.py b/scripts/capitalize_redirects.py index a38f753..deb8eb9 100755 --- a/scripts/capitalize_redirects.py +++ b/scripts/capitalize_redirects.py @@ -31,16 +31,13 @@ # Automatically converted from compat branch by compat2core.py script # import pywikibot + from pywikibot import i18n, pagegenerators +from pywikibot.backports import Tuple from pywikibot.bot import ( MultipleSitesBot, FollowRedirectPageBot, ExistingPageBot ) -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple docuReplacements = {'&params;': pagegenerators.parameterHelp} # noqa: N816 diff --git a/scripts/catall.py b/scripts/catall.py index 9fa5ced..c466e84 100755 --- a/scripts/catall.py +++ b/scripts/catall.py @@ -21,20 +21,15 @@ -onlynew : Only run on pages that do not yet have a category. """ # -# (C) Pywikibot team, 2004-2019 +# (C) Pywikibot team, 2004-2020 # # Distributed under the terms of the MIT license. # import pywikibot -from pywikibot import i18n, textlib -from pywikibot.bot import QuitKeyboardInterrupt -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Tuple = tuple - List = list -else: - from typing import List, Tuple +from pywikibot import i18n, textlib +from pywikibot.backports import List, Tuple +from pywikibot.bot import QuitKeyboardInterrupt def choosecats(pagetext: str) -> List[str]: diff --git a/scripts/category.py b/scripts/category.py index 83a459e..418a4ff 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -130,8 +130,8 @@ import pywikibot -from pywikibot import config, pagegenerators -from pywikibot import i18n, textlib +from pywikibot import config, i18n, pagegenerators, textlib +from pywikibot.backports import Set, Tuple from pywikibot.bot import ( BaseBot, Bot, @@ -142,14 +142,9 @@ suggest_help, ) from pywikibot.cosmetic_changes import moved_links -from pywikibot.tools import deprecated_args, open_archive, PYTHON_VERSION +from pywikibot.tools import deprecated_args, open_archive from pywikibot.tools.formatter import color_format -if PYTHON_VERSION >= (3, 9): - Set = set - Tuple = tuple -else: - from typing import Set, Tuple # This is required for the text that is shown when you run this script # with the parameter -help. diff --git a/scripts/category_redirect.py b/scripts/category_redirect.py index 42afd58..98fd0c6 100755 --- a/scripts/category_redirect.py +++ b/scripts/category_redirect.py @@ -38,14 +38,9 @@ import pywikibot -from pywikibot import i18n, pagegenerators, config +from pywikibot import config, i18n, pagegenerators +from pywikibot.backports import Tuple from pywikibot.bot import SingleSiteBot -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple class CategoryRedirectBot(SingleSiteBot): diff --git a/scripts/checkimages.py b/scripts/checkimages.py index 3f6148b..3aa2799 100755 --- a/scripts/checkimages.py +++ b/scripts/checkimages.py @@ -90,6 +90,7 @@ import pywikibot +from pywikibot.backports import List, Tuple from pywikibot.bot import suggest_help from pywikibot import config2 as config from pywikibot.exceptions import NotEmailableError @@ -97,13 +98,7 @@ from pywikibot import i18n from pywikibot import pagegenerators as pg from pywikibot.site import Namespace -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - List = list - Tuple = tuple -else: - from typing import List, Tuple ############################################################################### # <--------------------------- Change only below! ---------------------------># diff --git a/scripts/clean_sandbox.py b/scripts/clean_sandbox.py index 4e9266f..6522866 100755 --- a/scripts/clean_sandbox.py +++ b/scripts/clean_sandbox.py @@ -49,13 +49,9 @@ import pywikibot from pywikibot import i18n, pagegenerators +from pywikibot.backports import Tuple from pywikibot.bot import Bot, ConfigParserBot -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple content = { 'commons': '{{Sandbox}}\n', diff --git a/scripts/commons_link.py b/scripts/commons_link.py index 481b52e..dccd99c 100755 --- a/scripts/commons_link.py +++ b/scripts/commons_link.py @@ -35,12 +35,8 @@ import pywikibot from pywikibot import textlib, pagegenerators, i18n, Bot -from pywikibot.tools import PYTHON_VERSION +from pywikibot.backports import Tuple -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple docuReplacements = {'&params;': pagegenerators.parameterHelp} # noqa: N816 diff --git a/scripts/coordinate_import.py b/scripts/coordinate_import.py index cccd77c..758b9f2 100755 --- a/scripts/coordinate_import.py +++ b/scripts/coordinate_import.py @@ -44,14 +44,11 @@ from typing import Optional import pywikibot -from pywikibot import pagegenerators, WikidataBot -from pywikibot.exceptions import CoordinateGlobeUnknownException -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple +from pywikibot import pagegenerators, WikidataBot +from pywikibot.backports import Tuple +from pywikibot.exceptions import CoordinateGlobeUnknownException + docuReplacements = {'&params;': pagegenerators.parameterHelp} # noqa: N816 diff --git a/scripts/cosmetic_changes.py b/scripts/cosmetic_changes.py index 02abc43..601eff1 100644 --- a/scripts/cosmetic_changes.py +++ b/scripts/cosmetic_changes.py @@ -35,17 +35,12 @@ import pywikibot from pywikibot import config, i18n, pagegenerators +from pywikibot.backports import Tuple from pywikibot.bot import MultipleSitesBot, ExistingPageBot, NoRedirectPageBot from pywikibot.cosmetic_changes import ( CANCEL_ALL, CANCEL_MATCH, CANCEL_METHOD, CANCEL_PAGE, CosmeticChangesToolkit, ) -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple warning = """ diff --git a/scripts/create_categories.py b/scripts/create_categories.py index a02ef6c..7d68442 100755 --- a/scripts/create_categories.py +++ b/scripts/create_categories.py @@ -36,15 +36,11 @@ # Distributed under the terms of the MIT license. # import pywikibot + +from pywikibot.backports import Tuple from pywikibot.bot import AutomaticTWSummaryBot, SingleSiteBot from pywikibot import pagegenerators from pywikibot.site import Namespace -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple class CreateCategoriesBot(SingleSiteBot, AutomaticTWSummaryBot): diff --git a/scripts/data_ingestion.py b/scripts/data_ingestion.py index 754b0e5..d4ce7ad 100755 --- a/scripts/data_ingestion.py +++ b/scripts/data_ingestion.py @@ -111,15 +111,11 @@ import pywikibot +from pywikibot.backports import Tuple from pywikibot.comms.http import fetch from pywikibot import pagegenerators from pywikibot.specialbots import UploadRobot -from pywikibot.tools import deprecated_args, PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple +from pywikibot.tools import deprecated_args class Photo(pywikibot.FilePage): diff --git a/scripts/delete.py b/scripts/delete.py index f90664b..b5d001c 100755 --- a/scripts/delete.py +++ b/scripts/delete.py @@ -61,23 +61,11 @@ import pywikibot from pywikibot import i18n, pagegenerators +from pywikibot.backports import DefaultDict, Set, Tuple from pywikibot.bot import MultipleSitesBot, CurrentPageBot from pywikibot.page import Page from pywikibot.site import Namespace -from pywikibot.tools import islice_with_ellipsis, PYTHON_VERSION - -if PYTHON_VERSION < (3, 5, 2): - from typing import Dict as DefaultDict -elif PYTHON_VERSION < (3, 9): - from typing import DefaultDict -else: - DefaultDict = collections.defaultdict - -if PYTHON_VERSION >= (3, 9): - Set = set - Tuple = tuple -else: - from typing import Set, Tuple +from pywikibot.tools import islice_with_ellipsis # This is required for the text that is shown when you run this script diff --git a/scripts/djvutext.py b/scripts/djvutext.py index 12ac019..73195ae 100644 --- a/scripts/djvutext.py +++ b/scripts/djvutext.py @@ -38,15 +38,10 @@ from pywikibot import i18n +from pywikibot.backports import Tuple from pywikibot.bot import SingleSiteBot from pywikibot.proofreadpage import ProofreadPage from pywikibot.tools.djvu import DjVuFile -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple class DjVuTextBot(SingleSiteBot): diff --git a/scripts/download_dump.py b/scripts/download_dump.py index fdb8dee..54931f9 100644 --- a/scripts/download_dump.py +++ b/scripts/download_dump.py @@ -24,14 +24,10 @@ from os import remove, replace, symlink, urandom import pywikibot + +from pywikibot.backports import Tuple from pywikibot import Bot from pywikibot.comms.http import fetch -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple class DownloadDumpBot(Bot): diff --git a/scripts/editarticle.py b/scripts/editarticle.py index 8be8e5c..f974011 100755 --- a/scripts/editarticle.py +++ b/scripts/editarticle.py @@ -37,13 +37,8 @@ from pywikibot import i18n +from pywikibot.backports import Tuple from pywikibot.editor import TextEditor -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple class ArticleEditor(object): diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py index 44c7af1..e213c79 100755 --- a/scripts/harvest_template.py +++ b/scripts/harvest_template.py @@ -99,14 +99,9 @@ import pywikibot from pywikibot import pagegenerators as pg, textlib +from pywikibot.backports import List from pywikibot.bot import WikidataBot, OptionHandler -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - List = tuple -else: - from typing import List willstop = False diff --git a/scripts/interwikidata.py b/scripts/interwikidata.py index 09a5a95..9c1517f 100644 --- a/scripts/interwikidata.py +++ b/scripts/interwikidata.py @@ -32,13 +32,9 @@ import pywikibot from pywikibot import pagegenerators, output, warning +from pywikibot.backports import Set from pywikibot.bot import ExistingPageBot, SingleSiteBot, suggest_help -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Set = set -else: - from typing import Set # This is required for the text that is shown when you run this script # with the parameter -help. diff --git a/scripts/login.py b/scripts/login.py index b67b09b..7227b21 100755 --- a/scripts/login.py +++ b/scripts/login.py @@ -63,15 +63,10 @@ import pywikibot +from pywikibot.backports import Tuple from pywikibot import config from pywikibot.exceptions import SiteDefinitionError from pywikibot.login import OauthLoginManager -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple def _get_consumer_token(site) -> Tuple[str, str]: diff --git a/scripts/newitem.py b/scripts/newitem.py index 49418ec..76e3ba1 100755 --- a/scripts/newitem.py +++ b/scripts/newitem.py @@ -29,16 +29,13 @@ from textwrap import fill import pywikibot + from pywikibot import pagegenerators + +from pywikibot.backports import Set from pywikibot.bot import NoRedirectPageBot, WikidataBot from pywikibot.exceptions import (LockedPage, NoCreateError, NoPage, PageSaveRelatedError) -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Set = set -else: - from typing import Set DELETION_TEMPLATES = ('Q4847311', 'Q6687153', 'Q21528265') diff --git a/scripts/pagefromfile.py b/scripts/pagefromfile.py index aa90124..0a85865 100755 --- a/scripts/pagefromfile.py +++ b/scripts/pagefromfile.py @@ -74,13 +74,8 @@ import pywikibot from pywikibot import config, i18n +from pywikibot.backports import Tuple from pywikibot.bot import CurrentPageBot, OptionHandler, SingleSiteBot -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple class NoTitle(Exception): diff --git a/scripts/redirect.py b/scripts/redirect.py index 3628b4f..9b07caf 100755 --- a/scripts/redirect.py +++ b/scripts/redirect.py @@ -82,18 +82,10 @@ import pywikibot from pywikibot import i18n, xmlreader +from pywikibot.backports import Dict, List, Set, Tuple from pywikibot.bot import (ExistingPageBot, MultipleSitesBot, OptionHandler, RedirectPageBot) from pywikibot.textlib import extract_templates_and_params_regex_simple -from pywikibot.tools import PYTHON_VERSION - -if PYTHON_VERSION >= (3, 9): - Dict = dict - List = list - Set = set - Tuple = tuple -else: - from typing import Dict, List, Set, Tuple def space_to_underscore(link) -> str: diff --git a/scripts/solve_disambiguation.py b/scripts/solve_disambiguation.py index fa6b8ff..a806836 100755 --- a/scripts/solve_disambiguation.py +++ b/scripts/solve_disambiguation.py @@ -89,19 +89,17 @@ from typing import Generator, Optional import pywikibot + from pywikibot import config from pywikibot import editor as editarticle from pywikibot import i18n, pagegenerators +from pywikibot.backports import List from pywikibot.bot import (HighlightContextOption, ListOption, OutputProxyOption, SingleSiteBot, StandardOption) from pywikibot.tools import first_lower -from pywikibot.tools import first_upper as firstcap, PYTHON_VERSION +from pywikibot.tools import first_upper as firstcap from pywikibot.tools.formatter import SequenceOutputter -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List # Disambiguation Needed template dn_template = { diff --git a/scripts/templatecount.py b/scripts/templatecount.py index 3ddafed..076d611 100755 --- a/scripts/templatecount.py +++ b/scripts/templatecount.py @@ -43,14 +43,8 @@ from typing import Generator import pywikibot -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - Dict = dict - List = list - Tuple = tuple -else: - from typing import Dict, List, Tuple +from pywikibot.backports import Dict, List, Tuple class TemplateCountRobot: diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py index 5f7ed34..bf96ee0 100755 --- a/scripts/weblinkchecker.py +++ b/scripts/weblinkchecker.py @@ -131,18 +131,14 @@ from pywikibot import comms, i18n, pagegenerators, textlib from pywikibot import config2 as config +from pywikibot.backports import Tuple from pywikibot.bot import ExistingPageBot, SingleSiteBot, suggest_help from pywikibot.pagegenerators import ( XMLDumpPageGenerator as _XMLDumpPageGenerator, ) -from pywikibot.tools import deprecated, PYTHON_VERSION, ThreadList +from pywikibot.tools import deprecated, ThreadList from pywikibot.tools.formatter import color_format -if PYTHON_VERSION >= (3, 9): - Tuple = tuple -else: - from typing import Tuple - try: import memento_client from memento_client.memento_client import MementoClientException diff --git a/scripts/welcome.py b/scripts/welcome.py index 05d8aab..bb39b85 100755 --- a/scripts/welcome.py +++ b/scripts/welcome.py @@ -177,16 +177,11 @@ import pywikibot from pywikibot import config, i18n - +from pywikibot.backports import List from pywikibot.bot import SingleSiteBot from pywikibot.exceptions import HiddenKeyError from pywikibot.tools.formatter import color_format -from pywikibot.tools import PYTHON_VERSION -if PYTHON_VERSION >= (3, 9): - List = list -else: - from typing import List locale.setlocale(locale.LC_ALL, '') diff --git a/tox.ini b/tox.ini index e91424f..07db505 100644 --- a/tox.ini +++ b/tox.ini @@ -119,6 +119,7 @@ # pydocstyle cannot handle multiple __all__ variables pywikibot/__init__.py : N802, N806, N815, N816 pywikibot/_wbtypes.py: N802 + pywikibot/backports.py: F401 pywikibot/bot.py: N802, N815, N816 pywikibot/config2.py: N816 pywikibot/cosmetic_changes.py : N802, N803, N806, N816 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/651017 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I366e5c7233ed927d17e7bf8127a6fd7920d7f11d Gerrit-Change-Number: 651017 Gerrit-PatchSet: 10 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Isaacandy <isaac(a)iznd.xyz> Gerrit-Reviewer: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: Siebrand <siebrand(a)kitano.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 3 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits December 2020