jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/443761 )
Change subject: aspects.py: Fix/improve the type hints
......................................................................
aspects.py: Fix/improve the type hints
- Page is not imported directly into the module and type checkers won't
recognize it. Use pywikibot.Page instead.
- To annotate arguments it is preferred to use abstract collection types,
but for return type, more specific types are preferred. Therefore,
use pywikibot.BasePage for argument types and pywikibot.Page for
return types.
Change-Id: I6fcb0478bd9050eb30a7395540cb050e864e165b
---
M tests/aspects.py
1 file changed, 15 insertions(+), 13 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/aspects.py b/tests/aspects.py
index 3d420d5..b7bcb07 100644
--- a/tests/aspects.py
+++ b/tests/aspects.py
@@ -149,7 +149,7 @@
Assert that Pages is in namespaces.
@param page: Page
- @type page: Page
+ @type page: pywikibot.BasePage
@param namespaces: expected namespaces
@type namespaces: int or set of int
"""
@@ -168,11 +168,11 @@
if additional items are in the iterator.
@param gen: Page generator
- @type gen: generator of Page
+ @type gen: Iterable[pywikibot.BasePage]
@param count: number of pages to get
- @type titles: int
+ @type count: int
@param site: Site of expected pages
- @type site: APISite
+ @type site: pywikibot.APISite
"""
original_iter = iter(gen)
@@ -232,8 +232,6 @@
@type gen: generator
@param namespaces: expected namespaces
@type namespaces: int or set of int
- @param count: maximum results to process
- @type count: int
@param skip: skip test if not all namespaces found
@param skip: bool
"""
@@ -257,11 +255,11 @@
Only iterates to the length of titles plus two.
@param gen: Page generator
- @type gen: generator of Page
+ @type gen: Iterable[pywikibot.BasePage]
@param titles: Expected titles
@type titles: iterator
@param site: Site of expected pages
- @type site: APISite
+ @type site: pywikibot.APISite
"""
titles = self._get_canonical_titles(titles, site)
gen_titles = self._get_gen_titles(gen, len(titles), site)
@@ -274,11 +272,11 @@
Only iterates to the length of titles plus two.
@param gen: Page generator
- @type gen: generator of Page
+ @type gen: Iterable[pywikibot.BasePage]
@param titles: Expected titles
@type titles: iterator
@param site: Site of expected pages
- @type site: APISite
+ @type site: pywikibot.APISite
"""
titles = self._get_canonical_titles(titles, site)
gen_titles = self._get_gen_titles(gen, len(titles), site)
@@ -1099,10 +1097,10 @@
"""Create a Page object for the sites main page.
@param site: Override current site, obtained using L{get_site}.
- @type site: APISite or None
+ @type site: pywikibot.APISite or None
@param force: Get an unused Page object
@type force: bool
- @rtype: Page
+ @rtype: pywikibot.Page
"""
if not site:
site = self.get_site()
@@ -1125,7 +1123,11 @@
return mainpage
def get_missing_article(self, site=None):
- """Get a Page which refers to a missing page on the site."""
+ """Get a Page which refers to a missing page on the site.
+
+ @type site: pywikibot.Site or None
+ @rtype: pywikibot.Page
+ """
if not site:
site = self.get_site()
page = pywikibot.Page(pywikibot.page.Link(
--
To view, visit https://gerrit.wikimedia.org/r/443761
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fcb0478bd9050eb30a7395540cb050e864e165b
Gerrit-Change-Number: 443761
Gerrit-PatchSet: 3
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/443567 )
Change subject: [doc] Update HISTORY.rst file
......................................................................
[doc] Update HISTORY.rst file
Change-Id: I8f347498b0d109f295677014f59261d6726f3a65
---
M HISTORY.rst
1 file changed, 12 insertions(+), 5 deletions(-)
Approvals:
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/HISTORY.rst b/HISTORY.rst
index 967d0a9..fb55f18 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -4,6 +4,13 @@
Current release
---------------
+* Fix occasional failure of TestLogentries due to hidden namespace (T197506)
+* Remove multiple empty sections at once in cosmetic_changes (T196324)
+* Fix stub template position by putting it above interwiki comment (T57034)
+* Fix handling of API continuation in PropertyGenerator (T196876)
+* Use PyMySql as pure-Python MySQL client library instead of oursql, deprecate MySQLdb (T89976, T142021)
+* Ensure that BaseBot.treat is always processing a Page object (T196562, T196813)
+* New mediawiki projects were provided
* Bugfixes and improvements
* Localisation updates
@@ -23,7 +30,7 @@
* pagegenerators AllpagesPageGenerator, CombinedPageGenerator, UnconnectedPageGenerator are deprecated
* Some DayPageGenerator parameters has been renamed
* unicodedata2, httpbin and Flask dependency was removed (T102461, T108068, T178864, T193383)
-* new projects where provided
+* New projects were provided
* Bugfixes and improvements
* Documentation updates
* Localisation updates (T194893)
@@ -39,7 +46,7 @@
* pagegenerators.RepeatingGenerator is marked as deprecated (T192229)
* Deprecate requests-requirements.txt (T193476)
* Bugfixes and improvements
-* new mediawiki projects where provided
+* New mediawiki projects were provided
* Localisation updates
3.0.20180403
@@ -185,9 +192,9 @@
1.0 rv 2007-06-19
-----------------
* BeautifulSoup becomes mandatory
-* new scripts where added
-* new family files where supported
-* some scripts where archived
+* new scripts were added
+* new family files were supported
+* some scripts were archived
1.0
---
--
To view, visit https://gerrit.wikimedia.org/r/443567
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f347498b0d109f295677014f59261d6726f3a65
Gerrit-Change-Number: 443567
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/443581 )
Change subject: .travis.yml: Escape single quotes when printing oauth_token_var
......................................................................
.travis.yml: Escape single quotes when printing oauth_token_var
If the quotes are not escaped, then bash interprets `', '` as `, `
and the written tuple will be in the form of ('key , key, key, key')
instead of ('key', 'key', 'key', 'key').
Bug: T173498
Change-Id: I3b7720e8b781c502aa650e8ff3a7070e64cc2517
---
M .travis.yml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.travis.yml b/.travis.yml
index f175b7d..5f695d7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -85,7 +85,7 @@
fi ;
oauth_token_var="OAUTH_TOKENS_${FAMILY^^}_${LANGUAGE^^}" ;
if [[ -n "${!oauth_token_var}" ]]; then
- printf "authenticate['${OAUTH_DOMAIN}'] = ('%s')\n" "${!oauth_token_var//:/', '}" >> ~/.pywikibot/user-config.py ;
+ printf "authenticate['${OAUTH_DOMAIN}'] = ('%s')\n" "${!oauth_token_var//:/\', \'}" >> ~/.pywikibot/user-config.py ;
fi ;
fi
- echo "authenticate['wiki.musicbrainz.org'] = ('NOTSPAM', 'NOTSPAM')" >> ~/.pywikibot/user-config.py ;
--
To view, visit https://gerrit.wikimedia.org/r/443581
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b7720e8b781c502aa650e8ff3a7070e64cc2517
Gerrit-Change-Number: 443581
Gerrit-PatchSet: 1
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot