jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/443343 )
Change subject: Disable the need_extension('WikibaseClient') decorator on unconnected_pages
......................................................................
Disable the need_extension('WikibaseClient') decorator on unconnected_pages
Pywikibot caches the result of `CachedRequest`s and it seems that AppVeyor
is retaining that cache between project builds. This could also be true for
bot users.
This patch temporarily disables the need_extension decorator so that the
check is not performed. It should be OK to reenable it after 30 days when
the cache expires.
Bug: T198454
Change-Id: If64d7e48c71a79a3ff2ca63c71e1ccd9446cc96b
---
M pywikibot/site.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site.py b/pywikibot/site.py
index d2455bc..57a33dc 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -6765,7 +6765,7 @@
total=total)
@deprecated_args(step=None)
- @need_extension('WikibaseClient')
+ # @need_extension('WikibaseClient') T198454
def unconnected_pages(self, total=None):
"""Yield Page objects from Special:UnconnectedPages.
--
To view, visit https://gerrit.wikimedia.org/r/443343
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If64d7e48c71a79a3ff2ca63c71e1ccd9446cc96b
Gerrit-Change-Number: 443343
Gerrit-PatchSet: 2
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/443294 )
Change subject: logging.py: fix critcal() docstring
......................................................................
logging.py: fix critcal() docstring
critical() output goes to console as well.
Bug: T195537
Change-Id: Ia23832ee70f84e2860400ad0bbd24ecaeaeb1bd3
---
M pywikibot/logging.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Zhuyifei1999: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/logging.py b/pywikibot/logging.py
index bdac13b..12d0bde 100644
--- a/pywikibot/logging.py
+++ b/pywikibot/logging.py
@@ -164,7 +164,7 @@
def critical(text, decoder=None, newline=True, **kwargs):
- """Output a critical record to the log file."""
+ """Output a critical record to the user via the userinterface."""
logoutput(text, decoder, newline, CRITICAL, **kwargs)
--
To view, visit https://gerrit.wikimedia.org/r/443294
To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia23832ee70f84e2860400ad0bbd24ecaeaeb1bd3
Gerrit-Change-Number: 443294
Gerrit-PatchSet: 2
Gerrit-Owner: Mpaa
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-CC: Dvorapa <dvorapa(a)seznam.cz>