They are indeed false positives. I think I know what's happening here. Basically the tests are not atomic - they are trying to watch an article that is already watched and have the consequence of making that article watched. I have an idea of how to fix this.
Does Watir have a concept of a tear down step?
On Wed, Mar 19, 2014 at 1:45 PM, Arthur Richards arichards@wikimedia.orgwrote:
I tested these manually and think they may be false positives, but can someone else take a look to make sure these tests and what's in betalabs is OK? We should get this resolved asap so we can be sure the state of things is healthy on betalabs for tomorrow's deployment.
On Wed, Mar 19, 2014 at 12:19 PM, jenkins-no-reply@cloudbees.com wrote:
- FAILURE:
MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox Build #434 https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/ (Wed, 19 Mar 2014 18:40:00 +0000)* *Test Result*https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/testReport/ 2 failed, 1 skipped Failed Tests *Test Name**Duration**Age* Manage Watchlist.Add an article to the watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/testReport/junit/(root)/Manage%20Watchlist/Add_an_article_to_the_watchlist 37 sec1https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/433/ Manage Watchlist.Remove an article from the watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/testReport/junit/(root)/Manage%20Watchlist/Remove_an_article_from_the_watchlist 38 sec1https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/433/ All Tests *Package**Duration**Fail**Skip**Total* (root)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/testReport/junit/(root)30 min2161 Wikitext Editor (TEST RUN ON WIKIPEDIAhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/434/testReport/junit/Wikitext%20Editor%20(TEST%20RUN%20ON%20WIKIPEDIA 1 min 14 sec003
-- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687
On Wed, Mar 19, 2014 at 10:30 PM, Jon Robson jrobson@wikimedia.org wrote:
Does Watir have a concept of a tear down step?
No. Actually, Watir is really an insignificant part of our test automation toolset, just a wrapper around Selenium. And Selenium just drives browsers. But Cucumber, our test runner, does have hooks[1-2], code that runs before and/or after a scenario. Let me know if you need help with setting up Cucumber hooks.
Željko -- 1: https://github.com/cucumber/cucumber/wiki/Hooks 2: https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki_se...
Okay that seems like what I am looking for. So ideally I would include the tag @watchstar-setup in the 2 watchlist tests. They would then run API requests to ensure the page is watched (or run browser steps - is it possible to do that from in here)
I had a play around with this though and I can't get the hooks to run a basic puts statement - am I missing something? Do I need to require the hooks.rb file somewhere?
On Thu, Mar 20, 2014 at 8:58 AM, Željko Filipin zfilipin@wikimedia.orgwrote:
On Wed, Mar 19, 2014 at 10:30 PM, Jon Robson jrobson@wikimedia.orgwrote:
Does Watir have a concept of a tear down step?
No. Actually, Watir is really an insignificant part of our test automation toolset, just a wrapper around Selenium. And Selenium just drives browsers. But Cucumber, our test runner, does have hooks[1-2], code that runs before and/or after a scenario. Let me know if you need help with setting up Cucumber hooks.
Željko
1: https://github.com/cucumber/cucumber/wiki/Hooks 2: https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki_se...
On Thu, Mar 20, 2014 at 7:11 PM, Jon Robson jrobson@wikimedia.org wrote:
So ideally I would include the tag @watchstar-setup in the 2 watchlist tests. They would then run API requests to ensure the page is watched (or run browser steps - is it possible to do that from in here)
I am not sure what you are asking. Can you make a commit and push it to gerrit?
I had a play around with this though and I can't get the hooks to run a basic puts statement - am I missing something? Do I need to require the hooks.rb file somewhere?
If you run cucumber with -v[1] it should output all files that are loaded. Example:
$ bundle exec cucumber -v Code: * features/support/env.rb * features/support/hooks.rb (...)
Looks like hooks.rb is loaded. Can you make a commit and push it to gerrit?
Željko -- 1: -v, --verbose Show the files and features loaded.
I solved this in the end in another way - https://gerrit.wikimedia.org/r/120938
But basically I put some basic code in hooks.rb which did a puts but nothing was happening. I remember little about that now as I gave up trying...
On Thu, Mar 27, 2014 at 8:09 AM, Željko Filipin zfilipin@wikimedia.org wrote:
On Thu, Mar 20, 2014 at 7:11 PM, Jon Robson jrobson@wikimedia.org wrote:
So ideally I would include the tag @watchstar-setup in the 2 watchlist tests. They would then run API requests to ensure the page is watched (or run browser steps - is it possible to do that from in here)
I am not sure what you are asking. Can you make a commit and push it to gerrit?
I had a play around with this though and I can't get the hooks to run a basic puts statement - am I missing something? Do I need to require the hooks.rb file somewhere?
If you run cucumber with -v[1] it should output all files that are loaded. Example:
$ bundle exec cucumber -v Code:
- features/support/env.rb
- features/support/hooks.rb
(...)
Looks like hooks.rb is loaded. Can you make a commit and push it to gerrit?
Željko
1: -v, --verbose Show the files and features loaded.
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l