I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
Thats no good. Arthur & Patrick. Can you guys take a look ?
--tomasz
On Tue, Mar 20, 2012 at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Patrick, here is the full change set sitting on the deployment branch.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114238
This fixes the issue on test and i'm eager to push it if you don't see any problems.
--tomasz
On Tue, Mar 20, 2012 at 1:41 AM, Jon Robson jrobson@wikimedia.org wrote:
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Feel free to push that.
— Patrick
On Mar 20, 2012, at 1:43 AM, Tomasz Finc tfinc@wikimedia.org wrote:
Patrick, here is the full change set sitting on the deployment branch.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114238
This fixes the issue on test and i'm eager to push it if you don't see any problems.
--tomasz
On Tue, Mar 20, 2012 at 1:41 AM, Jon Robson jrobson@wikimedia.org wrote:
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Are you pushing this?
— Patrick
On Mar 20, 2012, at 1:43 AM, Tomasz Finc tfinc@wikimedia.org wrote:
Patrick, here is the full change set sitting on the deployment branch.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114238
This fixes the issue on test and i'm eager to push it if you don't see any problems.
--tomasz
On Tue, Mar 20, 2012 at 1:41 AM, Jon Robson jrobson@wikimedia.org wrote:
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Change pushed. I'm no longer seeing the issue.
--tomasz
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Are you pushing this?
— Patrick
On Mar 20, 2012, at 1:43 AM, Tomasz Finc tfinc@wikimedia.org wrote:
Patrick, here is the full change set sitting on the deployment branch.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114238
This fixes the issue on test and i'm eager to push it if you don't see any problems.
--tomasz
On Tue, Mar 20, 2012 at 1:41 AM, Jon Robson jrobson@wikimedia.org wrote:
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
What page are you testing?
— Patrick
On Mar 20, 2012, at 1:56 AM, Tomasz Finc tfinc@wikimedia.org wrote:
Change pushed. I'm no longer seeing the issue.
--tomasz
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Are you pushing this?
— Patrick
On Mar 20, 2012, at 1:43 AM, Tomasz Finc tfinc@wikimedia.org wrote:
Patrick, here is the full change set sitting on the deployment branch.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114238
This fixes the issue on test and i'm eager to push it if you don't see any problems.
--tomasz
On Tue, Mar 20, 2012 at 1:41 AM, Jon Robson jrobson@wikimedia.org wrote:
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l
Asher could this be cache related?
— Patrick
On Mar 20, 2012, at 1:41 AM, Jon Robson jrobson@wikimedia.org wrote:
I think we have a fix that Tomasz is about to deploy File pages seem to have zero rated banners regardless of whether a X-Carrier header is sent
See: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&...
2012/3/20 Patrick Reilly preilly@wikimedia.org:
Can you give me a page that is doing it?
— Patrick
On Mar 20, 2012, at 12:38 AM, Asher Feldman afeldman@wikimedia.org wrote:
I think the code to only display data charge warnings on image click thrus if X-Carrier == DIGI either got factored out in the de-wmf-ification or was lost in merging.
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l