Feel free to push that.
— Patrick
On Mar 20, 2012, at 1:43 AM, Tomasz Finc <tfinc(a)wikimedia.org> wrote:
Patrick, here is the full change set sitting on the
deployment branch.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114238
This fixes the issue on test and i'm eager to push it if you don't see
any problems.
--tomasz
On Tue, Mar 20, 2012 at 1:41 AM, Jon Robson <jrobson(a)wikimedia.org> wrote:
> I think we have a fix that Tomasz is about to deploy
> File pages seem to have zero rated banners regardless of whether a
> X-Carrier header is sent
>
> See:
>
http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/114237&am…
>
> 2012/3/20 Patrick Reilly <preilly(a)wikimedia.org>rg>:
>> Can you give me a page that is doing it?
>>
>> — Patrick
>>
>> On Mar 20, 2012, at 12:38 AM, Asher Feldman <afeldman(a)wikimedia.org>
wrote:
>>
>> I think the code to only display data charge warnings on image click thrus
>> if X-Carrier == DIGI either got factored out in the de-wmf-ification or was
>> lost in merging.
>>
>>
https://bugzilla.wikimedia.org/show_bug.cgi?id=35352
>>
>>
>> _______________________________________________
>> Mobile-l mailing list
>> Mobile-l(a)lists.wikimedia.org
>>
https://lists.wikimedia.org/mailman/listinfo/mobile-l
>>
>
> _______________________________________________
> Mobile-l mailing list
> Mobile-l(a)lists.wikimedia.org
>
https://lists.wikimedia.org/mailman/listinfo/mobile-l