Vibha,
Attached you can find an apk to try out the page issues feature and some
screenshots.
Main difference to previous screen shots:
The date now shows up in a separate TextView below the issue text (with
the styling you suggested).
Blockers: The [Issues] link on the page still needs to be replaced with
the flag icon. But I'm blocked on vagrant setup at the moment.
FYI, I used [[8 mm video format]] for the screenshots.
Not sure on which languages it actually works. It does work on enwiki but
not on dewiki. While there are great links to drive contributions by
improving articles on dewiki[1] the templates there don't seem to use the
mbox or ambox class. On the other hand, since they don't use ambox class
tables they don't get hidden in our app, so issues there are visible
directly on the page.
-Bernd
[1]:
wikipedia-2.0-dev-2014-07-23-page_issues.apk
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQvQnJxaGRjVlROMTA/edit?usp=drive_web>
pageIssuesLight3.png
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQvNUxFNkhxY091bjg/edit?usp=drive_web>
pageIssuesDark3.png
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQveVdyUmc1NGwtQ0E/edit?usp=drive_web>
On Tue, Jul 22, 2014 at 6:14 PM, Vibha Bamba <vbamba(a)wikimedia.org>
wrote:
Just reviewed this, looks great! I'm honestly
psyched!
Help icon attached for action bar (32 dp canvas, 24 dp focus)
*Notes:*
This will only show up in the direct manipulation step in the editing
workflow.
Apply same color as the W to the icon for the Night Mode/ Reverse Theme.
----
Vibha Bamba
Senior Designer | WMF Design
On Tue, Jul 22, 2014 at 2:21 PM, Bernd Sitzmann <bsitzmann(a)wikimedia.org
wrote:
Vibha,
The color changes can be done in code, see below. I've also adjusted
the top margin for the flag to match the text.
Splitting the text will take a bit longer. It's a bit riskier since the
text needs to be parsed.
pageIssuesDark2.png
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQvX1VINXJFS1RreTg/edit?usp=drive_web>
pageIssuesLight2.png
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQvOTV6aDJnQXMyMEE/edit?usp=drive_web>
-Bernd
On Tue, Jul 22, 2014 at 3:02 PM, Dmitry Brant <dbrant(a)wikimedia.org>
wrote:
> Yay, that looks awesome! (+mobile-l)
>
>
>
> On Tue, Jul 22, 2014 at 4:46 PM, Vibha Bamba <vbamba(a)wikimedia.org>
> wrote:
>
>> OMG this looks great! And so fast :)
>> Two small changes
>>
>> 1. The flag and message should be top aligned
>> (let me know if the canvas are is getting in the way for this)
>> I can provide a flag icon in a 24 dp focus area with no padding.
>>
>> 2. The date when the template was added needs to be on its own line,
>> no parenthesis. All caps in color #555, 2-3 types sizes smaller than the
>> description (I can provide an exact type size value if I know the
>> relatives values)
>>
>> Thanks!
>> Vibha
>>
>>
>>
>>
>> ----
>> Vibha Bamba
>> Senior Designer | WMF Design
>>
>>
>>
>>
>>
>>
>>
>>
>> On Tue, Jul 22, 2014 at 1:33 PM, Bernd Sitzmann <
>> bsitzmann(a)wikimedia.org> wrote:
>>
>>> Vibha,
>>>
>>> Thank you for the flag icon. Attached you can find some screen shots
>>> for the page issues dialog for your review: one with light theme, another
>>> one with dark theme. Let me know what needs to change, while I'm working
on
>>> getting the flag image to show up in the WebView.
>>> Now looking at some real-world page issues I see that maybe the
>>> original name "article issues" is not so far off since most of the
issues
>>> seems to mention the word article instead of page.
>>>
>>> pageIssuesLight.png
>>>
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQvZUk3Uy1VWEVLX1E/edit?usp=drive_web>
>>>
>>> pageIssuesDark.png
>>>
<https://docs.google.com/a/wikimedia.org/file/d/0BxUyJSM66jQvWUMwcHdXeW02bHc/edit?usp=drive_web>
>>>
>>> Cheers,
>>> -Bernd
>>>
>>>
>>> On Mon, Jul 21, 2014 at 6:07 PM, Vibha Bamba <vbamba(a)wikimedia.org>
>>> wrote:
>>>
>>>> This is consistent with wikifont.
>>>> It is set in a 32 dp canvas with 24 dp focus area.
>>>> Please lmk if you see any issues :)
>>>>
>>>>
>>>> ----
>>>> Vibha Bamba
>>>> Senior Designer | WMF Design
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>