The danger with this is that "Main Page" and other forms will sneak in again. It is much more natural to write I am on the "San Francisco" page or I am on the "List of districts and neighborhoods of Los Angeles" page or I am on the "1+1" page
Whether this is a typo or not I'm not sure. There are various other replacements that occur to URLs other than ' ' => '_' - for example - 1+1 gets changed to "1%2B1" do we really propose that the writer of the test is aware of all of these? It seems like it goes against the idea of a feature being human readable and easy to write. This is why I proposed automatically substituting ' ' for '_' in my change.
Either way it sounds like both of these patches should be reverted as both seem to be sub-par. We should get consensus before fixing this.
On a side note: RIght now I'm much more interested in getting https://bugzilla.wikimedia.org/show_bug.cgi?id=62614 addressed first...
On Tue, Mar 25, 2014 at 12:15 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
So as you probably know, some of our tests that pass in Firefox fail in Chrome.
One issue is that in a number of places the tests accept a string to look for in a URL that is defined as "Main Page". But in the browser, the URL ultimately will contain the string "Main_Page".
I committed a change such that the test would check that *at some point* the URL will contain the string "Main Page" as specified in the test. In hindsight, this was probably a bad idea, because the original tests just care that we land on the correct URL, not that we handle spaces correctly. https://gerrit.wikimedia.org/r/#/c/119878
Jon committed a change that invisibly munges the input string to replace the first (and only the first) space character with an underline character. This is probably also not a great idea, because it secretly changes test inputs without the user (or maintainer) knowing. https://gerrit.wikimedia.org/r/#/c/120564
After thinking it over, I think what we should do to make the tests perform the way the tests were intended to perform is to revert the two changes I mentioned above, and to simply change every occurrence of "Main Page" in the features to be "Main_Page". That will not only satisfy Firefox and Chrome, but it will also satisfy the intent of the tests themselves. I suspect that using "Main Page" was essentially a typo that propagated through the test suite over time.
-Chris
Mobile-l mailing list Mobile-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l