The danger with this is that "Main Page" and other forms will sneak in again. It is much more natural to write I am on the "San Francisco" page

This is why I proposed automatically substituting ' ' for '_' in my change.

I actually agree with you on this Chris. The URL correctness is not a good test. Looking at all of these I can see they don't really add anything to these tests and the mainmenu.feature tests could be written better. I'm preparing a patch as we speak to remove/rewrite these. On Tue, Mar 25, 2014 at 3:37 PM, Chris McMahon <cmcmahon(a)wikimedia.org> wrote: > > > > On Tue, Mar 25, 2014 at 2:04 PM, Jon Robson <jrobson(a)wikimedia.org> wrote: >> >> The danger with this is that "Main Page" and other forms will sneak in >> again. It is much more natural to write >> I am on the "San Francisco" page > > > >> >> This is why >> >> I proposed automatically substituting ' ' for '_' in my change. > > > I haven't had this argument in a while, but I actually think checking for > URL correctness is almost never a very good test. Do y'all think we could > just flat remove some of these? (It is the one in commons_steps.rb that is > causing the immediate problem, but some of those others aren't too smart > either.) > > $ grep -r "The URL of the page" * > features/mainmenu.feature: Then The URL of the page should contain > "Main_Page" > features/mainmenu.feature: Then The URL of the page should contain > "campaign=random" > features/mainmenu.feature: Then The URL of the page should contain > "Special:Nearby" > features/mainmenu.feature: Then The URL of the page should contain > "returnto=Special%3AWatchlist" > features/mainmenu.feature: Then The URL of the page should contain > "returnto=Special%3AUploads" > features/mainmenu.feature: Then The URL of the page should contain > "Special:MobileOptions" > features/mainmenu.feature: Then The URL of the page should contain > "Special:UserLogin" > features/editor_wikitext_nosave.feature: And The URL of the page should > contain "Nonexistent_page_ijewrcmhvg34773" > features/editor_wikitext_nosave.feature: And The URL of the page should > contain "Nonexistent_page_ijewrcmhvg34773" > features/search.feature: And The URL of the page should contain > "Main%20Page" > features/search.feature: And The URL of the page should contain > "Main%20Page" > features/editor_ve.feature: And The URL of the page should contain > "#/VisualEditor/1" > features/step_definitions/common_steps.rb:Then(/^The URL of the page should > contain "(.+)"$/) do |article| > features/uploads_lead.feature: And The URL of the page should contain > "Nonexistent_page_abc" > features/uploads_lead.feature: And The URL of the page should contain > "Nonexistent_page_abc"

On Wed, Mar 26, 2014 at 5:36 PM, Jon Robson <jrobson(a)wikimedia.org> wrote: When I write a test, the first check that I usually write is that the browser is at the correct page. Usually, the easiest way to check that is by checking the URL. If that causes more trouble than it is worth, then we should remove the check. If that is a valuable check, we can write a cucumber transform[1] that would make sure all page names are correctly URL encoded before comparing them with browser URL. Željko -- 1: https://github.com/cucumber/cucumber/wiki/Step-Argument-Transforms

On Thu, Mar 27, 2014 at 9:36 AM, Jon Robson <jdlrobson(a)gmail.com> wrote: Many of the tests for MobileFrontend were created without much review by Michelle, me, Jeff, and others. We're cleaning up a lot of cruft. -Chris

On Thu, Mar 27, 2014 at 11:30 AM, Jon Robson <jdlrobson(a)gmail.com> wrote: This is something on which Zeljko and I disagree. Especially in Mediawiki where URL schemes are highly malleable, I don't think checking for some string in a URL is very useful. URLs don't have anything to do with function, and we are creating functional tests here. -Chris

On Thu, Mar 27, 2014 at 5:36 PM, Jon Robson <jdlrobson(a)gmail.com> wrote: I will try to be short. If anything is unclear, please ask. When I start testing a feature, the first test that I write is usually a check if the (correct) page opens at all. If the page does not open for what ever reason (redirect, error page, server down, network down...) all other tests will fail anyway. The experience has shown that when a lot of tests fail, it is important to quickly figure out what failed. Everything? Just a few things? Maybe just one? If the test that checks if the page opens fails, then it is clear where the problem is. How to test if the (correct) page opens? #1 go to the page #2 check the page Going to the page is simple, but checking the page could take a lot of effort if we decide to check for every single page element. So, we check just the relevant ones. My experience has shown that from all page attributes URLs tend to be the most stable ones. So, when I am thinking what should I check for first, I usually check the URL and then a few relevant page elements. I never thought about it a lot, since URLs are pretty stable and/or easy to encode/decode. If that is not the case in your experience, feel free to delete all URL checks. Željko _______________________________________________ Mobile-l mailing list Mobile-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l