Krinkle fixed the immediate problem I opened https://bugzilla.wikimedia.org/show_bug.cgi?id=64564 to further optimise the mediawiki.util library
On Sun, Apr 27, 2014 at 11:23 AM, Krinkle krinklemail@gmail.com wrote:
The module was split out of mediawiki.util, nothing new, no need for any special treatment here.
It should've been given the same "target" definition as mediawiki.util.
— Krinkle
On 27 Apr 2014, at 19:37, Jon Robson jdlrobson@gmail.com wrote:
Looks like jquery.accessKeyLabel now seems to be a required ResourceLoader module.
The patch that introduced it is https://gerrit.wikimedia.org/r/#/c/125426/and this has exploded the mobile site with 49 or 50 tests failing since the merge.
I'm not quite sure whether this module is useful on mobile. I'm not judging that here - I just want to report this is a consideration.
Seems we have 2 options
- Enable the module on mobile if it is applicable. If it's a small library
maybe decide on whether it is important later. 2) Revert this core change and rethink this
We need to do _one_ of the above before the next deployment train.
The damage can be viewed at http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin - basically JavaScript exception.
Bug at https://bugzilla.wikimedia.org/show_bug.cgi?id=64512
On Sat, Apr 26, 2014 at 10:18 PM, jenkins-no-reply@cloudbees.com wrote:
- FAILURE: MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome
Build #409 https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/ (Sun, 27 Apr 2014 04:52:29 +0000)* *Test Result*https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/ 50 failed, 20 skipped Failed Tests *Test Name**Duration**Age* Check UI components.Check existence of important UI components on other pages.https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Check%20UI%20components/Check_existence_of_important_UI_components_on_other_pages_22 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Encourage new users to Keep Going.I see a KeepGoing message after completing my VisualEditor edithttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Encourage%20new%20users%20to%20Keep%20Going/I_see_a_KeepGoing_message_after_completing_my_VisualEditor_edit48 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Encourage new users to Keep Going.I see a KeepGoing message after completing my edithttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Encourage%20new%20users%20to%20Keep%20Going/I_see_a_KeepGoing_message_after_completing_my_edit52 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Loginhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Login39 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Nearbyhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Nearby10 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Uploadshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Uploads2.2 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Generic special page features.Search from Watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Generic%20special%20page%20features/Search_from_Watchlist38 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.Clicking page issues opens overlayhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/Clicking_page_issues_opens_overlay12 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.Closing page issueshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/Closing_page_issues12 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.Closing page issues (browser back)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/Closing_page_issues__browser_back_13 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Issues.I see the this page has issues stamphttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Issues/I_see_the_this_page_has_issues_stamp5 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Language Validation - Logged In.Validate Language selection availabilityhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Language%20Validation%20-%20Logged%20In/Validate_Language_selection_availability6.9 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Language selection.Closing language overlay (browser button)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Language%20selection/Closing_language_overlay__browser_button_13 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Language selection.Closing language overlay (overlay button)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Language%20selection/Closing_language_overlay__overlay_button_14 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Language selection.Opening language overlayhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Language%20selection/Opening_language_overlay5.1 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Lead image tutorial.See tutorial as new userhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Lead%20image%20tutorial/See_tutorial_as_new_user25 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Lead image tutorial.There is an upload buttonhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Lead%20image%20tutorial/There_is_an_upload_button5.5 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Lead image uploads.Opening upload previewhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Lead%20image%20uploads/Opening_upload_preview4 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Loading pages.Edit button updates when lazy load a page from searchhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Loading%20pages/Edit_button_updates_when_lazy_load_a_page_from_search29 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Loading pages.Page loads without ajax in stablehttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Loading%20pages/Page_loads_without_ajax_in_stable1 min 15 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Manage Watchlist.Add an article to the watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Manage%20Watchlist/Add_an_article_to_the_watchlist6.9 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Manage Watchlist.Remove an article from the watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Manage%20Watchlist/Remove_an_article_from_the_watchlist35 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Menus open correct page for anonymous users.Check links in menuhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Menus%20open%20correct%20page%20for%20anonymous%20users/Check_links_in_menu12 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Menus open correct page for anonymous users.Check links in menuhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Menus%20open%20correct%20page%20for%20anonymous%20users/Check_links_in_menu_20.7 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Menus open correct page for anonymous users.Uploads URL is set correctlyhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Menus%20open%20correct%20page%20for%20anonymous%20users/Uploads_URL_is_set_correctly9.2 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Nearby pages.Nearby button visiblehttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Nearby%20pages/Nearby_button_visible2 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Notification.Opening notificationshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Notification/Opening_notifications4 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page actions menu when anonymous.Receive notification message - Edit Iconhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20actions%20menu%20when%20anonymous/Receive_notification_message___Edit_Icon5.2 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page actions menu when anonymous.Receive notification message - Upload Iconhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20actions%20menu%20when%20anonymous/Receive_notification_message___Upload_Icon13 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page actions menu when anonymous.Receive notification message - Watchlist Iconhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20actions%20menu%20when%20anonymous/Receive_notification_message___Watchlist_Icon14 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page actions menu when logged in.I can add the Main Page to my watchlisthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20actions%20menu%20when%20logged%20in/I_can_add_the_Main_Page_to_my_watchlist30 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page actions menu when logged in.I can see the edit button on the Main Pagehttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20actions%20menu%20when%20logged%20in/I_can_see_the_edit_button_on_the_Main_Page5.3 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page actions menu when logged in.I cannot upload a lead photo to the Main Pagehttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20actions%20menu%20when%20logged%20in/I_cannot_upload_a_lead_photo_to_the_Main_Page27 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Page diff.Added and removed contenthttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Page%20diff/Added_and_removed_content31 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Reference popup drawer.Closing the reference drawerhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Reference%20popup%20drawer/Closing_the_reference_drawer14 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Reference popup drawer.Opening the reference drawerhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Reference%20popup%20drawer/Opening_the_reference_drawer13 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Search.Opening searchhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Search/Opening_search4 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Special:History.Check components in diff summaryhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Special_History/Check_components_in_diff_summary4 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Special:Uploads tutorial.Link to tutorial for new userhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Special_Uploads%20tutorial/Link_to_tutorial_for_new_user23 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Special:Uploads uploads.Upload image filehttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Special_Uploads%20uploads/Upload_image_file20 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Special:Uploads uploads.Upload image file of invalid formathttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Special_Uploads%20uploads/Upload_image_file_of_invalid_format19 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Talk.Talk doesn't show on talk pageshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Talk/Talk_doesn_t_show_on_talk_pages3 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Toggling sections.Closing a sectionhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Toggling%20sections/Closing__a_section11 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Toggling sections.Opening a sectionhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Toggling%20sections/Opening_a_section5.1 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ VisualEditor.Switch from VisualEditor to source editor and back (with editor stickiness)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/VisualEditor/Switch_from_VisualEditor_to_source_editor_and_back__with_editor_stickiness_12 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Wikitext Editor (Makes actual saves).Broken redirectshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Broken_redirects26 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Wikitext Editor (Makes actual saves).Redirectshttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Redirects26 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Wikitext Editor (Makes actual saves).Successful edit on page without languages shows no language button [bug 63675]https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Successful_edit_on_page_without_languages_shows_no_language_button__bug_63675_8.5 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Wikitext Editor (Makes actual saves).Successful edit reloads language buttonhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Successful_edit_reloads_language_button27 sec2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ Wikitext Editor (TEST RUN ON WIKIPEDIA SO SHOULD NOT CAUSE SAVES).Opening editorhttps://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)/Wikitext%20Editor%20(TEST%20RUN%20ON%20WIKIPEDIA%20SO%20SHOULD%20NOT%20CAUSE%20SAVES)/Opening_editor2 ms2https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/407/ All Tests *Package**Duration**Fail**Skip**Total* (root)https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/409/testReport/junit/(root)17 min502083
-- Jon Robson
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l