On Thu, Mar 20, 2014 at 11:54 PM, Chris McMahon cmcmahon@wikimedia.orgwrote:
Adhere to the Page Object design pattern: keep your page element identifiers in the /support/pages/*page.rb files ONLY, and NOT in the /step_definitions/*steps.rb files.
Is there a reason for this e-mail? Did you find a lot of violations of the pattern in the code? Since the e-mail message was sent to both QA and mobile mailing lists, my guess is that you have noticed a problem in MobileFrontend[1] repository. :)
I am not asking because I want to blame a person or a team, I think fixing such problems is a great first contribution for a new volunteer, and I am always looking for those.
Željko -- 1: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/tree/master...