I actually agree with you on this Chris. The URL correctness is not a good test. Looking at all of these I can see they don't really add anything to these tests and the mainmenu.feature tests could be written better. I'm preparing a patch as we speak to remove/rewrite these.
On Tue, Mar 25, 2014 at 3:37 PM, Chris McMahon cmcmahon@wikimedia.org wrote:
On Tue, Mar 25, 2014 at 2:04 PM, Jon Robson jrobson@wikimedia.org wrote:
The danger with this is that "Main Page" and other forms will sneak in again. It is much more natural to write I am on the "San Francisco" page
This is why
I proposed automatically substituting ' ' for '_' in my change.
I haven't had this argument in a while, but I actually think checking for URL correctness is almost never a very good test. Do y'all think we could just flat remove some of these? (It is the one in commons_steps.rb that is causing the immediate problem, but some of those others aren't too smart either.)
$ grep -r "The URL of the page" * features/mainmenu.feature: Then The URL of the page should contain "Main_Page" features/mainmenu.feature: Then The URL of the page should contain "campaign=random" features/mainmenu.feature: Then The URL of the page should contain "Special:Nearby" features/mainmenu.feature: Then The URL of the page should contain "returnto=Special%3AWatchlist" features/mainmenu.feature: Then The URL of the page should contain "returnto=Special%3AUploads" features/mainmenu.feature: Then The URL of the page should contain "Special:MobileOptions" features/mainmenu.feature: Then The URL of the page should contain "Special:UserLogin" features/editor_wikitext_nosave.feature: And The URL of the page should contain "Nonexistent_page_ijewrcmhvg34773" features/editor_wikitext_nosave.feature: And The URL of the page should contain "Nonexistent_page_ijewrcmhvg34773" features/search.feature: And The URL of the page should contain "Main%20Page" features/search.feature: And The URL of the page should contain "Main%20Page" features/editor_ve.feature: And The URL of the page should contain "#/VisualEditor/1" features/step_definitions/common_steps.rb:Then(/^The URL of the page should contain "(.+)"$/) do |article| features/uploads_lead.feature: And The URL of the page should contain "Nonexistent_page_abc" features/uploads_lead.feature: And The URL of the page should contain "Nonexistent_page_abc"