"Are you seeing this behavior universally on the cluster, or only on
specific wikis?"
*shrugs* I don't really have data on that. I can say that neither en.m.wp.o
and de.m.wp.o are using mobile CN urls.
"Also, are you sure that you're getting into that if block (class_exists(
'MobileContext' ) is returning true) on the cluster?"
Yep; if you run mediaWiki.getConfig('wgNoticeHideUrls') you'll see that
those URLs have mobile variants (on both the mobile and desktop sites.)
"when you test locally, do you have a value set in your config for
$wgMobileUrlTemplate (eg %h0.m.%h1.%h2)?"
No; I'm just breakpointing through it and can see that
shouldDisplayMobileView() is returning true.
~Matt Walker
Wikimedia Foundation
Fundraising Technology Team
On Mon, Nov 4, 2013 at 4:56 PM, Arthur Richards <arichards(a)wikimedia.org>wrote;wrote:
Are you seeing this behavior universally on the
cluster, or only on
specific wikis? Also, are you sure that you're getting into that if block
(class_exists( 'MobileContext' ) is returning true) on the cluster?
And out of curiosity, when you test locally, do you have a value set in
your config for $wgMobileUrlTemplate (eg %h0.m.%h1.%h2)?
On Mon, Nov 4, 2013 at 5:41 PM, Matthew Walker <mwalker(a)wikimedia.org>wrote;wrote:
Hey all,
Something you might have more instantaneous insight on than I.
I deployed a fix to CentralNotice today [1] that should have started
serving mobile URLs for CN to mobile clients. It does this by querying
MobileContext::singleton()->shouldDisplayMobileView() inside of the
ResourceLoaderGetConfigVars hook. However, it appears that either... that
function is returning false, or... getMobileUrl is not properly mangling
URLs.
I suspect it's that the function is returning false because:
* I deployed a 'fix' earlier that just used getMobileUrl() which
redirected everyone to the mobile URLs. And...
* There's a blob of code that I added in this patch that will always
mangle URLs and it seems like that's working just fine.
I've tested on my local machine with MF loaded first, and MF loaded last
and can not reproduce the cluster behaviour. So... thoughts?
[1]
https://gerrit.wikimedia.org/r/#/c/92806/
~Matt Walker
Wikimedia Foundation
Fundraising Technology Team
_______________________________________________
Mobile-l mailing list
Mobile-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mobile-l
--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687