On Thu, Feb 4, 2016 at 2:44 PM, Jean-Frédéric
<jeanfrederic.wiki(a)gmail.com> wrote:
2016-02-04 19:31 GMT+00:00 Brian Wolff <bawolff(a)gmail.com>om>:
I think its more likely gwtoolset looks at the mime type set in the
Content-type header set by the webserver.
(Disclaimer: I checked out the GWToolset for the first time today).
According to the documentation of getFileExtension in
includes/Handlers/UploadHandler.php (assuming I’m looking a the right
place); it is doing both:
>
> attempts to get the file extension of a media file url using the
>
> $options provided. it will first look for a valid file extension in the
>
> url; if none is found it will fallback to an appropriate file extention
>
> based on the content-type
I just checked this file. The webserver is indeed misconfigured, and
returning a mime type of image/jpg (Correct mime
type is image/jpeg).
I believe that code you're referencing is used to determine the
extension to give the image when uploading it. e.g. jpg files are
allowed to have the extension jpg, jpeg or even jpe. So it uses the
url to decide between which of those three alternatives to use, in the
case the mime type sent is image/jpeg. But if a different mime type is
sent, then it won't consider .jpg to be a valid extension for that
type.
The code comment itself is a bit misleading. If you look at the actual
code [Simplifying things to make it clearer]
$result = null;
...
$pathinfo['extension'] = <extension from url>
if ( in_array( $pathinfo['extension'], $wgFileExtensions )
&& strpos( $MimeMagic->getTypesForExtension(
$pathinfo['extension'] ),
$options['content-type']
) !== false
) {
// So, if the extension from url is in $wgFileExtensions (Allowed
upload extensions)
// And, when we get the list of possible mime types for that
extension, one of them matches what was sent by the server
// then use the extension from the url
$result = $pathinfo['extension'];
} elseif ( !empty( $options['content-type'] ) ) {
// Otherwise, just use the default extension for this mime type.
$result = explode( ' ',
$MimeMagic->getExtensionsForType( $options['content-type'] ) );
if ( !empty( $result ) ) {
$result = $result[0];
}
}
----
So what happens in this case. Image has mime type of image/jpg, which
is not a real mime type. First it tries to use the extension from the
webserver (.jpg), but when it checks if .jpg is a valid extension for
that mime type, it determines no it isn't (Since there is no valid
extensions for non-existent mime types), so it discards that option.
Then it tries to use the default extension for the given mime type,
but again fails since there are no default extensions for the
non-existent mime type. And thus the check overall fails.
--
-bawolff
