Update: this is done. Mobile is now using OOJS for its classes and event emitting.
I would appreciate if people could vigorously test things on beta labs. We have already identified two issues [1,2] that seem to have been caused by moving to OO.EventEmitter (I believe the issue is something to do with the fact we cannot scope events) but not investigated them since they are low priority.
Next steps: * I will mail next week about this but we are looking to test drive Trevor's OOUI Template widget. * I'm hoping to take a closer look at modal dialogs built by Flow and Growth and try and find some commonality between mobile's overlays.
[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=71075 [2] https://bugzilla.wikimedia.org/show_bug.cgi?id=71076
On Tue, Sep 16, 2014 at 2:54 PM, Jon Robson jrobson@wikimedia.org wrote:
Update: Since these changes touch every single bit of mobile's code and might have scary unforeseen consequences we are going to review/merge these after this weeks deployment. I've scheduled a pair programming session with Kaldari on Friday to do this.
On Fri, Sep 12, 2014 at 3:14 PM, Trevor Parscal tparscal@wikimedia.org wrote:
Jon, this is really awesome. I'm excited to be sharing more code.
I'll be taking a look at these patches with Roan today.
- Trevor
On Fri, Sep 12, 2014 at 11:43 AM, Tomasz Finc tfinc@wikimedia.org wrote:
On Fri, Sep 12, 2014 at 11:32 AM, Jon Robson jrobson@wikimedia.org wrote:
After this is done it would be good to sit down and document ways we can make better use of OOJS in mobile.
Are you thinking of retooling existing features/infrastructure to use it first or making this a requirement for new features?
This sounds like a good discussion to have during the quarterly planning but I certainly think we shouldn't wait that long to do it.
--tomasz
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l