Hello,
Some older versions of Mediawiki (1.16) do not provide "mediatype" in "iiprop" for media. Then its worker crashes when it tries to parse a reply from a server.
Here is workaround for an issue:
--- ext.core.LinkHandler.js- 2015-04-22 15:30:04.000000000 +0300 +++ ext.core.LinkHandler.js 2015-04-22 17:03:11.000000000 +0300 @@ -1011,7 +1012,11 @@ // Add (read-only) information about original file size (T64881) img.addAttribute( 'data-file-width', info.width ); img.addAttribute( 'data-file-height', info.height ); - img.addAttribute( 'data-file-type', info.mediatype.toLowerCase() ); + if (info.mediatype) { + img.addAttribute( 'data-file-type', info.mediatype.toLowerCase() ); + } }
if ( hasImageLink ) {
Is it possible implement it into the Parsoid.
Regards Vadim
Hi Vadim,
We cannot guarantee Parsoid will continue to function with older MW versions. We have enough complexity as is and we do not intend to take on workarounds to deal with older MW versions.
That said, we are considering an option where you can "hack up" a base config file that you can use with your wiki that can fill in missing gaps in the API. This is at best a hack and no guarantees it will do what you need, but it could very well do the trick. See the discussion on https://gerrit.wikimedia.org/r/#/c/194030/ . We cannot work on this task on a high priority, but once done, this might help with some of the issues you are encountering.
Best, Subbu.
On 04/22/2015 10:56 AM, Vadim Shlyakhov wrote:
Hello,
Some older versions of Mediawiki (1.16) do not provide "mediatype" in "iiprop" for media. Then its worker crashes when it tries to parse a reply from a server.
Here is workaround for an issue:
--- ext.core.LinkHandler.js- 2015-04-22 15:30:04.000000000 +0300 +++ ext.core.LinkHandler.js 2015-04-22 17:03:11.000000000 +0300 @@ -1011,7 +1012,11 @@ // Add (read-only) information about original file size (T64881) img.addAttribute( 'data-file-width', info.width ); img.addAttribute( 'data-file-height', info.height );
img.addAttribute( 'data-file-type',info.mediatype.toLowerCase() );
if (info.mediatype) {img.addAttribute( 'data-file-type',info.mediatype.toLowerCase() );
}}
if ( hasImageLink ) {
Is it possible implement it into the Parsoid.
Regards Vadim
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Since this is a missing property in an imageinfo request, not missing mediawiki configuration information, I don't think https://gerrit.wikimedia.org/r/#/c/194030/ will help.
We should already have a loud warning at startup when you try to run Parsoid with an too-old mediawiki version. Perhaps that's too easily overlooked? Should we make Parsoid refuse to start instead? --scott
On Thu, Apr 23, 2015 at 12:49 PM, Subramanya Sastry ssastry@wikimedia.org wrote:
Hi Vadim,
We cannot guarantee Parsoid will continue to function with older MW versions. We have enough complexity as is and we do not intend to take on workarounds to deal with older MW versions.
That said, we are considering an option where you can "hack up" a base config file that you can use with your wiki that can fill in missing gaps in the API. This is at best a hack and no guarantees it will do what you need, but it could very well do the trick. See the discussion on https://gerrit.wikimedia.org/r/#/c/194030/ . We cannot work on this task on a high priority, but once done, this might help with some of the issues you are encountering.
Best, Subbu.
On 04/22/2015 10:56 AM, Vadim Shlyakhov wrote:
Hello,
Some older versions of Mediawiki (1.16) do not provide "mediatype" in "iiprop" for media. Then its worker crashes when it tries to parse a reply from a server.
Here is workaround for an issue:
--- ext.core.LinkHandler.js- 2015-04-22 15:30:04.000000000 +0300 +++ ext.core.LinkHandler.js 2015-04-22 17:03:11.000000000 +0300 @@ -1011,7 +1012,11 @@ // Add (read-only) information about original file size (T64881) img.addAttribute( 'data-file-width', info.width ); img.addAttribute( 'data-file-height', info.height );
img.addAttribute( 'data-file-type', info.mediatype.toLowerCase() );
if (info.mediatype) {img.addAttribute( 'data-file-type',info.mediatype.toLowerCase() );
}}
if ( hasImageLink ) {
Is it possible implement it into the Parsoid.
Regards Vadim
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitext-l
I looked into a more general way to patch your config in, https://gerrit.wikimedia.org/r/#/c/194030/ but, low and behold, there’s already a method to do it.
Set fetchConfig to false in your localsetting.js.
Then, assuming cruiserswiki as your prefix, (as in parsoidConfig.setInterwiki( 'cruiserswiki', 'http://www.cruiserswiki.org/api.php' );)
you’d add a cruiserswiki.json to /lib/baseconf/ and that should load it. https://github.com/wikimedia/parsoid/blob/master/lib/mediawiki.parser.enviro...
To get that cruiserswiki.json, curl "http://www.cruiserswiki.org/api.php?meta=siteinfo&format=json&action..." > cruiserswiki.json
Then you can add, "extensiontags": [ "<pre>", "<nowiki>", "<gallery>”, “<imagemap>" ],
for the <imagemap> as requested in, https://lists.wikimedia.org/pipermail/wikitext-l/2015-March/000931.html
Unfortunately, as cscott suggested, this doesn’t help the current mediatype issue. Sorry.
On Thursday, April 23, 2015 at 9:59 AM, C. Scott Ananian wrote:
Since this is a missing property in an imageinfo request, not missing mediawiki configuration information, I don't think https://gerrit.wikimedia.org/r/#/c/194030/ will help.
We should already have a loud warning at startup when you try to run Parsoid with an too-old mediawiki version. Perhaps that's too easily overlooked? Should we make Parsoid refuse to start instead? --scott
On Thu, Apr 23, 2015 at 12:49 PM, Subramanya Sastry <ssastry@wikimedia.org (mailto:ssastry@wikimedia.org)> wrote:
Hi Vadim,
We cannot guarantee Parsoid will continue to function with older MW versions. We have enough complexity as is and we do not intend to take on workarounds to deal with older MW versions.
That said, we are considering an option where you can "hack up" a base config file that you can use with your wiki that can fill in missing gaps in the API. This is at best a hack and no guarantees it will do what you need, but it could very well do the trick. See the discussion on https://gerrit.wikimedia.org/r/#/c/194030/ . We cannot work on this task on a high priority, but once done, this might help with some of the issues you are encountering.
Best, Subbu.
On 04/22/2015 10:56 AM, Vadim Shlyakhov wrote:
Hello,
Some older versions of Mediawiki (1.16) do not provide "mediatype" in "iiprop" for media. Then its worker crashes when it tries to parse a reply from a server.
Here is workaround for an issue:
--- ext.core.LinkHandler.js- 2015-04-22 15:30:04.000000000 +0300 +++ ext.core.LinkHandler.js 2015-04-22 17:03:11.000000000 +0300 @@ -1011,7 +1012,11 @@ // Add (read-only) information about original file size (T64881) img.addAttribute( 'data-file-width', info.width ); img.addAttribute( 'data-file-height', info.height );
- img.addAttribute( 'data-file-type', info.mediatype.toLowerCase() );
- if (info.mediatype) {
- img.addAttribute( 'data-file-type',
info.mediatype.toLowerCase() );
- }
}
if ( hasImageLink ) {
Is it possible implement it into the Parsoid.
Regards Vadim
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org (mailto:Wikitext-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org (mailto:Wikitext-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/wikitext-l
-- (http://cscott.net)
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org (mailto:Wikitext-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Thanks for suggestions.
I'll see what can be done in this situation and what can be kept as a separate patch set.
Apparently, the engine upgrade would be a best solution but it's still not a nearest option it this case.
On Fri, Apr 24, 2015 at 12:23 AM, Arlo Breault abreault@wikimedia.org wrote:
I looked into a more general way to patch your config in, https://gerrit.wikimedia.org/r/#/c/194030/ but, low and behold, there’s already a method to do it.
Set fetchConfig to false in your localsetting.js.
Then, assuming cruiserswiki as your prefix, (as in parsoidConfig.setInterwiki( 'cruiserswiki', ' http://www.cruiserswiki.org/api.php' );)
you’d add a cruiserswiki.json to /lib/baseconf/ and that should load it.
https://github.com/wikimedia/parsoid/blob/master/lib/mediawiki.parser.enviro...
To get that cruiserswiki.json, curl " http://www.cruiserswiki.org/api.php?meta=siteinfo&format=json&action..."
cruiserswiki.json
Then you can add, "extensiontags": [ "<pre>", "<nowiki>", "<gallery>”, “<imagemap>" ],
for the <imagemap> as requested in, https://lists.wikimedia.org/pipermail/wikitext-l/2015-March/000931.html
Unfortunately, as cscott suggested, this doesn’t help the current mediatype issue. Sorry.
On Thursday, April 23, 2015 at 9:59 AM, C. Scott Ananian wrote:
Since this is a missing property in an imageinfo request, not missing mediawiki configuration information, I don't think https://gerrit.wikimedia.org/r/#/c/194030/ will help.
We should already have a loud warning at startup when you try to run Parsoid with an too-old mediawiki version. Perhaps that's too easily overlooked? Should we make Parsoid refuse to start instead? --scott
On Thu, Apr 23, 2015 at 12:49 PM, Subramanya Sastry <ssastry@wikimedia.org (mailto:ssastry@wikimedia.org)> wrote:
Hi Vadim,
We cannot guarantee Parsoid will continue to function with older MW versions. We have enough complexity as is and we do not intend to take
on
workarounds to deal with older MW versions.
That said, we are considering an option where you can "hack up" a base config file that you can use with your wiki that can fill in missing
gaps in
the API. This is at best a hack and no guarantees it will do what you
need,
but it could very well do the trick. See the discussion on https://gerrit.wikimedia.org/r/#/c/194030/ . We cannot work on this
task on
a high priority, but once done, this might help with some of the
issues you
are encountering.
Best, Subbu.
On 04/22/2015 10:56 AM, Vadim Shlyakhov wrote:
Hello,
Some older versions of Mediawiki (1.16) do not provide "mediatype" in "iiprop" for media. Then its worker crashes when it tries to parse a
reply
from a server.
Here is workaround for an issue:
--- ext.core.LinkHandler.js- 2015-04-22 15:30:04.000000000 +0300 +++ ext.core.LinkHandler.js 2015-04-22 17:03:11.000000000 +0300 @@ -1011,7 +1012,11 @@ // Add (read-only) information about original file size (T64881) img.addAttribute( 'data-file-width', info.width ); img.addAttribute( 'data-file-height', info.height );
- img.addAttribute( 'data-file-type', info.mediatype.toLowerCase() );
- if (info.mediatype) {
- img.addAttribute( 'data-file-type',
info.mediatype.toLowerCase() );
- }
}
if ( hasImageLink ) {
Is it possible implement it into the Parsoid.
Regards Vadim
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org (mailto:Wikitext-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org (mailto:Wikitext-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/wikitext-l
-- (http://cscott.net)
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org (mailto:Wikitext-l@lists.wikimedia.org) https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Wikitext-l mailing list Wikitext-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitext-l
Thanks again, Arlo -- this worked very well!
On Fri, Apr 24, 2015 at 12:23 AM, Arlo Breault abreault@wikimedia.org wrote:
I looked into a more general way to patch your config in, https://gerrit.wikimedia.org/r/#/c/194030/ but, low and behold, there’s already a method to do it.
Set fetchConfig to false in your localsetting.js.
Then, assuming cruiserswiki as your prefix, (as in parsoidConfig.setInterwiki( 'cruiserswiki', ' http://www.cruiserswiki.org/api.php' );)
you’d add a cruiserswiki.json to /lib/baseconf/ and that should load it.
https://github.com/wikimedia/parsoid/blob/master/lib/mediawiki.parser.enviro...
To get that cruiserswiki.json, curl " http://www.cruiserswiki.org/api.php?meta=siteinfo&format=json&action..."
cruiserswiki.json
Then you can add, "extensiontags": [ "<pre>", "<nowiki>", "<gallery>”, “<imagemap>" ],
for the <imagemap> as requested in, https://lists.wikimedia.org/pipermail/wikitext-l/2015-March/000931.html
Unfortunately, as cscott suggested, this doesn’t help the current mediatype issue. Sorry.
wikitext-l@lists.wikimedia.org