yup, you were right. I started working on blockpageschecker.py, doing some local tests, then gave up changing my mind. And I committed the patch forgetting to revert my changes :)
Thanks !
2008/6/15 Merlijn van Deen valhallasw@arctus.nl:
On Sun, June 15, 2008 6:35 pm, nicdumz@svn.wikimedia.org wrote:
Log Message:
Patch #1994318 by lin4h [update for Locale ja,zh and namespace, obsolete info...etc]
All files, except blockpageschecker.py, are translation diffs, while blockpageschecker.py has a code change. Was this meant?
If so, please consider multiple commits: for example in this case one for the translations, one for the wiki closures and one for the code change. In this case, combining the translations and closures is useful because they are mixed up in some files. However, the code change is completely unrelated, so a separate commit would be more logical.
If not, please check if the code is correct ;)
--valhallasw
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l