Am Samstag 16 Februar 2008 13:52:25 schrieb rotem@svn.wikimedia.org:
Revision: 5038 --- trunk/pywikipedia/wikipedia.py 2008-02-16 11:09:47 UTC (rev 5037) +++ trunk/pywikipedia/wikipedia.py 2008-02-16 12:52:25 UTC (rev 5038)
- # There's no possibility to read the wpStarttime argument from the XML.
- # It is this time that the MediaWiki software uses to check for edit
- # conflicts. We take the earliest time later than the last edit, which
- # seems to be the safest possible time.
- page2._startTime = str(int(timestamp)+1)
- # This is used for checking deletion conflict.
- # Use the data loading time.
- page2._startTime = time.strftime('%Y%m%d%H%M%S', time.gmtime())
Hi Rotem,
Are you sure this is a good idea? I think this is potentially hazardous, as the bot will not cause edit conflicts (but instead just overwrite the latest change) when the local system time is not correct.
I think we had this local-time approach before, and Andre Engels found the better solution of using the last edit's timestamp.
Daniel