You also have the option of not using git-review. I don't.
-Chad On Oct 6, 2013 11:23 AM, "Strainu" strainu10@gmail.com wrote:
2013/10/6 Dr. Trigon dr.trigon@surfeu.ch:
I was not there - but you should not simply neglect that there are serious issues with git under win. Please ask e.g. Xqt - as far as I know he was not able to set-up a properly working system for git review under win until today... which means we have lost one of our best and hardest-working developers just because git migration... that is bad!!
Gerrit has a bad reputation, and seemingly well deserved. Just yesterday, Andrew Klapper was asking in a bug a submitted if the pywikibot would not prefer getting patches in gerrit directly and I was like "oh God, plese don't let that happen" :)
But if the review is the major problem on Windows, why not go with github? There you can do basically everything online, including applying patches. There is even something called "Github for Windows [and/or Mac]" [1], which if I understand correctly is basically a git client. If Xqt, or anyone else for that matter, can submit on their local git branch, it should be fairly trivial to implement "reviews" as pull requests merged by someone elese that the submitter.
Sure, this would mean separating from the WMF "infrastructure" and I know a few people who would hate that, but for me, this is the smart thing to do. What do you think?
[1] http://windows.github.com/
To make it clear I personally would like to just forget about win - but that is not very clever, even more since we had a hard time during git migration just to keep all the stuff running for win users. To me it looks very like MWF did forget about win developers...
Just to have this mentioned once more - you all know that there is still the possibility to checkout the code by svn (thanks to github)! Please confer [1] as all git repos are mirrored to github and they allow also svn access to the data. Hope this helps for regular users.
[1] https://github.com/search?q=%40wikimedia+pywikibot
Greetings DrTrigon -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlJRMZsACgkQAXWvBxzBrDCx8QCgj+l08M7D0Y6lvHcCOLDtjJLn mlUAn3RxKdp2+FEpQl7ohTq+aYBxEhtL =4Rof -----END PGP SIGNATURE-----
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l