----- Original Nachricht ---- Von: "Dr. Trigon" dr.trigon@surfeu.ch An: pywikipedia-l@lists.wikimedia.org Datum: 02.08.2013 12:19 Betreff: Re: [Pywikipedia-l] Question about externals and patches
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01.08.2013 14:02, info@gno.de wrote:
As we discussed several times some bot operators do not like having .exe files executed without explicit permission to do it.
I understand this! Thats the reason why you're are asked for permission before the install starts. What should be done else? A value in user-config.py? Another question just for patch? This exclicit .exe file is open-source so you can look at the source code if you expect it to do harm. What can I do else? What would you like to see?
Asking for running the .exe file is ok for me but you should not ask for this permission multiple times (I got it twice). And there should be a warning that several scripts fail if some modules are not installed as needed.
In my opinion it is not a good solution blocking the bot now if the permission is denied because the bot worked 10 years ago without this permission and patching beautifullsoup. That library was included to our code since the first steps of pwb. Where are the problems to include them or what are the licenses problems? Maybe you are right and we did wrong in past. And what are the special necessity for that patch? Externals can be included without running patch.exe. But I do not understand them. I understood that patch as a sample for that technoloy which should be used when needed. Now I only see the exception raising while starting any script of the framework (which was few days ago and not some months behind. Sorry I am not up to day while testing ;) Ok this behaviour seems a good way to let the trunk/compat branch die in honest. In this respect I am with you :D
You are right for the specific case of beautifulsoup.py the patch is not NEEDED it just re-establishes the state we had, with some minor changes done to "our" beautifulsoup.py - but as you said they are not important, thus this patch can be removed. Downloading (everything else except patching) is fine for you?
Yes please for this plate of beautifullsoup because it is essential for this branch of the framework. Otherwise the bot is blocked for all scripts. And I would be glad seeing my pep8 changes reverted :)
Other comments for this threat may follow...
Greetings
xqt