-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
This is the first step of the transition to a "slightly" changed externals handling. As explained in [1] and [2] "patch.exe" is needed for the win users - linux OS do usualy already include "patch".
[1] http://lists.wikimedia.org/pipermail/pywikipedia-l/2013-July/007931.html [2] http://www.mediawiki.org/w/index.php?title=Special:Code/pywikipedia/11711
The download SHOULD not take place without explicit question to the user. This was a bug and was solved in [3], please update if needed.
[3] www.mediawiki.org/wiki/Special:Code/pywikipedia/11731
The reason for all this is, that we use external code from other projects/sources, as e.g. "BeautifulSoup.py", but also others. Most of them used by 2 of my bots (subster.py and catimages.py). What I implemented is an automatic check and install system for missing dependencies in externals/__init__.py. This system is able to install exactly the version requested by us the developers and allows to apply patches to the code if needed - in order to have maximal flexibility. It can make use of the linux OS package management or directly download the code from a defined location. More up to come.
The question whether this is the best solution possible should be discussed. As I see it yes, because we do not need to fork all those projects and then maintain (update and merge) all the code all the time. I consider this as sub-optimal because of the additional workload produced. But if somebody has a good idea or can explain me how to do this properly, please step forward! I am NOT an expert, especially in git and there might be better solutions.
At the current stage just downloading of "patch.exe" for win users is activated. The next step from my side - if everybody agrees - would be to activate this system for BeautifulSoup.py for further testing. This would mean that BeautifulSoup.py would be removed from our repo and in future be automatically downloaded (after a question to the user) at the first run.
Greetings and I looking forward to all your feedback DrTrigon
On 09.07.2013 00:07, BinĂ¡ris wrote:
Things go worse and worse in the last days. First SVN errors, then change of textlib.py killed my script, and the newest, when running replace.py:
WARNING: Download package "patch.exe" from http://downloads.sourceforge.net/project/gnuwin32/patch/2.5.9-7/patch-2.5.9-...
What is this? Why should I download it? Why did my bot stop, when it worked normally a few days ago? What did I harm to the world?