I need to add what Merlijn said is correct for any kind of patch submitting. For example if you're using linux and you want to amend a patch you just need to change it and "git add file.py" and "git commit" and add change id to commit summary and "git review -R" and it'll be done!
Best On Nov 21, 2013 11:22 AM, "Merlijn van Deen" valhallasw@arctus.nl wrote:
Hi xqt,
Yes, but it's not as easy as I would like it to be. The trick is to add the Change-Id line from the previous patchset commit message to the new commit message. So if you want to add a new patch to https://gerrit.wikimedia.org/r/#/c/96693/, fill in the patch uploader as usual, but add
Change-Id: I0c31cd68dc372ed38f461e430c135350a1581828 https://gerrit.wikimedia.org/r/#q,I0c31cd68dc372ed38f461e430c135350a1581828,n,z
to the bottom of the commit message field.
Hope this helps, Merlijn
On 21 November 2013 08:21, info@gno.de wrote:
Hi Merlijn,
is there any possibility to amend a commit to a given review via gerrit patch uploader? This may be important for our Google Code-In participants.
Greetings
xqt
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
Pywikipedia-l mailing list Pywikipedia-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l