2016-08-08 7:58 GMT+02:00 info info@gno.de:
I don't call you but I am sorry for missing explanation. +2 is the review right to merge a patch whereas -2 blocks a patch. -1 means there is a problem to be solved and +1 means the patch looks good but another must review.
Here: https://gerrit.wikimedia.org/r/#/c/306409/ I see that jenkins-bot gave a +2. So the bot has the right to do it? In which cases?
There is a difference between code review and code verify flag. The verify flag is set by the autoreviewer jenkins-bot after some automatic tests are done. There are some syntactical and style checks but also some code checks which are automatically done after a new patch is uploaded and also when a patch ready to merged into the branch by a code reviewer flag CR+2.
see: https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_code_is_reviewed_in_Gerri...
-- Bináris
Best
Xqt