First of all, you, Alex, should try to resolve pending problems about
your previous commits. Anyway...
alexsh(a)svn.wikimedia.org ha scritto:
> Revision: 6950
> Author: alexsh
> Date: 2009-06-11 16:46:35 +0000 (Thu, 11 Jun 2009)
>
> Log Message:
> -----------
> Fix:cannot locate password files if running script in subfolder
"login.py: Open password file even if the script haven't run from base
directory"?
[...]
> Log Message:
> -----------
> Typo: cannot use double slash in unix...XDrz
...And what "XDrz" stand for?
3 consecutive commits for a bugfix aren't so much good.
Proper procedure should be this (for non-trivial changes or files
created by you self, common-sense based):
1. Post patch in mailing-list (I prefer here instead of using the stupid
patch tracker).
A message like:
Subject: [PATCH] Descriptive title
Optional long description or commit message
[patch attached]
2. Wait for comments
3. If changes are required, post again a new patch
4. See 2, then commit.
--
Francesco Cosoleto
"Noi esercitiamo il potere con l'amore, non con le armi" (J. P.
Goebbels, ministro della cultura del governo nazionalsocialista tedesco,
1936)
When running one of the scripts from "tests" folder or a custom script I
get:
<------------------------------------------CODE
BEGIN--------------------------------------------------------------->
E:\Workspaces\pybot\tests>api_tests.py
Configuration variable 'retry_on_fail' is defined but unknown. Misspelled?
Configuration variable 'use_diskcache' is defined but unknown. Misspelled?
EF:\Python26\lib\site-packages\httplib2-0.4.0-py2.6.egg\httplib2\__init__.py:29:
DeprecationWarning: the md5 module is deprecated; use hashlib instead
F:\Python26\lib\site-packages\httplib2-0.4.0-py2.6.egg\httplib2\__init__.py:44:
DeprecationWarning: the sha module is deprecated; use the hashlib module
instead
Found 1 wikipedia:en processes running, including this one.
ERROR: Traceback (most recent call last):
File "E:\Workspaces\pybot\pywikibot\data\api.py", line 208, in submit
body=params)
File "E:\Workspaces\pybot\pywikibot\comms\http.py", line 112, in request
raise request.data
TypeError: a float is required
WARNING: Waiting 5 seconds before retrying.
ERROR: Traceback (most recent call last):
File "E:\Workspaces\pybot\pywikibot\data\api.py", line 208, in submit
body=params)
File "E:\Workspaces\pybot\pywikibot\comms\http.py", line 112, in request
raise request.data
TypeError: a float is required
WARNING: Waiting 10 seconds before retrying.
<------------------------------------------CODE
END--------------------------------------------------------------->
Any ideas why?
I'll try replace.py later and post back.
(Trsnalate by Philip and google translate)
Dear all:
Since NicDumZ noticed me at my talk page, I have concerned about the current problems continued.(I'm not good at English, but I have made my effort to understand) Sometimes I do not comment as yours, because I don't know how to speak out in English.
Since I got my own pybot running, involved in the program development of PyWikipedia, then got a commit authority, I have always felt what I intend is to make pywikipedia better, more efficient, higher compatibility with our Wikimedia project, and to make it less with bugs.
Even though I'm not a good speaker, I feel like I should apologize for my actions and those distresses caused by me. I should not practice these commits before a complete understanding of here's routines.
Next, I would like to explain some commit about global bot flag:
*The original idea from I got the global flag, and when I use pywikipedia, it always said I don't have flag.Another problem is there are too many user-setting in user-config.py, and very hard to manage them. So I think if I set a variable in families to mark allowed global bot and write some determines to check if the language is allowed, I can make easier to use pybot.
And if I can set one bot account name is user-config, I hope I can use it in all projects with allowed global bot flag.(It's not done yet, I only pre-set a boolean variable in config.py)
------
Alex Shih-Han Lin
(I don't know why the mailing-list only show alexsh...The optional name I set is this name)
On Thu, June 11, 2009 4:56 am, alexsh(a)svn.wikimedia.org wrote:
> Revision: 6949
> Author: alexsh
> Date: 2009-06-11 02:56:44 +0000 (Thu, 11 Jun 2009)
>
> Log Message:
> -----------
> * wikimedia_sites.py: add wikiversity info
> * speedy_delete.py:
> - update wikipedia and wikinews categories from [[en:C:CSD]] interwiki
> - add wikt, ws, wb, wv, wq categories from en interwiki
> - add KeyboardInterrupt exception to quit program when no data in CSD
> category.
Please try to split commits if they are not related. In this case,
splitting into two (the site data and the KeyboardInterrupt) or three
(wikiversity, categories and KeyboardInterrupt) would have been better.
Thanks!
-valhallasw
Your report looks like this:
https://sourceforge.net/tracker/?func=detail&aid=2800795&group_id=93107&ati…
I suggest you can add those messages to your pybot copies, make a diff patch and upload to tracker, it can let us commit your messages more easier and faster.
※ 引述《"Jan Dudík" <jan.dudik(a)gmail.com>》之郵件內容：
>Hello,
>I would to know if is posible for me to change some files on svn. I
>sumbitted some translation requests, but it takes long time to add
>them to svn versions. So I want to can submit it myself
>
>JAn Dudík (JAnDbot)
>
--Alex Shih-Han Lin, alexsh in wikimedia.
lin4h in sf.net and using Alexbot in wikimedia.
First time send the mail to mailing list, sry for poor English.
Hello,
I would to know if is posible for me to change some files on svn. I
sumbitted some translation requests, but it takes long time to add
them to svn versions. So I want to can submit it myself
JAn Dudík (JAnDbot)
2009/6/10 <alexsh(a)svn.wikimedia.org>:
> Revision: 6946
> Author: alexsh
> Date: 2009-06-09 18:22:04 +0000 (Tue, 09 Jun 2009)
>
> Log Message:
> -----------
> *config.py
> -preSet globalAccount flag
> -remove no use comment.
> *family.py
> -add cross_allowed for global bot flag
> -update ns-info by update_namespaces.py
> *families
> -add allowed languages
> -update ns-info by update_namespaces.py
> -fix oldwikisource link faild when SSL
> *login.py:typo
> *spamremove.py:typo for syntax in msgs
> *speedy_delete.py:add new template for zhwiki
> *wikipedia.py
> -site._getUserData:detect global bot flag.
> -translate: add keyword "_default"
> -output: ignore print_stack raise None when OS in windows
>
Come on Alex, even the commit message is barely readable. Do you
realize that no-one will be able to review your changes because they
are too many of them?
Because no one can reasonably take the time to review such a _huge_
changeset, it is only a loss of time:
* If we don't review it, it might include lots of errors, and we will
lose time fixing mistakes later
* If someone takes time to understand all your changes, he'll lose an
important part of his time...
You should _really_ commit each feature separately. Commit often.
Commit small, consistent bits. A small patch can be reviewed in 10
seconds, it barely takes time.
Do not commit Huge patches every week, with multiple features. This is a pain.
And subscribe to pywikipedia-l. (forwarding to his zh userpage)
--
Nicolas Dumazet — NicDumZ [ nɪk.d̪ymz ]
alexsh(a)svn.wikimedia.org ha scritto:
> Revision: 6946
> Author: alexsh
> Date: 2009-06-09 18:22:04 +0000 (Tue, 09 Jun 2009)
>
> Log Message:
> -----------
> *config.py
> -preSet globalAccount flag
> -remove no use comment.
> *family.py
> -add cross_allowed for global bot flag
> -update ns-info by update_namespaces.py
> *families
> -add allowed languages
> -update ns-info by update_namespaces.py
> -fix oldwikisource link faild when SSL
> *login.py:typo
> *spamremove.py:typo for syntax in msgs
> *speedy_delete.py:add new template for zhwiki
> *wikipedia.py
> -site._getUserData:detect global bot flag.
> -translate: add keyword "_default"
> -output: ignore print_stack raise None when OS in windows
>
> Modified Paths:
> --------------
> trunk/pywikipedia/config.py
> trunk/pywikipedia/families/wikipedia_family.py
> trunk/pywikipedia/families/wikiquote_family.py
> trunk/pywikipedia/families/wikisource_family.py
> trunk/pywikipedia/families/wikiversity_family.py
> trunk/pywikipedia/families/wiktionary_family.py
> trunk/pywikipedia/family.py
> trunk/pywikipedia/login.py
> trunk/pywikipedia/spamremove.py
> trunk/pywikipedia/speedy_delete.py
> trunk/pywikipedia/wikipedia.py
I don't want see this kind of commit.
People join us should learn how use SVN and work in a team.
Francesco
alexsh(a)svn.wikimedia.org ha scritto:
> Revision: 6917
> Author: alexsh
> Date: 2009-05-24 13:19:09 +0000 (Sun, 24 May 2009)
>
> Log Message:
> -----------
> *optimize wikiversity url when using SSL connection
> *Fix secure url faild in oldwikisource and SSL connection
> *Add progress shortcut for redirect.py (double->do, broken->br)
> *Other syntax fix and comments in watchlist.py and login.py
>
> Modified Paths:
> --------------
> trunk/pywikipedia/families/wikisource_family.py
> trunk/pywikipedia/families/wikiversity_family.py
> trunk/pywikipedia/login.py
> trunk/pywikipedia/redirect.py
> trunk/pywikipedia/watchlist.py
I am going to revert this as explained in mailing-list a lot of days ago.
--
Francesco Cosoleto
What gets us into truoble is not what we don't know. It's what we know
for sure that just ain't so. (Mark Twain)