jenkins-bot has submitted this change and it was merged.
Change subject: Remove unnecessary commented out code re eo.wp ......................................................................
Remove unnecessary commented out code re eo.wp
Since 2010, the HTML ' (') is ignored for all sites with a comment that indicates mediawiki bug 24093 is the reason.
Before that, eo.wp had ' on its ignore list with a comment indicating this diff was the reason: https://eo.wikipedia.org/w/index.php?title=Liberec&diff=next&oldid=2...
When this hex code was added to the global ignore list, the eo.wp rule was commented out. https://mediawiki.org/wiki/Special:Code/pywikipedia/8314
This changeset removes the commented out old rule, as it is unlikely to be reinstated or needed. Documentation of these rules should be on the wiki, and test cases should exist to ensure site-specific issues raised in the past are not regressed.
Change-Id: Idec1eb9af527d6a812631dd13a9b1fcf151f03f6 --- M scripts/cosmetic_changes.py 1 file changed, 1 insertion(+), 4 deletions(-)
Approvals: John Vandenberg: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/cosmetic_changes.py b/scripts/cosmetic_changes.py index 33ae271..472535b 100755 --- a/scripts/cosmetic_changes.py +++ b/scripts/cosmetic_changes.py @@ -515,7 +515,7 @@ def resolveHtmlEntities(self, text): ignore = [ 38, # Ampersand (&) - 39, # Bugzilla 24093 + 39, # Single quotation mark (") - Bugzilla 24093 60, # Less than (<) 62, # Great than (>) 91, # Opening bracket - sometimes used intentionally inside links @@ -526,9 +526,6 @@ 8206, # left-to-right mark (<r;) 8207, # right-to-left mark (&rtl;) ] - # ignore ' see https://eo.wikipedia.org/w/index.php?title=Liberec&diff=next&oldid=2... - #if self.site.lang == 'eo': - # ignore += [39] if self.template: ignore += [58] text = pywikibot.html2unicode(text, ignore=ignore)