jenkins-bot has submitted this change and it was merged.
Change subject: running pylint on the code ......................................................................
running pylint on the code
Change-Id: I94f96b452d5dd5abb4b325cd3ee9396167cd1d04 Signed-off-by: James Michael DuPont jamesmikedupont@gmail.com --- M pywikibot/botirc.py M pywikibot/login.py M pywikibot/pagegenerators.py 3 files changed, 18 insertions(+), 16 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/botirc.py b/pywikibot/botirc.py index bda0284..48e7f4d 100644 --- a/pywikibot/botirc.py +++ b/pywikibot/botirc.py @@ -7,7 +7,7 @@ """ # # (C) Balasyum -# (C) Pywikipedia bot team, 2008-2012 +# (C) Pywikipedia bot team, 2008-2013 # # Distributed under the terms of the MIT license. # @@ -18,18 +18,16 @@ # scripts, instead of writing each one from scratch.
-import logging import logging.handlers # all output goes thru python std library "logging" module import re
from ircbot import SingleServerIRCBot -from irclib import nm_to_n, nm_to_h, irc_lower, ip_numstr_to_quad -from irclib import ip_quad_to_numstr +from irclib import nm_to_n
-# logging levels _logger = "botirc"
+# logging levels from logging import DEBUG, INFO, WARNING, ERROR, CRITICAL STDOUT = 16 VERBOSE = 18 @@ -60,7 +58,8 @@ self.channel = channel self.site = site self.other_ns = re.compile( - u'14[[07(' + u'|'.join([item[0] for item in site.namespaces().values() if item[0]]) + u')') + u'14[[07(' + u'|'.join([item[0] for item in + site.namespaces().values() if item[0]]) + u')') self.api_url = self.site.family.apipath(self.site.lang) self.api_url += '?action=query&meta=siteinfo&siprop=statistics&format=xml' self.api_found = re.compile(r'articles="(.*?)"') @@ -79,9 +78,9 @@ def on_pubmsg(self, c, e): match = self.re_edit.match(e.arguments()[0]) if not match: - return + return if not ('N' in match.group('flags')): - return + return try: msg = unicode(e.arguments()[0], 'utf-8') except UnicodeDecodeError: @@ -93,11 +92,11 @@ entry = self.api_found.findall(text) page = pywikibot.Page(self.site, name) try: - text = page.get() + text = page.get() except pywikibot.NoPage: - return + return except pywikibot.IsRedirectPage: - return + return pywikibot.output(str((entry[0], name)))
def on_dccmsg(self, c, e): diff --git a/pywikibot/login.py b/pywikibot/login.py index 872ad68..f73f544 100644 --- a/pywikibot/login.py +++ b/pywikibot/login.py @@ -11,7 +11,6 @@ # __version__ = '$Id$'
-import logging import pywikibot from pywikibot import config, deprecate_arg from pywikibot.exceptions import NoSuchSite, NoUsername @@ -46,7 +45,8 @@ self.username = user elif sysop: try: - self.username = config.sysopnames[self.site.family.name][self.site.code] + self.username = config.sysopnames[ + self.site.family.name][self.site.code] except KeyError: raise NoUsername( u"""ERROR: Sysop username for %(fam_name)s:%(wiki_code)s is undefined. @@ -57,7 +57,8 @@ 'wiki_code': self.site.code}) else: try: - self.username = config.usernames[self.site.family.name][self.site.code] + self.username = config.usernames[ + self.site.family.name][self.site.code] except: raise NoUsername( u"""ERROR: Username for %(fam_name)s:%(wiki_code)s is undefined. @@ -77,7 +78,8 @@ """ if self.site.family.name in botList \ and self.site.code in botList[self.site.family.name]: - botListPageTitle, botTemplate = botList[self.site.family.name][self.site.code] + botListPageTitle, botTemplate = botList[ + self.site.family.name][self.site.code] botListPage = pywikibot.Page(self.site, botListPageTitle) if botTemplate: for template in botListPage.templatesWithParams(): diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index 50fd0d7..a7b8fe3 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -20,10 +20,11 @@ __version__ = '$Id$'
import re -import sys import codecs import itertools import pywikibot +import time +import date from pywikibot import config from pywikibot import deprecate_arg, i18n