jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/585005 )
Change subject: [tests] use TestCase for TestPermalink and TestShortLink ......................................................................
[tests] use TestCase for TestPermalink and TestShortLink
- Use TestCase in favour of DefaultSiteTestCase for TestPermalink and TestShortLink. family and code attributes is not used with DefaultSiteTestCase except override_default_site method is called explicitly.
This should solve failing TestShortLink due to not logged in user.
Change-Id: Ic6bef4359a12aef330a88015a226e496928048ec --- M tests/page_tests.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/page_tests.py b/tests/page_tests.py index aba1db4..8201445 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -1177,7 +1177,7 @@ self.assertEqual(pywikibot.page.html2unicode('py'), 'py')
-class TestPermalink(DefaultSiteTestCase): +class TestPermalink(TestCase): """Test that permalink links are correct."""
family = 'wikipedia' @@ -1201,7 +1201,7 @@ 'Framawiki%2Fpwb_tests%2Fpermalink&oldid=340685')
-class TestShortLink(DefaultSiteTestCase): +class TestShortLink(TestCase): """Test that short link management is correct."""
user = True