jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1007387?usp=email )
Change subject: [bugfix] remove content parameter of ItemPage.page_gen method ......................................................................
[bugfix] remove content parameter of ItemPage.page_gen method
The filter needs the page.text and the text is preloaded Page for page already. Now always use the site.preload method to bulk load the content.
Bug: T358635 Change-Id: I62dca5845492a636cf556761d95bde5f5210d9f8 --- M pywikibot/proofreadpage.py 1 file changed, 22 insertions(+), 10 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py index 2df5eb1..e5dc94d 100644 --- a/pywikibot/proofreadpage.py +++ b/pywikibot/proofreadpage.py @@ -47,7 +47,7 @@ from pywikibot.data.api import ListGenerator, Request from pywikibot.exceptions import Error, InvalidTitleError, OtherPageSaveError from pywikibot.page import PageSourceType -from pywikibot.tools import MediaWikiVersion, cached +from pywikibot.tools import MediaWikiVersion, cached, remove_last_args
try: @@ -1305,12 +1305,13 @@ """ return len(self._page_from_numbers)
- def page_gen(self, start: int = 1, - end: int | None = None, - filter_ql: Sequence[int] | None = None, - only_existing: bool = False, - content: bool = True - ) -> Iterable[pywikibot.page.Page]: + @remove_last_args(['content']) # since 9.0.0 + def page_gen( + self, start: int = 1, + end: int | None = None, + filter_ql: Sequence[int] | None = None, + only_existing: bool = False + ) -> Iterable[pywikibot.page.Page]: """Return a page generator which yields pages contained in Index page.
Range is [start ... end], extremes included. @@ -1324,7 +1325,6 @@ :param filter_ql: filters quality levels if None: all but 'Without Text'. :param only_existing: yields only existing pages. - :param content: preload content. """ if end is None: end = self.num_pages @@ -1346,8 +1346,7 @@ gen = [(self.get_number(p), p) for p in gen] gen = [p for n, p in sorted(gen)]
- if content: - gen = self.site.preloadpages(gen) + gen = self.site.preloadpages(gen) # Filter by QL. gen = (p for p in gen if p.ql in filter_ql) # Yield only existing.