Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/771901 )
Change subject: [IMPR] Improvements for using site.proofread_levels ......................................................................
[IMPR] Improvements for using site.proofread_levels
- use list(site.proofread_levels) instead of site.proofread_levels.keys when printing so see a list instead a dict_keys view - use list(site.proofread_levels) instead of list(site.proofread_levels.keys()) which gives the same result
Change-Id: Ic5f33615dfe96333fb629e28c25bf2f17a6ef20c --- M pywikibot/proofreadpage.py 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: Mpaa: Looks good to me, approved Xqt: Verified; Looks good to me, approved
diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py index 4c03176..6ea2ad1 100644 --- a/pywikibot/proofreadpage.py +++ b/pywikibot/proofreadpage.py @@ -209,10 +209,10 @@ raise ValueError('Page {} must belong to {} namespace' .format(self.title(), site.proofread_page_ns)) # Ensure that constants are in line with Extension values. - if list(self.site.proofread_levels.keys()) != self.PROOFREAD_LEVELS: + level_list = list(self.site.proofread_levels) + if level_list != self.PROOFREAD_LEVELS: raise ValueError('QLs do not match site values: {} != {}' - .format(self.site.proofread_levels.keys(), - self.PROOFREAD_LEVELS)) + .format(level_list, self.PROOFREAD_LEVELS))
self._base, self._base_ext, self._num = self._parse_title() self._multi_page = self._base_ext in self._MULTI_PAGE_EXT @@ -350,7 +350,7 @@ def ql(self, value: int) -> None: if value not in self.site.proofread_levels: raise ValueError('Not valid QL value: {} (legal values: {})' - .format(value, self.site.proofread_levels)) + .format(value, list(self.site.proofread_levels))) # TODO: add logic to validate ql value change, considering # site.proofread_levels. self._full_header.ql = value @@ -375,7 +375,7 @@ except KeyError: pywikibot.warning('Not valid status set for {}: quality level = {}' .format(self.title(as_link=True), self.ql)) - return None + return None
def without_text(self) -> None: """Set Page QL to "Without text".""" @@ -1024,7 +1024,7 @@
# All but 'Without Text' if filter_ql is None: - filter_ql = list(self.site.proofread_levels.keys()) + filter_ql = list(self.site.proofread_levels) filter_ql.remove(ProofreadPage.WITHOUT_TEXT)
gen = (self.get_page(i) for i in range(start, end + 1))