jenkins-bot has submitted this change and it was merged.
Change subject: replace.py: use keyword args for explicitly in save() ......................................................................
replace.py: use keyword args for explicitly in save()
Use keywords arguments explicitly in save(). It might create conflicts when Page is subclassed and *args, **kwargs are used when overriding save() method.
See e.g. ProofreadPage.save() method.
Change-Id: I05763aa4f5c0e49b69c2a00ecd6b278aa9c82255 --- M scripts/replace.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/replace.py b/scripts/replace.py index 2ccebd4..8fd216d 100755 --- a/scripts/replace.py +++ b/scripts/replace.py @@ -755,7 +755,7 @@ self.options['always'] = True if choice == 'y': page.text = new_text - page.save(self.generate_summary(applied), async=True, + page.save(summary=self.generate_summary(applied), async=True, callback=self._count_changes, quiet=True) while not self._pending_processed_titles.empty(): proc_title, res = self._pending_processed_titles.get() @@ -766,7 +766,7 @@ if self.getOption('always') and new_text != original_text: try: page.text = new_text - page.save(self.generate_summary(applied), + page.save(summary=self.generate_summary(applied), callback=self._count_changes, quiet=True) except pywikibot.EditConflict: pywikibot.output(u'Skipping %s because of edit conflict'