jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337768 )
Change subject: test_cleanUpLinks_pipes: Expect uppercase first letter ......................................................................
test_cleanUpLinks_pipes: Expect uppercase first letter
The first letter of link targets is capitalized when appropriate for de:wikipedia.[1] TestCosmeticChanges is perfomed on de:wikipedia.[2] Therefore it should be expected to have an uppercase letter in this case which is a method of a sub-class of TestCosmeticChanges.
[1]: https://goo.gl/QdULBb [2]: https://goo.gl/YAfB6y
Bug: T158050 Change-Id: I92159e61156a06ca9b7ad82fecd1df3572ef4b06 --- M tests/cosmetic_changes_tests.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved
diff --git a/tests/cosmetic_changes_tests.py b/tests/cosmetic_changes_tests.py index 6a7112d..cc3947c 100644 --- a/tests/cosmetic_changes_tests.py +++ b/tests/cosmetic_changes_tests.py @@ -247,7 +247,7 @@
def test_cleanUpLinks_pipes(self): """Test cleanUpLinks method.""" - self.assertEqual('[[no|no change]]', + self.assertEqual('[[No|no change]]', self.cct.cleanUpLinks('[[no|no change]]')) self.assertEqual('[[title]]', self.cct.cleanUpLinks('[[title|title]]'))