jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/639088 )
Change subject: [bugfix] Fix get_known_families() for wikipedia_family ......................................................................
[bugfix] Fix get_known_families() for wikipedia_family
get_known_families() never worked for wikipedia_family because a site delegates that call to family with site.code as parameter and not by the site itself.
The get_known_families function is already desupported and should be removed but for full functionality of site.interwiki() method it should support AutoFamily first which is proposed with https://gerrit.wikimedia.org/r/c/pywikibot/core/+/584919
Bug: T267196 Change-Id: If3fd4fcbf092ebcf6bf808449d14b8a0d7c22704 --- M pywikibot/families/wikipedia_family.py M pywikibot/family.py 2 files changed, 5 insertions(+), 5 deletions(-)
Approvals: Hazard-SJ: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/families/wikipedia_family.py b/pywikibot/families/wikipedia_family.py index 2f67c08..3cc3f05 100644 --- a/pywikibot/families/wikipedia_family.py +++ b/pywikibot/families/wikipedia_family.py @@ -217,17 +217,17 @@ 'de': ('Archiv',), }
- def get_known_families(self, site): + def get_known_families(self, code): """Override the family interwiki prefixes for each site.""" # In Swedish Wikipedia 's:' is part of page title not a family # prefix for 'wikisource'. - if site.code == 'sv': + if code == 'sv': d = self.known_families.copy() d.pop('s') d['src'] = 'wikisource' return d - else: - return self.known_families + + return self.known_families
def encodings(self, code): """Return a list of historical encodings for a specific site.""" diff --git a/pywikibot/family.py b/pywikibot/family.py index b4d5ad9..d509e77 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -748,7 +748,7 @@ return list(cls.langs.keys())
@deprecated('APISite.interwiki', since='20151014', future_warning=True) - def get_known_families(self, site): + def get_known_families(self, code): """DEPRECATED: Return dict of inter-family interwiki links.""" return self.known_families